You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/07/02 10:46:21 UTC
[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #12: Make a test set for #1
mocobeta opened a new issue, #12:
URL: https://github.com/apache/lucene-jira-archive/issues/12
There are too many patterns where markup can be broken. Can't make sure that an ad-hoc fix for one problem does not introduce another bug.
Instead of arbitrary choosing examples, it'd be good to have a carefully selected test set that includes various markup combinations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #12: Make a test set for improving markup conversion quality
Posted by GitBox <gi...@apache.org>.
mikemccand commented on issue #12:
URL: https://github.com/apache/lucene-jira-archive/issues/12#issuecomment-1179704669
> * [LUCENE-2230](https://github.com/mocobeta/sandbox-lucene-10557/issues/2472) - won't fix, maybe not a big problem
Hi @mocobeta -- I couldn't understand what went wrong in this issue?
Indeed, there was at least one comment (I think?) where the author used Markdown (which does not work in Jira, yet many of us forget and use it anyway, just like seeing a naked `bq.` here on GitHub or in emails!) and then the rendering worked on migration! A surprising benefit of migration ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #12: Make a test set for improving markup conversion quality
Posted by GitBox <gi...@apache.org>.
mocobeta commented on issue #12:
URL: https://github.com/apache/lucene-jira-archive/issues/12#issuecomment-1179721279
> I sort of think this is a feature not a bug? But, it is not a priority to handle these mixed cases well! If the converter is escaping some and missing others I think we can let it be, unless it's impacting too many cases.
I've seen some quote symbols `>` were escaped in the converted results but not sure if this is a "feature" or "bug"... I think there may be mixed situations (some markdowns are preserved as-is and rendered as the authors intended, and some are escaped).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #12: Make a test set for improving markup conversion quality
Posted by GitBox <gi...@apache.org>.
mocobeta commented on issue #12:
URL: https://github.com/apache/lucene-jira-archive/issues/12#issuecomment-1180040078
> Indeed, there was at least one comment (I think?) where the author used Markdown (which does not work in Jira, yet many of us forget and use it anyway, just like seeing a naked `bq.` here on GitHub or in emails!) and then the rendering worked on migration! A surprising benefit of migration ;)
I reviewed the converter library's code again. Your insight is correct - it seems there is no escaping for Markdown, so _if there are no extra space characters that interfere with the frontend_, Markdowns in Jira are rendered in GitHub (as the authors might expect).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #12: Make a test set for improving markup conversion quality
Posted by GitBox <gi...@apache.org>.
mocobeta commented on issue #12:
URL: https://github.com/apache/lucene-jira-archive/issues/12#issuecomment-1179706447
> Hi @mocobeta -- I couldn't understand what went wrong in this issue?
I meant this comment. This should be plain text, not interpreted as headers.
> Indeed, there was at least one comment (I think?) where the author used Markdown (which does not work in Jira, yet many of us forget and use it anyway, just like seeing a naked bq. here on GitHub or in emails!) and then the rendering worked on migration! A surprising benefit of migration ;)
I don't think unintentional markdowns will be properly rendered after migration. Markdowns in Jira are (correctly) escaped in the converter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #12: Make a test set for improving markup conversion quality
Posted by GitBox <gi...@apache.org>.
mocobeta commented on issue #12:
URL: https://github.com/apache/lucene-jira-archive/issues/12#issuecomment-1207166202
I'm closing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #12: Make a test set for improving markup conversion quality
Posted by GitBox <gi...@apache.org>.
mikemccand commented on issue #12:
URL: https://github.com/apache/lucene-jira-archive/issues/12#issuecomment-1179718268
> I don't think unintentional markdowns will be properly rendered after migration. Markdowns in Jira are (correctly) escaped in the converter.
Oh, I though the original author of that comment (Fuad) indeed meant for those `=======` to become headers, and I was happy that the converter "missed" escaping them.
Here is another example (comment) from that same issue where the "miss" was great -- we properly rendered a code block in the GitHub issue when Jira missed it:
Original JIra:
The original comment used block indentation, which MD interprets as code block.
I sort of think this is a feature not a bug? But, it is not a priority to handle these mixed cases well! If the converter is escaping some and missing others I think we can let it be, unless it's impacting too many cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #12: Make a test set for improving markup conversion quality
Posted by GitBox <gi...@apache.org>.
mocobeta commented on issue #12:
URL: https://github.com/apache/lucene-jira-archive/issues/12#issuecomment-1172897263
Supported block elements in [Jira Text Formatting](https://jira.atlassian.com/secure/WikiRendererHelpAction.jspa?section=all)
- `-`: not included
- `o`: correctly rendered
- `x`: broken
|Issue|Quote|Bullet list|Numbered list|Noformat/Code|Table|
|-|-|-|-|-|-|
|[LUCENE-10560](https://github.com/mocobeta/sandbox-lucene-10557/issues/10793)|-|-|-|o|-|
[LUCENE-10559](https://github.com/mocobeta/sandbox-lucene-10557/issues/10792)|-|-|-|-|x|
|[LUCENE-10557](https://github.com/mocobeta/migration-test-2/issues/155)|x|x|x|o|x|
|[LUCENE-10544](https://github.com/mocobeta/sandbox-lucene-10557/issues/10777)|x|x|-|o|-|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta closed issue #12: Make a test set for improving markup conversion quality
Posted by GitBox <gi...@apache.org>.
mocobeta closed issue #12: Make a test set for improving markup conversion quality
URL: https://github.com/apache/lucene-jira-archive/issues/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org