[GitHub] [kafka] ashmeet13 commented on pull request #12684: KAFKA-14254; Format timestamps as dates in logs

[GitBox <gi...@apache.org>]

ashmeet13 commented on PR #12684:
URL: https://github.com/apache/kafka/pull/12684#issuecomment-1264352757

   Hey @divijvaidya,
   Thank you for the inputs. With respect to the second point - do you think we should replace the current implementation from `Instant.ofEpochMilli` to something like - 
   ```
   final String nextRebalanceTime = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss,SSS").format(new Date(nextRebalanceTimeMs));
   ```
   
   and use `nextRebalanceTime` in logs?
   
   ---
   A preview of how the logs are now - 
   
   ```
   [2022-10-01 18:07:52,605] INFO stream-thread [] Requesting followup rebalance be scheduled by consumer10 for 2022-10-01 18:17:52,601 to probe for caught-up replica tasks. (org.apache.kafka.streams.processor.internals.StreamsPartitionAssignor:964)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org