You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/28 11:13:04 UTC
[GitHub] [airflow] kaxil opened a new pull request #8602: Pin Flask-Appbuilder to 2.3.2
kaxil opened a new pull request #8602:
URL: https://github.com/apache/airflow/pull/8602
closes https://github.com/apache/airflow/issues/8599
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #8602: Pin Flask-Appbuilder to 2.3.2
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #8602:
URL: https://github.com/apache/airflow/pull/8602#issuecomment-620636624
re-requesting reviews as I had to add https://github.com/apache/airflow/pull/8602/commits/54dc7f0b5448f0167473e5ab20c4e39b0629a33d too as the tests were failing.
Context: `email_validator` made it an optional dependency by WTForms but is used by FAB and the added it to their dependency in 2.3.3 but if we use 2.3.2 we need to import email_validator ourselves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #8602: Pin Flask-Appbuilder to 2.3.2
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #8602:
URL: https://github.com/apache/airflow/pull/8602#issuecomment-620636624
Added https://github.com/apache/airflow/pull/8602/commits/54dc7f0b5448f0167473e5ab20c4e39b0629a33d too as the tests were failing.
Context: `email_validator` made it an optional dependency by WTForms but is used by FAB and the added it to their dependency in 2.3.3 but if we use 2.3.2 we need to import email_validator ourselves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org