[GitHub] [pulsar] congbobo184 commented on a diff in pull request #15675: [Improve][txn] extend admin tools for transaction component.

[GitBox <gi...@apache.org>]

congbobo184 commented on code in PR #15675:
URL: https://github.com/apache/pulsar/pull/15675#discussion_r887541164


##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/TransactionBufferStats.java:
##########
@@ -28,4 +30,13 @@ public class TransactionBufferStats {
 
     /** The last snapshot timestamps of this transaction buffer. */
     public long lastSnapshotTimestamps;
+
+    /**
+     * (Optional) The lowWaterMark details of the transaction buffer.
+     */
+    public ConcurrentHashMap<Long, Long> lowWaterMarks;
+    /**
+     * The total number of ongoing transactions in this transaction buffer.
+     */
+    public long ongoingTxns;

Review Comment:
   ongoingTxnSize



##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/TransactionPendingAckStats.java:
##########
@@ -18,8 +18,20 @@
  */
 package org.apache.pulsar.common.policies.data;
 
+import java.util.concurrent.ConcurrentHashMap;
+
 public class TransactionPendingAckStats {
 
     /** The state of this pending ack. */
     public String state;
+
+    /**
+     * (Optional) The lowWaterMark details of the transaction pending ack.
+     */
+    public ConcurrentHashMap<Long, Long> lowWaterMarks;
+
+    /**
+     * The total number of ongoing transactions in this transaction pending ack.
+     */
+    public long ongoingTxns;

Review Comment:
   ongoingTxnSize



##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/TransactionCoordinatorStats.java:
##########
@@ -34,4 +34,9 @@ public class TransactionCoordinatorStats {
 
     /** The low water mark of transaction metadataStore. */
     public long lowWaterMark;
+
+    /**
+     *  The total number of ongoing transactions in this transaction coordinator.
+     */
+    public long ongoningTxns;

Review Comment:
   ongoingTxnSize



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org