[GitHub] [openwhisk] mcdan commented on a change in pull request #4915: Add the ability to limit the amount of disk given to the action pod in k8s

[GitBox <gi...@apache.org>]

mcdan commented on a change in pull request #4915:
URL: https://github.com/apache/openwhisk/pull/4915#discussion_r435511284



##########
File path: core/invoker/src/main/resources/application.conf
##########
@@ -107,6 +107,14 @@ whisk {
     #  "POD_UID": "metadata.uid"
     #}
 
+    #if missing, the pod will be created without ephermal disk request/limit
+    #if specified, the pod will be created with ephemeral-storage request+limit set
+    #See: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#local-ephemeral-storage
+    #ephemeral-storage {
+    #  limit = 2 g
+    #  request = 500 m

Review comment:
       That's a good point, I will limit the configuration to just a limit and set the request to the same value. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org