You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/29 09:26:19 UTC
[GitHub] [spark] Yikun opened a new pull request, #37705: [SPARK-40256][K8S] Switch base image from openjdk to eclipse-temurin
Yikun opened a new pull request, #37705:
URL: https://github.com/apache/spark/pull/37705
### What changes were proposed in this pull request?
This PR switchs the base image from [`openjdk`](https://hub.docker.com/_/openjdk) to [`eclipse-temurin`](https://hub.docker.com/_/eclipse-temurin) (original openjdk).
The core change is: the OS of base image changes `debian-bullseye` to `ubuntu-focal` (based on debian bullseye).
### Why are the changes needed?
- According to https://github.com/docker-library/openjdk/issues/505 and https://github.com/docker-library/docs/pull/2162, openjdk:8/11 image is EOL and Eclipse Temurin is one of the image to replace this, the original openjdk image will `remove the 11 and 8 tags (in October 2022, perhaps)` (we are using it in spark), so we have to switch this before it happens.
- The `openjdk` is [not update anymore](https://adoptopenjdk.net/upstream.html) (the last releases were 8u342 and 11.0.16, Eclipse Temurin replace is recommanded by adoptopenjdk) that means even the 8/11 tag is not removed, we still need to switch `openjdk`.
- There were [many docker official image](https://github.com/search?q=org%3Adocker-library+temurin&type=code) already switch openjdk to eclipse-temurin.
- An ideal long-term solution is that we only choose the jdk version and leave the adaptation of OS to the corresponding openjdk official image (just like eclipse-temurin are suppoort [ubuntu, alpine, centos](https://github.com/adoptium/containers/tree/main/11/jre))
- The alternate solution is we just swith `openjdk` image to `debian-bullseye` with openjdk 11 installation. like: https://github.com/Yikun/spark/pull/163. But it makes spark image **depends on debian OS more**, that means we will diffcult to support the Java version which debian OS doesn't support (such as openjdk-8-jre is not be supported in current debian anymore).
For the above reason, I think `eclipse-temurin` is a good choice.
### Does this PR introduce _any_ user-facing change?
Yes, the docker images base image changes.
### How was this patch tested?
CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37705: [SPARK-40256][BUILD][K8S] Switch base image from openjdk to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37705:
URL: https://github.com/apache/spark/pull/37705#issuecomment-1231719728
I did a complete a e2e test on docker image:
```shell
# openjdk base
./bin/docker-image-tool.sh -r yikunkero -p ./kubernetes/dockerfiles/spark/bindings/python/Dockerfile -R ./kubernetes/dockerfiles/spark/bindings/R/Dockerfile -t v3.3.0-temurin -X -b java_image_tag=11-jre-focal push
# eclipse-temurin(apply Dockerfile patch) on v3.3.0
./bin/docker-image-tool.sh -r yikunkero -p ./kubernetes/dockerfiles/spark/bindings/python/Dockerfile -R ./kubernetes/dockerfiles/spark/bindings/R/Dockerfile -t v3.3.0 -X -b java_image_tag=11-jre-slim push
```
| | openjdk(11-jre-slim) | eclipse-temurin(11-jre-focal) |
|----------|----------------------|-------------------------------|
| [spark](https://hub.docker.com/repository/registry-1.docker.io/yikunkero/spark/tags?page=1&ordering=last_updated) | 376.51 MB | 399.21 MB |
| [spark-py](https://hub.docker.com/repository/registry-1.docker.io/yikunkero/spark-py/tags?page=1&ordering=last_updated) | 656.88 MB | 628.24 MB |
| [spark-r](https://hub.docker.com/repository/registry-1.docker.io/yikunkero/spark-r/tags?page=1&ordering=last_updated) | 496.45 MB | 500.79 MB |
All images works well, and no more image size gain (you can click each link to see detail).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #37705: [SPARK-40256][BUILD][K8S] Switch base image from openjdk to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #37705:
URL: https://github.com/apache/spark/pull/37705#issuecomment-1232157656
The changes are straightforward and reasonable. Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #37705: [SPARK-40256][BUILD][K8S] Switch base image from openjdk to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #37705: [SPARK-40256][BUILD][K8S] Switch base image from openjdk to eclipse-temurin
URL: https://github.com/apache/spark/pull/37705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37705: [SPARK-40256][K8S] Switch base image from openjdk to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37705:
URL: https://github.com/apache/spark/pull/37705#issuecomment-1230020566
The alternate solution is we just swith `openjdk` image to `debian-bullseye` with openjdk 11 installation. like: https://github.com/Yikun/spark/pull/163. But it makes spark image **depends on debian OS more**, that means we will diffcult to support the Java version which debian OS doesn't support (such as openjdk-8-jre is not be supported in current debian anymore).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37705: [SPARK-40256][BUILD][K8S] Switch base image from openjdk to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37705:
URL: https://github.com/apache/spark/pull/37705#issuecomment-1232224741
Thank you, @Yikun , @HyukjinKwon , @gengliangwang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37705: [SPARK-40256][BUILD][K8S] Switch base image from openjdk to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37705:
URL: https://github.com/apache/spark/pull/37705#issuecomment-1231111292
@dongjoon-hyun @gengliangwang @HyukjinKwon Thanks for your comments! I will test more today then make it ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37705: [SPARK-40256][K8S] Switch base image from openjdk to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37705:
URL: https://github.com/apache/spark/pull/37705#issuecomment-1230017182
cc @dongjoon-hyun @holdenk @HyukjinKwon
This might be a big change but we have to do (replace openjdk by some other base images).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org