You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ma...@apache.org on 2022/12/12 18:33:08 UTC
[flink-connector-pulsar] 03/31: [hotfix][connector/testing-framework] Let ExternalContext#generateTestData returns List to preserve order
This is an automated email from the ASF dual-hosted git repository.
martijnvisser pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-connector-pulsar.git
commit 52cbdb59d5103c319ff70f789a6837c17beb0dce
Author: Qingsheng Ren <re...@gmail.com>
AuthorDate: Mon Aug 23 17:18:13 2021 +0800
[hotfix][connector/testing-framework] Let ExternalContext#generateTestData returns List to preserve order
---
.../flink/tests/util/pulsar/cases/KeySharedSubscriptionContext.java | 3 +--
.../flink/tests/util/pulsar/cases/SharedSubscriptionContext.java | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/flink-connector-pulsar-e2e-tests/src/test/java/org/apache/flink/tests/util/pulsar/cases/KeySharedSubscriptionContext.java b/flink-connector-pulsar-e2e-tests/src/test/java/org/apache/flink/tests/util/pulsar/cases/KeySharedSubscriptionContext.java
index e442418..5d937ba 100644
--- a/flink-connector-pulsar-e2e-tests/src/test/java/org/apache/flink/tests/util/pulsar/cases/KeySharedSubscriptionContext.java
+++ b/flink-connector-pulsar-e2e-tests/src/test/java/org/apache/flink/tests/util/pulsar/cases/KeySharedSubscriptionContext.java
@@ -36,7 +36,6 @@ import org.apache.pulsar.client.api.SubscriptionType;
import org.apache.pulsar.common.util.Murmur3_32Hash;
import java.util.ArrayList;
-import java.util.Collection;
import java.util.List;
import static java.util.Collections.singletonList;
@@ -116,7 +115,7 @@ public class KeySharedSubscriptionContext extends PulsarTestContext<String> {
}
@Override
- public Collection<String> generateTestData(int splitIndex, long seed) {
+ public List<String> generateTestData(int splitIndex, long seed) {
return generateStringTestData(splitIndex, seed);
}
diff --git a/flink-connector-pulsar-e2e-tests/src/test/java/org/apache/flink/tests/util/pulsar/cases/SharedSubscriptionContext.java b/flink-connector-pulsar-e2e-tests/src/test/java/org/apache/flink/tests/util/pulsar/cases/SharedSubscriptionContext.java
index f936b6f..52e30b3 100644
--- a/flink-connector-pulsar-e2e-tests/src/test/java/org/apache/flink/tests/util/pulsar/cases/SharedSubscriptionContext.java
+++ b/flink-connector-pulsar-e2e-tests/src/test/java/org/apache/flink/tests/util/pulsar/cases/SharedSubscriptionContext.java
@@ -33,7 +33,6 @@ import org.apache.pulsar.client.api.RegexSubscriptionMode;
import org.apache.pulsar.client.api.SubscriptionType;
import java.util.ArrayList;
-import java.util.Collection;
import java.util.List;
import static org.apache.flink.connector.pulsar.source.reader.deserializer.PulsarDeserializationSchema.pulsarSchema;
@@ -90,7 +89,7 @@ public class SharedSubscriptionContext extends PulsarTestContext<String> {
}
@Override
- public Collection<String> generateTestData(int splitIndex, long seed) {
+ public List<String> generateTestData(int splitIndex, long seed) {
return generateStringTestData(splitIndex, seed);
}