You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2021/12/17 12:53:03 UTC

[camel] 02/03: Polished

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 0cb3b54de0ccd36a090ca56e9faec56f8ae93781
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Fri Dec 17 13:03:44 2021 +0100

    Polished
---
 .../management/mbean/ManagedBacklogDebuggerMBean.java  | 18 +++++++++---------
 .../camel/management/mbean/ManagedBacklogDebugger.java |  8 ++++----
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedBacklogDebuggerMBean.java b/core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedBacklogDebuggerMBean.java
index 0426cfb..e75daf2 100644
--- a/core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedBacklogDebuggerMBean.java
+++ b/core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedBacklogDebuggerMBean.java
@@ -121,16 +121,16 @@ public interface ManagedBacklogDebuggerMBean {
     @ManagedAttribute(description = "Number of maximum chars in the message body in the trace message. Use zero or negative value to have unlimited size.")
     void setBodyMaxChars(int bodyMaxChars);
 
-    @ManagedAttribute(description = "Fallback Timeout in seconds when block the message processing in Camel.")
+    @ManagedAttribute(description = "Fallback Timeout in seconds when block the message processing in Camel")
     long getFallbackTimeout();
 
-    @ManagedAttribute(description = "Fallback Timeout in seconds when block the message processing in Camel.")
+    @ManagedAttribute(description = "Fallback Timeout in seconds when block the message processing in Camel")
     void setFallbackTimeout(long fallbackTimeout);
 
-    @ManagedAttribute(description = "Whether to include stream based message body in the trace message.")
+    @ManagedAttribute(description = "Whether to include stream based message body in the trace message")
     boolean isBodyIncludeStreams();
 
-    @ManagedAttribute(description = "Whether to include stream based message body in the trace message.")
+    @ManagedAttribute(description = "Whether to include stream based message body in the trace message")
     void setBodyIncludeStreams(boolean bodyIncludeStreams);
 
     @ManagedAttribute(description = "Whether to include file based message body in the trace message.")
@@ -155,12 +155,12 @@ public interface ManagedBacklogDebuggerMBean {
     @ManagedOperation(description = "Resets the debug counter")
     void resetDebugCounter();
 
-    @ManagedOperation(description = "Used for validating if a given predicate is valid or not")
+    @ManagedOperation(description = "Used for validating if a given breakpoint condition (predicate) is valid or not")
     String validateConditionalBreakpoint(String language, String predicate);
 
-    @ManagedOperation(description = "Evaluates the expression at a given breakpoint Id")
-    Object evaluateExpressionAtBreakpoint(String id, String language, String expression, String resultType);
+    @ManagedOperation(description = "Evaluates the expression at a given breakpoint node id")
+    Object evaluateExpressionAtBreakpoint(String nodeId, String language, String expression, String resultType);
 
-    @ManagedOperation(description = "Evaluates the expression at a given breakpoint Id and returns the result as String")
-    String evaluateExpressionAtBreakpoint(String id, String language, String expression);
+    @ManagedOperation(description = "Evaluates the expression at a given breakpoint node id and returns the result as String")
+    String evaluateExpressionAtBreakpoint(String nodeId, String language, String expression);
 }
diff --git a/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedBacklogDebugger.java b/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedBacklogDebugger.java
index da725db..f9d8eeb 100644
--- a/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedBacklogDebugger.java
+++ b/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedBacklogDebugger.java
@@ -296,16 +296,16 @@ public class ManagedBacklogDebugger implements ManagedBacklogDebuggerMBean {
     }
 
     @Override
-    public String evaluateExpressionAtBreakpoint(String id, String language, String expression) {
-        return evaluateExpressionAtBreakpoint(id, language, expression, "java.lang.String").toString();
+    public String evaluateExpressionAtBreakpoint(String nodeId, String language, String expression) {
+        return evaluateExpressionAtBreakpoint(nodeId, language, expression, "java.lang.String").toString();
     }
 
     @Override
-    public Object evaluateExpressionAtBreakpoint(String id, String language, String expression, String resultType) {
+    public Object evaluateExpressionAtBreakpoint(String nodeId, String language, String expression, String resultType) {
         Exchange suspendedExchange;
         try {
             Language lan = camelContext.resolveLanguage(language);
-            suspendedExchange = backlogDebugger.getSuspendedExchange(id);
+            suspendedExchange = backlogDebugger.getSuspendedExchange(nodeId);
             if (suspendedExchange != null) {
                 Object result;
                 Class<?> resultClass = camelContext.getClassResolver().resolveMandatoryClass(resultType);