You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jdaugherty (via GitHub)" <gi...@apache.org> on 2026/04/04 14:38:14 UTC
[PR] Spring Boot Follow-ups [grails-core]
jdaugherty opened a new pull request, #15554:
URL: https://github.com/apache/grails-core/pull/15554
@jamesfredley your AI was hallucinating on these tests. The embedded servlet context class is now 'AnnotationConfigServletWebServerApplicationContext'. The tests pass once this was updated.
I've also restored the `@CompileStatic` that was removed by your PR in the GrailsApplicationBuilder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spring Boot Follow-ups [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15554:
URL: https://github.com/apache/grails-core/pull/15554#issuecomment-4187275184
## ✅ All tests passed ✅
🏷️ Commit: 1314a2e45c4d92144c0c3c79ba7d359d9808ac5f
▶️ Tests: 31365 executed
⚪️ Checks: 31/31 completed
---
_Learn more about TestLens at [testlens.app](https://testlens.app)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spring Boot Follow-ups [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #15554:
URL: https://github.com/apache/grails-core/pull/15554#discussion_r3035657164
##########
grails-core/build.gradle:
##########
@@ -44,16 +44,13 @@ dependencies {
implementation 'com.github.ben-manes.caffeine:caffeine'
api 'org.apache.groovy:groovy'
api 'org.springframework.boot:spring-boot'
+ api 'org.springframework.boot:spring-boot-web-server'
Review Comment:
FYI: Spring-boot-web-server was split from spring-boot. We need to include it for end apps to work the same since we don't support the other options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spring Boot Follow-ups [grails-core]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #15554:
URL: https://github.com/apache/grails-core/pull/15554#issuecomment-4187219073
<!-- Bito Reply -->
The change moves spring-boot-web-server from implementation to API dependency in grails-core/build.gradle, which matches the split from spring-boot. This ensures end apps maintain the same functionality without supporting alternative options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spring Boot Follow-ups [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #15554:
URL: https://github.com/apache/grails-core/pull/15554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spring Boot Follow-ups [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #15554:
URL: https://github.com/apache/grails-core/pull/15554#issuecomment-4187216797
@jamesfredley with the split of the tomcat classes into their own library, since we're forced to use the embedded tomcat, I think we're going to have to add `org.springframework.boot:spring-boot-tomcat` to our generated apps. The tomcat starter being added as a test dependency is likely why the tests are working in the spring boot 4 branch. We need to:
1. Update the tomcat feature so the correct libraries are included since we're not using the starter
2. Remove /disable the undretow feature since undertow is not yet on the servlet 6.1 api so boot can't support it
3. possibly create the new project to make tomcat specific dependencies more clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org