You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/26 12:22:45 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #8896:
[FLINK-12993][runtime] Refactor forceReleaseOnConsumption to JM concept
azagrebin commented on a change in pull request #8896: [FLINK-12993][runtime] Refactor forceReleaseOnConsumption to JM concept
URL: https://github.com/apache/flink/pull/8896#discussion_r297633733
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionFactoryTest.java
##########
@@ -39,23 +40,22 @@
public class ResultPartitionFactoryTest extends TestLogger {
@Test
- public void testForceConsumptionOnReleaseEnabled() {
- testForceConsumptionOnRelease(true);
+ public void testConsumptionOnReleaseEnabled() {
+ testConsumptionOnRelease(true);
Review comment:
if `testConsumptionOnRelease` returned `ResultPartition`, you could do the assertion here.
Also `testConsumptionOnRelease ` could directly accept the `ReleaseType` then there would be less ifs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services