[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #1967: [KYUUBI #1963] Make plan only mode skippable for configuable plans

[GitBox <gi...@apache.org>]

SteNicholas commented on a change in pull request #1967:
URL: https://github.com/apache/incubator-kyuubi/pull/1967#discussion_r813497826



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/PlanOnlyStatement.scala
##########
@@ -36,6 +36,11 @@ class PlanOnlyStatement(
   extends SparkOperation(OperationType.EXECUTE_STATEMENT, session) {
 
   private val operationLog: OperationLog = OperationLog.createOperationLog(session, getHandle)
+  private val configExcludes: Option[String] =
+    spark.conf.getOption(OPERATION_PLAN_ONLY_EXCLUDES.key)
+  private val planExcludes: Seq[String] =
+    if (configExcludes.isEmpty) session.sessionManager.getConf.get(OPERATION_PLAN_ONLY_EXCLUDES)
+    else configExcludes.get.split(",").toSeq

Review comment:
       @cfmcgrady, the return value of the `session.sessionManager.getConf.get(OPERATION_PLAN_ONLY_EXCLUDES)` is string sequence. Thus, the above suggestion has something wrong because you map the `Option`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org