You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/19 04:43:08 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
HyukjinKwon opened a new pull request #34661:
URL: https://github.com/apache/spark/pull/34661
### What changes were proposed in this pull request?
This PR proposes to increase timeout for job termination in SchedulerIntegrationSuite to deflake the tests.
### Why are the changes needed?
Currently `HealthTrackerIntegrationSuite.If preferred node is bad, without excludeOnFailure job will fail` is flaky:
```
sbt.ForkMain$ForkError: java.util.concurrent.TimeoutException: Futures timed out after [10 seconds]
at scala.concurrent.impl.Promise$DefaultPromise.ready(Promise.scala:259)
at scala.concurrent.impl.Promise$DefaultPromise.ready(Promise.scala:187)
at org.apache.spark.util.ThreadUtils$.awaitReady(ThreadUtils.scala:334)
at org.apache.spark.scheduler.SchedulerIntegrationSuite.awaitJobTermination(SchedulerIntegrationSuite.scala:274)
at org.apache.spark.scheduler.HealthTrackerIntegrationSuite.$anonfun$new$3(HealthTrackerIntegrationSuite.scala:50)
at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
at org.apache.spark.scheduler.SchedulerIntegrationSuite.withBackend(SchedulerIntegrationSuite.scala:261)
at org.apache.spark.scheduler.HealthTrackerIntegrationSuite.$anonfun$new$1(HealthTrackerIntegrationSuite.scala:48)
at org.apache.spark.scheduler.SchedulerIntegrationSuite.$anonfun$testScheduler$1(SchedulerIntegrationSuite.scala:98)
at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
at org.scalatest.Transformer.apply(Transformer.scala:22)
at org.scalatest.Transformer.apply(Transformer.scala:20)
at org.scalatest.funsuite.AnyFunSuiteLike$$anon$1.apply(AnyFunSuiteLike.scala:226)
at org.apache.spark.SparkFunSuite.withFixture(SparkFunSuite.scala:190)
at org.scalatest.funsuite.AnyFunSuiteLike.invokeWithFixture$1(AnyFunSuiteLike.scala:224)
at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$runTest$1(AnyFunSuiteLike.scala:236)
```
e.g.) https://github.com/apache/spark/runs/4259932001
This PR fixes it.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
Should monitor GitHub Actions builds after it got merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34661:
URL: https://github.com/apache/spark/pull/34661#issuecomment-973780848
Tests passed (https://github.com/HyukjinKwon/spark/runs/4260376896?check_suite_focus=true).
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34661:
URL: https://github.com/apache/spark/pull/34661#issuecomment-973805495
**[Test build #145433 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145433/testReport)** for PR 34661 at commit [`c9a615a`](https://github.com/apache/spark/commit/c9a615a49d9182dafbf61312d6f89bb468b9b338).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34661:
URL: https://github.com/apache/spark/pull/34661#issuecomment-973794157
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49906/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34661:
URL: https://github.com/apache/spark/pull/34661#issuecomment-973770113
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49906/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34661:
URL: https://github.com/apache/spark/pull/34661#issuecomment-973730846
**[Test build #145433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145433/testReport)** for PR 34661 at commit [`c9a615a`](https://github.com/apache/spark/commit/c9a615a49d9182dafbf61312d6f89bb468b9b338).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34661:
URL: https://github.com/apache/spark/pull/34661#issuecomment-973830075
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145433/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34661:
URL: https://github.com/apache/spark/pull/34661#issuecomment-973770130
Thanks @Ngone51 !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34661:
URL: https://github.com/apache/spark/pull/34661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34661:
URL: https://github.com/apache/spark/pull/34661#issuecomment-973788477
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49906/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34661:
URL: https://github.com/apache/spark/pull/34661#issuecomment-973794157
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49906/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34661:
URL: https://github.com/apache/spark/pull/34661#issuecomment-973730572
cc @Ngone51, mind taking a quick look please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34661:
URL: https://github.com/apache/spark/pull/34661#issuecomment-973830075
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145433/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34661:
URL: https://github.com/apache/spark/pull/34661#issuecomment-973743092
Thanks @dongjoon-hyun !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34661:
URL: https://github.com/apache/spark/pull/34661#issuecomment-973730846
**[Test build #145433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145433/testReport)** for PR 34661 at commit [`c9a615a`](https://github.com/apache/spark/commit/c9a615a49d9182dafbf61312d6f89bb468b9b338).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org