You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/07/09 22:59:47 UTC
[kudu-CR] Remove experimental tags from NVM block cache gflags
Hello Andrew Wong, ye yuqiang,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13830
to review the following change.
Change subject: Remove experimental tags from NVM block cache gflags
......................................................................
Remove experimental tags from NVM block cache gflags
The block cache has supported non-volatile memory for almost four years
now, though one needed to configure some experimental gflags in order to
use it. The implementation was recently changed to use the newer memkind
library and, in the process, underwent additional testing on NVM hardware.
As such, I think it's time to remove the experimental tags to communicate to
users that the underlying code is supported upstream.
Note: I'm not marking them as 'stable' so that we retain the flexibility to
modify the configuration surface itself, if we find we need that.
Change-Id: Ie6b58118116ecc11b2eaa5cec4a9e72c29ac27f8
---
M src/kudu/cfile/block_cache.cc
M src/kudu/util/nvm_cache.cc
2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/13830/1
--
To view, visit http://gerrit.cloudera.org:8080/13830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6b58118116ecc11b2eaa5cec4a9e72c29ac27f8
Gerrit-Change-Number: 13830
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
[kudu-CR] Remove experimental tags from NVM block cache gflags
Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/13830 )
Change subject: Remove experimental tags from NVM block cache gflags
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b58118116ecc11b2eaa5cec4a9e72c29ac27f8
Gerrit-Change-Number: 13830
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
Gerrit-Comment-Date: Tue, 09 Jul 2019 23:05:45 +0000
Gerrit-HasComments: No
[kudu-CR] Remove experimental tags from NVM block cache gflags
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13830 )
Change subject: Remove experimental tags from NVM block cache gflags
......................................................................
Patch Set 1: Code-Review-2
Don't merge this yet. I've hit a snag in a test on NVM hardware that I want to explore further.
--
To view, visit http://gerrit.cloudera.org:8080/13830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b58118116ecc11b2eaa5cec4a9e72c29ac27f8
Gerrit-Change-Number: 13830
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
Gerrit-Comment-Date: Tue, 09 Jul 2019 23:23:10 +0000
Gerrit-HasComments: No
[kudu-CR] Remove experimental tags from NVM block cache gflags
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13830 )
Change subject: Remove experimental tags from NVM block cache gflags
......................................................................
Remove experimental tags from NVM block cache gflags
The block cache has supported non-volatile memory for almost four years
now, though one needed to configure some experimental gflags in order to
use it. The implementation was recently changed to use the newer memkind
library and, in the process, underwent additional testing on NVM hardware.
As such, I think it's time to remove the experimental tags to communicate to
users that the underlying code is supported upstream.
Note: I'm not marking them as 'stable' so that we retain the flexibility to
modify the configuration surface itself, if we find we need that.
Change-Id: Ie6b58118116ecc11b2eaa5cec4a9e72c29ac27f8
Reviewed-on: http://gerrit.cloudera.org:8080/13830
Reviewed-by: Greg Solovyev <gs...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/cfile/block_cache.cc
M src/kudu/util/nvm_cache.cc
2 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
Greg Solovyev: Looks good to me, but someone else must approve
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6b58118116ecc11b2eaa5cec4a9e72c29ac27f8
Gerrit-Change-Number: 13830
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
[kudu-CR] Remove experimental tags from NVM block cache gflags
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13830 )
Change subject: Remove experimental tags from NVM block cache gflags
......................................................................
Patch Set 1: -Code-Review
> Don't merge this yet. I've hit a snag in a test on NVM hardware that I want to explore further.
I think the Kudu code is fine; I was testing on a kernel that was unsupported by the underlying NVM hardware, and apparently some instability is expected in this case.
--
To view, visit http://gerrit.cloudera.org:8080/13830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b58118116ecc11b2eaa5cec4a9e72c29ac27f8
Gerrit-Change-Number: 13830
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
Gerrit-Comment-Date: Wed, 10 Jul 2019 05:41:18 +0000
Gerrit-HasComments: No
[kudu-CR] Remove experimental tags from NVM block cache gflags
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13830 )
Change subject: Remove experimental tags from NVM block cache gflags
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b58118116ecc11b2eaa5cec4a9e72c29ac27f8
Gerrit-Change-Number: 13830
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
Gerrit-Comment-Date: Tue, 09 Jul 2019 23:06:44 +0000
Gerrit-HasComments: No