You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kevingurney (via GitHub)" <gi...@apache.org> on 2023/08/15 20:58:06 UTC
[GitHub] [arrow] kevingurney opened a new pull request, #37190: GH-37188: Move `test/util/featherRoundTrip.m` into a packaged test utility function
kevingurney opened a new pull request, #37190:
URL: https://github.com/apache/arrow/pull/37190
### Rationale for this change
In order to simplify access to the `featherRoundTrip` function that is used in the `tfeather.m` tests, it would be helpful to move it into a packaged test utility function. This would make it possible to`import` the function, rather than having to manually add the `test/util` folder to the MATLAB Search Path in the test class setup.
### What changes are included in this PR?
1. Moved `test/util/featherRoundTrip.m` code into a new internal packaged test utility function `arrow.internal.test.io.feather.roundtrip`.
### Are these changes tested?
Yes.
1. Updated all `tfeather.m` test cases to use new packaged function `arrow.internal.test.io.feather.roundtrip`.
### Are there any user-facing changes?
No.
This new packaged function is an internal test utility.
### Future Directions
1. Delete the old Feather MEX code.
2. Move more shared test infrastructure into packaged test functions under `arrow.internal.test.*`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sgilmore10 commented on a diff in pull request #37190: GH-37188: [MATLAB] Move `test/util/featherRoundTrip.m` into a packaged test utility function
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #37190:
URL: https://github.com/apache/arrow/pull/37190#discussion_r1296066436
##########
matlab/src/matlab/+arrow/+internal/+test/+io/+feather/roundtrip.m:
##########
@@ -1,6 +1,5 @@
-function tableOut = featherRoundTrip(filename, tableIn)
-% FEATHERROUNDTRIP Helper function for round tripping a table
-% to a Feather file.
+% ROUNDTRIP Test utility for round tripping a MATLAB
+% table to a Feather V1 file.
Review Comment:
round tripping a MATLAB table to ***and from*** a Feather V1 File?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sgilmore10 commented on a diff in pull request #37190: GH-37188: [MATLAB] Move `test/util/featherRoundTrip.m` into a packaged test utility function
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #37190:
URL: https://github.com/apache/arrow/pull/37190#discussion_r1296066436
##########
matlab/src/matlab/+arrow/+internal/+test/+io/+feather/roundtrip.m:
##########
@@ -1,6 +1,5 @@
-function tableOut = featherRoundTrip(filename, tableIn)
-% FEATHERROUNDTRIP Helper function for round tripping a table
-% to a Feather file.
+% ROUNDTRIP Test utility for round tripping a MATLAB
+% table to a Feather V1 file.
Review Comment:
round tripping a MATLAB table to ***and from*** a Feather V1 File?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney commented on a diff in pull request #37190: GH-37188: [MATLAB] Move `test/util/featherRoundTrip.m` into a packaged test utility function
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #37190:
URL: https://github.com/apache/arrow/pull/37190#discussion_r1296073622
##########
matlab/src/matlab/+arrow/+internal/+test/+io/+feather/roundtrip.m:
##########
@@ -1,6 +1,5 @@
-function tableOut = featherRoundTrip(filename, tableIn)
-% FEATHERROUNDTRIP Helper function for round tripping a table
-% to a Feather file.
+% ROUNDTRIP Test utility for round tripping a MATLAB
+% table to a Feather V1 file.
Review Comment:
Thanks - I modified the wording. I think it is a bit more descriptive now.
##########
matlab/src/matlab/+arrow/+internal/+test/+io/+feather/roundtrip.m:
##########
@@ -1,6 +1,5 @@
-function tableOut = featherRoundTrip(filename, tableIn)
-% FEATHERROUNDTRIP Helper function for round tripping a table
-% to a Feather file.
+% ROUNDTRIP Test utility for round tripping a MATLAB
+% table to a Feather V1 file.
Review Comment:
Marking this as resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37190: GH-37188: [MATLAB] Move `test/util/featherRoundTrip.m` into a packaged test utility function
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37190:
URL: https://github.com/apache/arrow/pull/37190#issuecomment-1682700970
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit d330d1b36c87ea43bfd16e1bc43a4ff9876abb4b.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/15987119067) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney merged pull request #37190: GH-37188: [MATLAB] Move `test/util/featherRoundTrip.m` into a packaged test utility function
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney merged PR #37190:
URL: https://github.com/apache/arrow/pull/37190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sgilmore10 commented on a diff in pull request #37190: GH-37188: [MATLAB] Move `test/util/featherRoundTrip.m` into a packaged test utility function
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #37190:
URL: https://github.com/apache/arrow/pull/37190#discussion_r1296068092
##########
matlab/src/matlab/+arrow/+internal/+test/+io/+feather/roundtrip.m:
##########
@@ -1,6 +1,5 @@
-function tableOut = featherRoundTrip(filename, tableIn)
-% FEATHERROUNDTRIP Helper function for round tripping a table
-% to a Feather file.
+% ROUNDTRIP Test utility for round tripping a MATLAB
+% table to a Feather V1 file.
Review Comment:
to/from
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney commented on pull request #37190: GH-37188: [MATLAB] Move `test/util/featherRoundTrip.m` into a packaged test utility function
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #37190:
URL: https://github.com/apache/arrow/pull/37190#issuecomment-1680559046
> It looks like the `ccache` step failed on macOS due to a timeout limit being reached. I've restarted the failing job.
>
> This should be ready to merge in as soon as the CI checks pass.
Sorry, I accidentally added this comment to the wrong pull request. I meant to add this comment to #37191, but it looks like it has already been merged by kou.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney commented on pull request #37190: GH-37188: Move `test/util/featherRoundTrip.m` into a packaged test utility function
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #37190:
URL: https://github.com/apache/arrow/pull/37190#issuecomment-1679610967
It looks like the `ccache` step failed on macOS due to a timeout limit being reached. I've restarted the failing job.
This should be ready to merge in as soon as the CI checks pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney commented on pull request #37190: GH-37188: [MATLAB] Move `test/util/featherRoundTrip.m` into a packaged test utility function
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #37190:
URL: https://github.com/apache/arrow/pull/37190#issuecomment-1680847926
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org