You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/02/10 16:49:22 UTC
Review Request 30832: Views: ContextClassLoader can't load resources
for JARs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30832/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-9551
https://issues.apache.org/jira/browse/AMBARI-9551
Repository: ambari
Description
-------
Thread context class loader is not set to the view class loader when accessing a view resource through the REST APIs. For example ...
/api/v1/views/CALCULATOR/versions/1.0.0/instances/INSTANCE_1/resources/calculator
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java da15a66
ambari-server/src/main/java/org/apache/ambari/server/controller/FailsafeHandlerList.java fa1e6b1
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariHandlerListTest.java 7171e88
Diff: https://reviews.apache.org/r/30832/diff/
Testing
-------
Manual tests.
New unit test added.
All existing unit tests pass.
Thanks,
Tom Beerbower
Re: Review Request 30832: Views: ContextClassLoader can't load
resources for JARs
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30832/#review71852
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 10, 2015, 2:42 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30832/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 2:42 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9551
> https://issues.apache.org/jira/browse/AMBARI-9551
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Thread context class loader is not set to the view class loader when accessing a view resource through the REST APIs. For example ...
> /api/v1/views/CALCULATOR/versions/1.0.0/instances/INSTANCE_1/resources/calculator
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java da15a66
> ambari-server/src/main/java/org/apache/ambari/server/controller/FailsafeHandlerList.java fa1e6b1
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariHandlerListTest.java 7171e88
>
> Diff: https://reviews.apache.org/r/30832/diff/
>
>
> Testing
> -------
>
> Manual tests.
> New unit test added.
> All existing unit tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30832: Views: ContextClassLoader can't load
resources for JARs
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30832/#review71845
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Feb. 10, 2015, 2:42 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30832/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 2:42 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9551
> https://issues.apache.org/jira/browse/AMBARI-9551
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Thread context class loader is not set to the view class loader when accessing a view resource through the REST APIs. For example ...
> /api/v1/views/CALCULATOR/versions/1.0.0/instances/INSTANCE_1/resources/calculator
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java da15a66
> ambari-server/src/main/java/org/apache/ambari/server/controller/FailsafeHandlerList.java fa1e6b1
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariHandlerListTest.java 7171e88
>
> Diff: https://reviews.apache.org/r/30832/diff/
>
>
> Testing
> -------
>
> Manual tests.
> New unit test added.
> All existing unit tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30832: Views: ContextClassLoader can't load
resources for JARs
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30832/
-----------------------------------------------------------
(Updated Feb. 10, 2015, 7:42 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
updated diff
Bugs: AMBARI-9551
https://issues.apache.org/jira/browse/AMBARI-9551
Repository: ambari
Description
-------
Thread context class loader is not set to the view class loader when accessing a view resource through the REST APIs. For example ...
/api/v1/views/CALCULATOR/versions/1.0.0/instances/INSTANCE_1/resources/calculator
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java da15a66
ambari-server/src/main/java/org/apache/ambari/server/controller/FailsafeHandlerList.java fa1e6b1
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariHandlerListTest.java 7171e88
Diff: https://reviews.apache.org/r/30832/diff/
Testing
-------
Manual tests.
New unit test added.
All existing unit tests pass.
Thanks,
Tom Beerbower
Re: Review Request 30832: Views: ContextClassLoader can't load
resources for JARs
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On Feb. 10, 2015, 5:30 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java, line 154
> > <https://reviews.apache.org/r/30832/diff/1/?file=860026#file860026line154>
> >
> > Not seeing the rest of the code, the viewEntity's classloader looks like it's null by default? Does a viewEntity get one guaranteed? May want a null check.
The view's class loader gets setup when the view is deployed so it should never be null. A null check with some logging is probably a good idea since we would want to be aware of this condition for debugging, I think.
Thanks!
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30832/#review71805
-----------------------------------------------------------
On Feb. 10, 2015, 3:49 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30832/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 3:49 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9551
> https://issues.apache.org/jira/browse/AMBARI-9551
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Thread context class loader is not set to the view class loader when accessing a view resource through the REST APIs. For example ...
> /api/v1/views/CALCULATOR/versions/1.0.0/instances/INSTANCE_1/resources/calculator
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java da15a66
> ambari-server/src/main/java/org/apache/ambari/server/controller/FailsafeHandlerList.java fa1e6b1
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariHandlerListTest.java 7171e88
>
> Diff: https://reviews.apache.org/r/30832/diff/
>
>
> Testing
> -------
>
> Manual tests.
> New unit test added.
> All existing unit tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30832: Views: ContextClassLoader can't load
resources for JARs
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30832/#review71805
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java
<https://reviews.apache.org/r/30832/#comment117665>
Not seeing the rest of the code, the viewEntity's classloader looks like it's null by default? Does a viewEntity get one guaranteed? May want a null check.
- Nate Cole
On Feb. 10, 2015, 10:49 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30832/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 10:49 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9551
> https://issues.apache.org/jira/browse/AMBARI-9551
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Thread context class loader is not set to the view class loader when accessing a view resource through the REST APIs. For example ...
> /api/v1/views/CALCULATOR/versions/1.0.0/instances/INSTANCE_1/resources/calculator
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java da15a66
> ambari-server/src/main/java/org/apache/ambari/server/controller/FailsafeHandlerList.java fa1e6b1
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariHandlerListTest.java 7171e88
>
> Diff: https://reviews.apache.org/r/30832/diff/
>
>
> Testing
> -------
>
> Manual tests.
> New unit test added.
> All existing unit tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>