[GitHub] [helix] rabashizade commented on a diff in pull request #2090: Add TTL and Container modes to sync create API in ZkClient and ZkConnection

[GitBox <gi...@apache.org>]

rabashizade commented on code in PR #2090:
URL: https://github.com/apache/helix/pull/2090#discussion_r870836582


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -728,8 +1031,14 @@ private String create(final String path, final Object dataObject, final List<ACL
       final byte[] dataBytes = dataObject == null ? null : serialize(dataObject, path);
       checkDataSizeLimit(path, dataBytes);
 
-      final String actualPath = retryUntilConnected(
-          () -> getExpectedZookeeper(expectedSessionId).create(path, dataBytes, acl, mode));
+      final String actualPath;
+      if (mode.isTTL()) {
+        actualPath = retryUntilConnected(() -> getExpectedZookeeper(expectedSessionId)
+            .create(path, dataBytes, acl, mode, new Stat(), ttl));

Review Comment:
   Yes, that makes sense. I changed it to `null`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org