You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/08/05 10:49:39 UTC
[GitHub] [couchdb-helm] willholley opened a new pull request #38: Fix chart rendering when annotations specified
willholley opened a new pull request #38:
URL: https://github.com/apache/couchdb-helm/pull/38
<!--
Thank you for contributing to couchdb-helm. Before you submit this PR we'd like to
make sure you are aware of the chart technical requirements and best practices:
* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
* https://github.com/helm/helm/tree/master/docs/chart_best_practices
For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:
* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md
Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.
Please make sure you test your changes before you push them.
-->
#### What this PR does / why we need it:
Commit 70b2777edd3b792c30dd025097ee598b64a45efa caused user-provided
annotations to break the `checksum` StatefulSet annotations. The
`{{ with .Values.annotations }}` instruction changes the scope
under which the checksum is calculated when user annotations are present.
This removes the `{{ with .Values.annotations }}` and instead just
writes out the user-provided annotations directly.
I've also added a user-provided annotation to the `values.yaml` used
in the smoke test to verify the fix.
#### Which issue this PR fixes
- fixes #37
#### Special notes for your reviewer:
#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.
- [x] Chart Version bumped
- [x] e2e tests pass
- [x] Variables are documented in the README.md
- [x] Chart tgz added to /docs and index updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] kocolosk merged pull request #38: Fix chart rendering when annotations specified
Posted by GitBox <gi...@apache.org>.
kocolosk merged pull request #38:
URL: https://github.com/apache/couchdb-helm/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] flyte commented on pull request #38: Fix chart rendering when annotations specified
Posted by GitBox <gi...@apache.org>.
flyte commented on pull request #38:
URL: https://github.com/apache/couchdb-helm/pull/38#issuecomment-954056819
I do apologise for the bump, but it would be rather helpful to be able to use these annotations if somebody has some time to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] willholley commented on pull request #38: Fix chart rendering when annotations specified
Posted by GitBox <gi...@apache.org>.
willholley commented on pull request #38:
URL: https://github.com/apache/couchdb-helm/pull/38#issuecomment-683791645
@kocolosk are you able to review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] kocolosk merged pull request #38: Fix chart rendering when annotations specified
Posted by GitBox <gi...@apache.org>.
kocolosk merged pull request #38:
URL: https://github.com/apache/couchdb-helm/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] N8th8n8el commented on pull request #38: Fix chart rendering when annotations specified
Posted by GitBox <gi...@apache.org>.
N8th8n8el commented on pull request #38:
URL: https://github.com/apache/couchdb-helm/pull/38#issuecomment-884193079
Status?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org