You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/10/05 21:18:13 UTC
[native-toolchain-CR] IMPALA-12436: Add architecture to S3 file names
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20539
Change subject: IMPALA-12436: Add architecture to S3 file names
......................................................................
IMPALA-12436: Add architecture to S3 file names
Adds the architecture (x86_64 or aaarch64) to the file names for
packages uploaded to S3 to distinguish between architectures.
Change-Id: I78a676369a02607d57443bc74115fb2a10230226
---
M functions.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/39/20539/1
--
To view, visit http://gerrit.cloudera.org:8080/20539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78a676369a02607d57443bc74115fb2a10230226
Gerrit-Change-Number: 20539
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-12354: Add architecture to S3 file names
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20539 )
Change subject: IMPALA-12354: Add architecture to S3 file names
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20539/2/functions.sh
File functions.sh:
http://gerrit.cloudera.org:8080/#/c/20539/2/functions.sh@424
PS2, Line 424: -${ARCH}
> Could this be made conditional, and just add it for non-x86 architectures?
It could be conditional. However, I like the symmetry, and this is a pattern for packaging that's used more broadly. As you said, the change is isolated to this repo and builds that use a particular TOOLCHAIN_BUILD_ID, so it would be fairly easy to carry to relevant branches.
--
To view, visit http://gerrit.cloudera.org:8080/20539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78a676369a02607d57443bc74115fb2a10230226
Gerrit-Change-Number: 20539
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2023 17:01:21 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-12354: Add architecture to S3 file names
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20539 )
Change subject: IMPALA-12354: Add architecture to S3 file names
......................................................................
Patch Set 3:
Going to hold off on merging this until the Impala change is also approved, since it requires changes there to adapt.
--
To view, visit http://gerrit.cloudera.org:8080/20539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78a676369a02607d57443bc74115fb2a10230226
Gerrit-Change-Number: 20539
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Oct 2023 20:14:19 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12354: Add architecture to S3 file names
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20539 )
Change subject: IMPALA-12354: Add architecture to S3 file names
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20539/2/functions.sh
File functions.sh:
http://gerrit.cloudera.org:8080/#/c/20539/2/functions.sh@424
PS2, Line 424: -${ARCH}
Could this be made conditional, and just add it for non-x86 architectures?
IMO this would make life easier for downstream forks/branches that don't care about non-x86 CPUs (targeting mostly on-prem datacenters) by just not changing the status quo for them. Changing the toolchain naming convention would require a matching change in impala/bin/bootstrap_toolchain.py when the first toolchain update with the new package names hits such a branch.
OTOH the required change would be small, and it could be packaged into the same commit that updates TOOLCHAIN_BUILD_ID, which is a required commit for a toolchain change anyway, so this is far from being a strong opinion.
Curious for your thoughts on this.
--
To view, visit http://gerrit.cloudera.org:8080/20539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78a676369a02607d57443bc74115fb2a10230226
Gerrit-Change-Number: 20539
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2023 14:56:41 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-12354: Add architecture to S3 file names
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20539 )
Change subject: IMPALA-12354: Add architecture to S3 file names
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/20539/2/functions.sh
File functions.sh:
http://gerrit.cloudera.org:8080/#/c/20539/2/functions.sh@a424
PS2, Line 424:
Why was this line removed?
This is the only indication of the upload ion the console log when output is not verbose
http://gerrit.cloudera.org:8080/#/c/20539/2/functions.sh@424
PS2, Line 424: -${ARCH}
> It could be conditional. However, I like the symmetry, and this is a patter
OK, I'm convinced.
--
To view, visit http://gerrit.cloudera.org:8080/20539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78a676369a02607d57443bc74115fb2a10230226
Gerrit-Change-Number: 20539
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2023 20:03:17 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-12354: Add architecture to S3 file names
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20539 )
Change subject: IMPALA-12354: Add architecture to S3 file names
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/20539/2/functions.sh
File functions.sh:
http://gerrit.cloudera.org:8080/#/c/20539/2/functions.sh@a424
PS2, Line 424:
> Why was this line removed?
Oh oops, that was a mistake.
http://gerrit.cloudera.org:8080/#/c/20539/2/functions.sh@424
PS2, Line 424: -${ARCH}
> OK, I'm convinced.
Ack
--
To view, visit http://gerrit.cloudera.org:8080/20539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78a676369a02607d57443bc74115fb2a10230226
Gerrit-Change-Number: 20539
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2023 21:07:06 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-12354: Add architecture to S3 file names
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20539 )
Change subject: IMPALA-12354: Add architecture to S3 file names
......................................................................
IMPALA-12354: Add architecture to S3 file names
Adds the architecture (x86_64 or aaarch64) to the file names for
packages uploaded to S3 to distinguish between architectures.
Change-Id: I78a676369a02607d57443bc74115fb2a10230226
---
M functions.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/39/20539/2
--
To view, visit http://gerrit.cloudera.org:8080/20539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78a676369a02607d57443bc74115fb2a10230226
Gerrit-Change-Number: 20539
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-12354: Add architecture to S3 file names
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20539
to look at the new patch set (#3).
Change subject: IMPALA-12354: Add architecture to S3 file names
......................................................................
IMPALA-12354: Add architecture to S3 file names
Adds the architecture (x86_64 or aaarch64) to the file names for
packages uploaded to S3 to distinguish between architectures.
Change-Id: I78a676369a02607d57443bc74115fb2a10230226
---
M functions.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/39/20539/3
--
To view, visit http://gerrit.cloudera.org:8080/20539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78a676369a02607d57443bc74115fb2a10230226
Gerrit-Change-Number: 20539
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-12354: Add architecture to S3 file names
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20539 )
Change subject: IMPALA-12354: Add architecture to S3 file names
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78a676369a02607d57443bc74115fb2a10230226
Gerrit-Change-Number: 20539
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2023 22:25:23 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12354: Add architecture to S3 file names
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20539 )
Change subject: IMPALA-12354: Add architecture to S3 file names
......................................................................
IMPALA-12354: Add architecture to S3 file names
Adds the architecture (x86_64 or aaarch64) to the file names for
packages uploaded to S3 to distinguish between architectures.
Change-Id: I78a676369a02607d57443bc74115fb2a10230226
Reviewed-on: http://gerrit.cloudera.org:8080/20539
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M functions.sh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Laszlo Gaal: Looks good to me, approved
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I78a676369a02607d57443bc74115fb2a10230226
Gerrit-Change-Number: 20539
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-12354: Add architecture to S3 file names
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20539 )
Change subject: IMPALA-12354: Add architecture to S3 file names
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78a676369a02607d57443bc74115fb2a10230226
Gerrit-Change-Number: 20539
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Oct 2023 21:01:49 +0000
Gerrit-HasComments: No