You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Francesco Chicchiriccò <no...@github.com> on 2015/03/31 12:19:44 UTC
[jclouds-labs] [JCLOUDS-846] Completing missing mock tests (#159)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/159
-- Commit Summary --
* [JCLOUDS-846] StorageAccountApi completed + mock and live tests
* [JCLOUDS-846] SubscriptionApiMockTest
-- File Changes --
A azurecompute/src/main/java/org/jclouds/azurecompute/binders/CreateStorageServiceParamsToXML.java (76)
R azurecompute/src/main/java/org/jclouds/azurecompute/binders/StorageServiceKeyTypeToXML.java (28)
A azurecompute/src/main/java/org/jclouds/azurecompute/binders/UpdateStorageServiceParamsToXML.java (86)
M azurecompute/src/main/java/org/jclouds/azurecompute/compute/strategy/GetOrCreateStorageServiceAndVirtualNetworkThenCreateNodes.java (11)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/CreateStorageServiceParams.java (161)
M azurecompute/src/main/java/org/jclouds/azurecompute/domain/StorageService.java (195)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/StorageServiceKeys.java (54)
D azurecompute/src/main/java/org/jclouds/azurecompute/domain/StorageServiceParams.java (104)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/UpdateStorageServiceParams.java (190)
M azurecompute/src/main/java/org/jclouds/azurecompute/features/StorageAccountApi.java (83)
M azurecompute/src/main/java/org/jclouds/azurecompute/features/SubscriptionApi.java (7)
A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ExtendedPropertiesHandler.java (55)
M azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListStorageServicesHandler.java (12)
M azurecompute/src/main/java/org/jclouds/azurecompute/xml/StorageServiceHandler.java (61)
A azurecompute/src/main/java/org/jclouds/azurecompute/xml/StorageServiceKeysHandler.java (70)
M azurecompute/src/main/java/org/jclouds/azurecompute/xml/StorageServicePropertiesHandler.java (140)
A azurecompute/src/test/java/org/jclouds/azurecompute/features/StorageAccountApiLiveTest.java (118)
A azurecompute/src/test/java/org/jclouds/azurecompute/features/StorageAccountApiMockTest.java (228)
A azurecompute/src/test/java/org/jclouds/azurecompute/features/SubscriptionApiMockTest.java (43)
M azurecompute/src/test/java/org/jclouds/azurecompute/internal/BaseAzureComputeApiLiveTest.java (18)
A azurecompute/src/test/java/org/jclouds/azurecompute/xml/ListRoleSizesHandlerTest.java (64)
A azurecompute/src/test/java/org/jclouds/azurecompute/xml/ListStorageServiceHandlerTest.java (79)
A azurecompute/src/test/resources/createstorageserviceparams.xml (1)
A azurecompute/src/test/resources/isavailablestorageservice.xml (1)
M azurecompute/src/test/resources/rolesizes.xml (276)
A azurecompute/src/test/resources/storageaccountkeys.xml (1)
A azurecompute/src/test/resources/storageaccountregeneratekeys.xml (1)
A azurecompute/src/test/resources/storageservices.xml (34)
A azurecompute/src/test/resources/updatestorageserviceparams.xml (1)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/159.patch
https://github.com/jclouds/jclouds-labs/pull/159.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/159
Re: [jclouds-labs] [JCLOUDS-846] Completing missing mock tests (#159)
Posted by Ignasi Barrera <no...@github.com>.
Squashed and pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/aac95744) and [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/cb5df375). Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/159#issuecomment-88863602
Re: [jclouds-labs] [JCLOUDS-846] Completing missing mock tests (#159)
Posted by Ignasi Barrera <no...@github.com>.
Closed #159.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/159#event-271590046
Re: [jclouds-labs] [JCLOUDS-846] Completing missing mock tests (#159)
Posted by Ignasi Barrera <no...@github.com>.
> public abstract StorageServiceProperties storageServiceProperties();
>
> + /**
> + * Specifies the name and value of an extended property that was added to the storage account.
> + */
> + public abstract Map<String, String> extendedProperties();
This seems to be nullable?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/159/files#r27641762
Re: [jclouds-labs] [JCLOUDS-846] Completing missing mock tests (#159)
Posted by Ignasi Barrera <no...@github.com>.
> - public abstract String accountType();
> + /**
> + * A name for the hosted service that is base-64 encoded. The name can be up to 100 characters in length. The name
> + * can be used identify the storage account for your tracking purposes
> + */
> + public abstract String label();
> +
> + /**
> + * The status of the storage account.
> + */
> + public abstract Status status();
> +
> + /**
> + * Specifies the endpoints of the storage account.
> + */
> + public abstract List<URL> endpoints();
This seems to be nullable
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/159/files#r27641776
Re: [jclouds-labs] [JCLOUDS-846] Completing missing mock tests (#159)
Posted by Ignasi Barrera <no...@github.com>.
> +public class SubscriptionApiMockTest extends BaseAzureComputeApiMockTest {
> +
> + public void testList() throws Exception {
> + final MockWebServer server = mockAzureManagementServer();
> + server.enqueue(xmlResponse("/rolesizes.xml"));
> +
> + try {
> + final SubscriptionApi api = api(server.getUrl("/")).getSubscriptionApi();
> +
> + assertEquals(api.listRoleSizes(), ListRoleSizesHandlerTest.expected());
> +
> + assertSent(server, "GET", "/rolesizes");
> + } finally {
> + server.shutdown();
> + }
> + }
Add also a test that exercises the fallback.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/159/files#r27641886
Re: [jclouds-labs] [JCLOUDS-846] Completing missing mock tests (#159)
Posted by Francesco Chicchiriccò <no...@github.com>.
@nacx Comments addressed and code rebased.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/159#issuecomment-88856950