You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/24 01:34:45 UTC

[GitHub] [airflow] jhtimmins commented on pull request #14388: Pass region name to superclass of AWSGlueJobHook

jhtimmins commented on pull request #14388:
URL: https://github.com/apache/airflow/pull/14388#issuecomment-784664708


   This fix works, but now you're setting `self.region_name` in both the child and the parent. Probably best to remove `self.region_name = region_name` from the child.
   
   Could you also add a test for this? Just a simple test in https://github.com/apache/airflow/blob/master/tests/providers/amazon/aws/hooks/test_glue.py that instantiates the class and makes sure that `glue.region_name == <expected_value>` should be enough.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org