You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2024/02/06 14:42:33 UTC
[PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
raulcd opened a new pull request, #39960:
URL: https://github.com/apache/arrow/pull/39960
### Rationale for this change
The current verification guide is obsolete and should not be on the wiki.
### What changes are included in this PR?
Adding a new page with the release verification information.
### Are these changes tested?
The documentation will be generated and will use the preview-docs job.
### Are there any user-facing changes?
Yes but not relevant in terms of code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39960:
URL: https://github.com/apache/arrow/pull/39960#issuecomment-1929904239
:warning: GitHub issue #31735 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1494280642
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
```
raul@raul-MacBook-Pro % ls -l /Library/Developer/CommandLineTools/SDKs/
total 0
drwxr-xr-x 7 root wheel 224 Nov 19 2021 MacOSX12.1.sdk
drwxr-xr-x 3 root wheel 96 Feb 10 14:11 MacOSX12.3.sdk
raul@raul-MacBook-Pro % sw_vers -productVersion
14.3.1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1484362946
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,156 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu 22.04
+------------
+
+You might have to install some packages on your system. The following
+packages were required to perform a source verification on a clean
+Ubuntu 22.04 from an AWS instance:
+
+.. code-block::
+
+ sudo apt update
+
+ # Install miscellanious required packages
+ sudo apt install \
+ build-essential \
+ clang \
+ cmake \
+ libsqlite3-dev \
+ libssh-dev \
+ libyaml-dev \
+ llvm-dev \
+ python3-dev \
+ python3.10-venv
+
+ # Install ruby
Review Comment:
> FYI: We can use https://github.com/apache/arrow/blob/main/dev/release/setup-ubuntu.sh for this section.
You mean telling people to use `setup-ubuntu.sh` or as a base for this? Currently with the last commit I had a source verification successful and I plan to modify the documentation later a little to document only source verification to try and make the process simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1484839558
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,156 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu 22.04
+------------
+
+You might have to install some packages on your system. The following
+packages were required to perform a source verification on a clean
+Ubuntu 22.04 from an AWS instance:
+
+.. code-block::
+
+ sudo apt update
+
+ # Install miscellanious required packages
+ sudo apt install \
+ build-essential \
+ clang \
+ cmake \
+ libsqlite3-dev \
+ libssh-dev \
+ libyaml-dev \
+ llvm-dev \
+ python3-dev \
+ python3.10-venv
+
+ # Install ruby
Review Comment:
The former: telling people to use `setup-ubuntu.sh`
If we use `setup-ubuntu.sh` in documentation too, we don't need to update both of `setup-ubuntu.sh` and documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1483397377
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,156 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu 22.04
+------------
+
+You might have to install some packages on your system. The following
+packages were required to perform a source verification on a clean
+Ubuntu 22.04 from an AWS instance:
+
+.. code-block::
+
+ sudo apt update
+
+ # Install miscellanious required packages
+ sudo apt install \
+ build-essential \
+ clang \
+ cmake \
+ libsqlite3-dev \
+ libssh-dev \
+ libyaml-dev \
+ llvm-dev \
+ python3-dev \
+ python3.10-venv
+
+ # Install ruby
Review Comment:
@kou I am trying to run a source verification from scratch on a new Ubuntu to take the notes on what is needed, these are the things that I have installed but I am currently having an issue on the `C GLib` source verification, any idea?
```
ubuntu@ip:~/arrow/dev/release$ tail -100f /tmp/arrow-15.0.0.XCn9G/c-glib-build/meson-logs/meson-log.txt
- "--no-warn-unused-cli"
- "--trace-redirect=cmake_trace.txt"
- "-DCMAKE_TOOLCHAIN_FILE=/tmp/arrow-15.0.0.XCn9G/c-glib-build/meson-private/cmake_gobject-introspection-1.0/CMakeMesonToolchainFile.cmake"
- "."
- "-DCMAKE_PREFIX_PATH=/tmp/arrow-15.0.0.XCn9G/install"
-- Module search paths: ['/', '/opt', '/tmp/arrow-15.0.0.XCn9G/install', '/usr', '/usr/local']
-- CMake root: /usr/share/cmake-3.22
-- CMake architectures: ['x86_64-linux-gnu']
-- CMake lib search paths: ['lib', 'lib32', 'lib64', 'libx32', 'share', '', 'lib/x86_64-linux-gnu']
Preliminary CMake check failed. Aborting.
Run-time dependency gobject-introspection-1.0 found: NO (tried pkgconfig and cmake)
Dependency lookup for arrow with method 'pkgconfig' failed: Pkg-config for machine host machine not found. Giving up.
CMake binary for host machine is cached.
Determining dependency 'arrow' with CMake executable '/usr/bin/cmake'
CMake Toolchain: Calling CMake once to generate the compiler state
Calling CMake (['/usr/bin/cmake']) in /tmp/arrow-15.0.0.XCn9G/c-glib-build/meson-private/__CMake_compiler_info__ with:
- "--trace-expand"
- "--trace-format=json-v1"
- "--no-warn-unused-cli"
- "--trace-redirect=cmake_trace.txt"
- "-G"
- "Ninja"
- "-DCMAKE_TOOLCHAIN_FILE=/tmp/arrow-15.0.0.XCn9G/c-glib-build/meson-private/__CMake_compiler_info__/CMakeMesonTempToolchainFile.cmake"
- "."
- "-DCMAKE_PREFIX_PATH=/tmp/arrow-15.0.0.XCn9G/install"
WARNING: CMake Toolchain: Failed to determine CMake compilers state
Try CMake generator: auto
Calling CMake (['/usr/bin/cmake']) in /tmp/arrow-15.0.0.XCn9G/c-glib-build/meson-private/cmake_arrow with:
- "-DNAME=arrow"
- "-DARCHS=x86_64-linux-gnu"
- "-DVERSION="
- "-DCOMPS="
- "-DSTATIC=False"
- "--trace-expand"
- "--trace-format=json-v1"
- "--no-warn-unused-cli"
- "--trace-redirect=cmake_trace.txt"
- "-DCMAKE_TOOLCHAIN_FILE=/tmp/arrow-15.0.0.XCn9G/c-glib-build/meson-private/cmake_arrow/CMakeMesonToolchainFile.cmake"
- "."
- "-DCMAKE_PREFIX_PATH=/tmp/arrow-15.0.0.XCn9G/install"
WARNING: Could not find and exact match for the CMake dependency arrow.
However, Meson found the following partial matches:
['Arrow::arrow_shared', 'Arrow::arrow_static', 'Arrow::arrow_bundled_dependencies']
Using imported is recommended, since this approach is less error prone
and better supported by Meson. Consider explicitly specifying one of
these in the dependency call with:
dependency('arrow', modules: ['arrow::<name>', ...])
Meson will now continue to use the old-style arrow_LIBRARIES CMake
variables to extract the dependency information since no explicit
target is currently specified.
More info for the partial match targets:
CMake TARGET:
-- name: Arrow::arrow_shared
-- type: SHARED
-- imported: True
-- properties: {
'INTERFACE_COMPILE_FEATURES': ['cxx_std_17']
'INTERFACE_INCLUDE_DIRECTORIES': ['/tmp/arrow-15.0.0.XCn9G/install/include']
'IMPORTED_CONFIGURATIONS': ['RELEASE']
'IMPORTED_LOCATION_RELEASE': ['/tmp/arrow-15.0.0.XCn9G/install/lib/libarrow.so.1500.0.0']
'IMPORTED_SONAME_RELEASE': ['libarrow.so.1500']
}
-- tline: CMake TRACE: /tmp/arrow-15.0.0.XCn9G/install/lib/cmake/Arrow/ArrowTargets.cmake:54 add_library(['Arrow::arrow_shared', 'SHARED', 'IMPORTED'])
CMake TARGET:
-- name: Arrow::arrow_static
-- type: STATIC
-- imported: True
-- properties: {
'INTERFACE_COMPILE_FEATURES': ['cxx_std_17']
'INTERFACE_INCLUDE_DIRECTORIES': ['/tmp/arrow-15.0.0.XCn9G/install/include']
'INTERFACE_LINK_LIBRARIES': ['Arrow::arrow_bundled_dependencies', 'OpenSSL::Crypto', 'OpenSSL::SSL', 'ZLIB::ZLIB', 'dl', 'Threads::Threads', 'rt']
'IMPORTED_CONFIGURATIONS': ['RELEASE']
'IMPORTED_LINK_INTERFACE_LANGUAGES_RELEASE': ['C', 'CXX']
'IMPORTED_LOCATION_RELEASE': ['/tmp/arrow-15.0.0.XCn9G/install/lib/libarrow.a']
}
-- tline: CMake TRACE: /tmp/arrow-15.0.0.XCn9G/install/lib/cmake/Arrow/ArrowTargets.cmake:62 add_library(['Arrow::arrow_static', 'STATIC', 'IMPORTED'])
CMake TARGET:
-- name: Arrow::arrow_bundled_dependencies
-- type: STATIC
-- imported: True
-- properties: {
'IMPORTED_CONFIGURATIONS': ['RELEASE']
'IMPORTED_LOCATION_RELEASE': ['/tmp/arrow-15.0.0.XCn9G/install/lib/libarrow_bundled_dependencies.a']
}
-- tline: CMake TRACE: /tmp/arrow-15.0.0.XCn9G/install/lib/cmake/Arrow/ArrowConfig.cmake:128 add_library(['Arrow::arrow_bundled_dependencies', 'STATIC', 'IMPORTED'])
Dependency lookup for arrow with method 'cmake' failed: Dependency arrow not found: CMake: failed to guess a CMake target for arrow.
Try to explicitly specify one or more targets with the "modules" property.
Valid targets are:
['Threads::Threads', 'OpenSSL::Crypto', 'OpenSSL::SSL', 'ZLIB::ZLIB', 'Arrow::arrow_shared', 'Arrow::arrow_static', 'Arrow::arrow_bundled_dependencies', 'arrow_shared', 'arrow_static']
Run-time dependency arrow found: NO
meson.build:80:10: ERROR: Dependency lookup for arrow with method 'pkgconfig' failed: Pkg-config for machine host machine not found. Giving up.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1483781347
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,156 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu 22.04
+------------
+
+You might have to install some packages on your system. The following
+packages were required to perform a source verification on a clean
+Ubuntu 22.04 from an AWS instance:
+
+.. code-block::
+
+ sudo apt update
+
+ # Install miscellanious required packages
+ sudo apt install \
+ build-essential \
+ clang \
+ cmake \
+ libsqlite3-dev \
+ libssh-dev \
+ libyaml-dev \
+ llvm-dev \
+ python3-dev \
+ python3.10-venv
+
+ # Install ruby
Review Comment:
Yes. gobject-introspection is missing. We can install it by `libgirepository1.0-dev`.
FYI: We can use https://github.com/apache/arrow/blob/main/dev/release/setup-ubuntu.sh for this section.
##########
docs/source/developers/release.rst:
##########
@@ -200,6 +200,8 @@ Verify the Release
# on dev@arrow.apache.org. To regenerate the email template use
SOURCE_DEFAULT=0 SOURCE_VOTE=1 dev/release/02-source.sh <version> <rc-number>
+See more about the verification process on :ref:`Release verification <release_verification>`
Review Comment:
How about simplifying this?
```suggestion
See :ref:`release_verification` for details.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39960:
URL: https://github.com/apache/arrow/pull/39960#issuecomment-1945817151
Revision: e52140b4c74faa6527f0fde248a9fad9b829d661
Submitted crossbow builds: [ursacomputing/crossbow @ actions-99361aa29b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-99361aa29b)
|Task|Status|
|----|------|
|preview-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/7914644754/job/21604797300)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #39960:
URL: https://github.com/apache/arrow/pull/39960#issuecomment-1945808553
@kou @assignUser should we add Windows instructions? I've tested source verification from scratch on Linux and macOS and added the required configuration.
Maybe we can merge and add Windows on a different ticket as it will take me some time to be able to do. I also want to re-review our verification process on another ticket as per the feedback received on this ML thread: https://lists.apache.org/thread/ogp9dthp124oq0fmvlyzvjorjsyom03v
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1499000304
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
Done and created issue to follow up:
* https://github.com/apache/arrow/issues/40195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1499978017
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1493007196
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
Thanks!
Could you show the output of `pkg-config --cflags gobject-introspection-1.0` on the environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #39960:
URL: https://github.com/apache/arrow/pull/39960#issuecomment-1945809104
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1497229658
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
@kou as per the PR, if you want I can remove the `brew install libffi` and we can keep investigating further the issue on a different GH issue so we can merge this initial documentation, are you ok with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1491617252
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
Wow! Yes, please share the logs!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39960:
URL: https://github.com/apache/arrow/pull/39960#issuecomment-1943493028
Revision: e9f5cca3643ac144047dd75b2a96adf5584123b9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5ae5bfaf5c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5ae5bfaf5c)
|Task|Status|
|----|------|
|preview-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/7899937068/job/21560397920)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #39960:
URL: https://github.com/apache/arrow/pull/39960#issuecomment-1943489437
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1497226068
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
I did the link but it is still failing with the same error:
```
/opt/homebrew/Cellar/gobject-introspection/1.78.1/include/gobject-introspection-1.0/girffi.h:25:10: fatal error: 'ffi.h' file not found
#include <ffi.h>
^~~~~~~
1 warning and 1 error generated.
make: *** [rb-gi-arg-info.o] Error 1
make failed, exit code 2
Gem files will remain installed in
/private/var/folders/rr/t_15q7dx4_lf1nv0btypffcw0000gn/T/arrow-15.0.0.XXXXX.MBSLuBRsHl/apache-arrow-15.0.0/c_glib/vendor/bundle/ruby/3.3.0/gems/gobject-introspection-4.2.0 for inspection.
Results logged to
/private/var/folders/rr/t_15q7dx4_lf1nv0btypffcw0000gn/T/arrow-15.0.0.XXXXX.MBSLuBRsHl/apache-arrow-15.0.0/c_glib/vendor/bundle/ruby/3.3.0/extensions/arm64-darwin-23/3.3.0/gobject-introspection-4.2.0/gem_make.out
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:125:in `run'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:51:in `block in make'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:43:in `each'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:43:in `make'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/ext_conf_builder.rb:42:in `build'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:193:in `build_extension'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:227:in `block in build_extensions'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:224:in `each'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:224:in `build_extensions'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/installer.rb:852:in `build_extensions'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/rubygems_gem_installer.rb:76:in `build_extensions'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/rubygems_gem_installer.rb:28:in `install'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/source/rubygems.rb:205:in `install'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/installer/gem_installer.rb:54:in `install'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/installer/gem_installer.rb:16:in `install_from_spec'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/installer/parallel_installer.rb:132:in `do_install'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/installer/parallel_installer.rb:123:in `block in worker_pool'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/worker.rb:62:in `apply_func'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/worker.rb:57:in `block in process_queue'
<internal:kernel>:187:in `loop'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/worker.rb:54:in `process_queue'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/worker.rb:90:in `block (2 levels) in create_threads'
An error occurred while installing gobject-introspection (4.2.0), and Bundler cannot continue.
In Gemfile:
gobject-introspection
Failed to verify release candidate. See /var/folders/rr/t_15q7dx4_lf1nv0btypffcw0000gn/T/arrow-15.0.0.XXXXX.MBSLuBRsHl for details.
raul@raul-MacBook-Pro release % ls -l /Library/Developer/CommandLineTools/SDKs/
total 0
drwxr-xr-x 7 root wheel 224 Nov 19 2021 MacOSX12.1.sdk
drwxr-xr-x 3 root wheel 96 Feb 10 14:11 MacOSX12.3.sdk
lrwxr-xr-x 1 root wheel 14 Feb 21 10:57 MacOSX12.sdk -> MacOSX12.3.sdk
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1495010393
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
On my Mac mini environment:
```console
$ ls -l /Library/Developer/CommandLineTools/SDKs
total 0
lrwxr-xr-x 1 root wheel 14 12 2 05:05 MacOSX.sdk -> MacOSX14.0.sdk
drwxr-xr-x 7 root wheel 224 8 21 2023 MacOSX12.3.sdk
lrwxr-xr-x 1 root wheel 14 8 21 2023 MacOSX12.sdk -> MacOSX12.3.sdk
drwxr-xr-x 7 root wheel 224 12 2 05:05 MacOSX13.3.sdk
lrwxr-xr-x 1 root wheel 14 12 2 05:04 MacOSX13.sdk -> MacOSX13.3.sdk
drwxr-xr-x 7 root wheel 224 9 1 04:12 MacOSX14.0.sdk
lrwxr-xr-x 1 root wheel 14 12 2 05:04 MacOSX14.sdk -> MacOSX14.0.sdk
```
Could you try again after `sudo ln -s MacOSX12.3.sdk /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1479959117
##########
dev/release/02-source.sh:
##########
@@ -202,7 +202,7 @@ The vote will be open for at least 72 hours.
[10]: https://apache.jfrog.io/artifactory/arrow/python-rc/${version}-rc${rc}
[11]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/
[12]: https://github.com/apache/arrow/blob/${release_hash}/CHANGELOG.md
-[13]: https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates
+[13]: https://arrow.apache.org/docs/developers/release_verification.html
Review Comment:
We probably can change that. I will try to remember to update the vote thread email before sending it to point to the `dev` documentation for the 16.0.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1491517777
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
Review Comment:
```suggestion
pushed dev/release
sudo ./setup-ubuntu.sh
popd
```
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
I think that this is needless because Homebrew's GObject Introspection uses system libffi: https://github.com/Homebrew/homebrew-core/blob/c8900f1b3f0483b602e948d2c5400e8ac870e690/Formula/g/gobject-introspection.rb#L33
```suggestion
```
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
Review Comment:
Or:
```suggestion
sudo dev/release/setup-ubuntu.sh
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1492300061
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
After `brew uninstall libffi` this is the error I get:
```
Resolving dependencies...
Fetching power_assert 2.0.3
Fetching native-package-installer 1.1.9
Fetching pkg-config 1.5.6
Installing power_assert 2.0.3
Installing native-package-installer 1.1.9
Installing pkg-config 1.5.6
Fetching test-unit 3.6.2
Fetching glib2 4.2.0
Installing test-unit 3.6.2
Installing glib2 4.2.0 with native extensions
Fetching gobject-introspection 4.2.0
Installing gobject-introspection 4.2.0 with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
current directory:
/private/var/folders/rr/t_15q7dx4_lf1nv0btypffcw0000gn/T/arrow-15.0.0.XXXXX.li0gqOMB3O/apache-arrow-15.0.0/c_glib/vendor/bundle/ruby/3.3.0/gems/gobject-introspection-4.2.0/ext/gobject-introspection
/opt/homebrew/opt/ruby/bin/ruby extconf.rb
checking for --enable-debug-build option... no
checking for -Wall option to compiler... yes
checking for -Wcast-align option to compiler... yes
checking for -Wextra option to compiler... yes
checking for -Wformat=2 option to compiler... yes
checking for -Winit-self option to compiler... yes
checking for -Wlarger-than-65500 option to compiler... yes
checking for -Wmissing-declarations option to compiler... yes
checking for -Wmissing-format-attribute option to compiler... yes
checking for -Wmissing-include-dirs option to compiler... yes
checking for -Wmissing-noreturn option to compiler... yes
checking for -Wmissing-prototypes option to compiler... yes
checking for -Wnested-externs option to compiler... yes
checking for -Wold-style-definition option to compiler... yes
checking for -Wpacked option to compiler... yes
checking for -Wp,-D_FORTIFY_SOURCE=2 option to compiler... yes
checking for -Wpointer-arith option to compiler... yes
checking for -Wundef option to compiler... yes
checking for -Wout-of-line-declaration option to compiler... yes
checking for -Wunsafe-loop-optimizations option to compiler... no
checking for -Wwrite-strings option to compiler... yes
checking for Homebrew... yes
checking for gobject-introspection-1.0... yes (1.78.1)
creating rbgiversion.h
creating gobject-introspection-enum-types.c
creating gobject-introspection-enum-types.h
creating ruby-gobject-introspection.pc
creating Makefile
current directory:
/private/var/folders/rr/t_15q7dx4_lf1nv0btypffcw0000gn/T/arrow-15.0.0.XXXXX.li0gqOMB3O/apache-arrow-15.0.0/c_glib/vendor/bundle/ruby/3.3.0/gems/gobject-introspection-4.2.0/ext/gobject-introspection
make DESTDIR\= sitearchdir\=./.gem.20240216-45788-684atu sitelibdir\=./.gem.20240216-45788-684atu clean
current directory:
/private/var/folders/rr/t_15q7dx4_lf1nv0btypffcw0000gn/T/arrow-15.0.0.XXXXX.li0gqOMB3O/apache-arrow-15.0.0/c_glib/vendor/bundle/ruby/3.3.0/gems/gobject-introspection-4.2.0/ext/gobject-introspection
make DESTDIR\= sitearchdir\=./.gem.20240216-45788-684atu sitelibdir\=./.gem.20240216-45788-684atu
compiling gobject-introspection-enum-types.c
compiling rb-gi-arg-info.c
In file included from rb-gi-arg-info.c:21:
In file included from ./rb-gi-private.h:24:
In file included from
/private/var/folders/rr/t_15q7dx4_lf1nv0btypffcw0000gn/T/arrow-15.0.0.XXXXX.li0gqOMB3O/apache-arrow-15.0.0/c_glib/vendor/bundle/ruby/3.3.0/gems/glib2-4.2.0/ext/glib2/../../lib/rbgobject.h:27:
In file included from
/private/var/folders/rr/t_15q7dx4_lf1nv0btypffcw0000gn/T/arrow-15.0.0.XXXXX.li0gqOMB3O/apache-arrow-15.0.0/c_glib/vendor/bundle/ruby/3.3.0/gems/glib2-4.2.0/ext/glib2/../../lib/rbgutil.h:26:
In file included from /opt/homebrew/Cellar/ruby/3.3.0/include/ruby-3.3.0/ruby/encoding.h:22:
/opt/homebrew/Cellar/ruby/3.3.0/include/ruby-3.3.0/ruby/internal/encoding/ctype.h:82:46: warning: unused parameter 'enc' [-Wunused-parameter]
rb_enc_isascii(OnigCodePoint c, rb_encoding *enc)
^
In file included from rb-gi-arg-info.c:21:
In file included from ./rb-gi-private.h:28:
/opt/homebrew/Cellar/gobject-introspection/1.78.1/include/gobject-introspection-1.0/girffi.h:25:10: fatal error: 'ffi.h' file not found
#include <ffi.h>
^~~~~~~
1 warning and 1 error generated.
make: *** [rb-gi-arg-info.o] Error 1
make failed, exit code 2
Gem files will remain installed in
/private/var/folders/rr/t_15q7dx4_lf1nv0btypffcw0000gn/T/arrow-15.0.0.XXXXX.li0gqOMB3O/apache-arrow-15.0.0/c_glib/vendor/bundle/ruby/3.3.0/gems/gobject-introspection-4.2.0 for inspection.
Results logged to
/private/var/folders/rr/t_15q7dx4_lf1nv0btypffcw0000gn/T/arrow-15.0.0.XXXXX.li0gqOMB3O/apache-arrow-15.0.0/c_glib/vendor/bundle/ruby/3.3.0/extensions/arm64-darwin-23/3.3.0/gobject-introspection-4.2.0/gem_make.out
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:125:in `run'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:51:in `block in make'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:43:in `each'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:43:in `make'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/ext_conf_builder.rb:42:in `build'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:193:in `build_extension'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:227:in `block in build_extensions'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:224:in `each'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/ext/builder.rb:224:in `build_extensions'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/installer.rb:852:in `build_extensions'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/rubygems_gem_installer.rb:76:in `build_extensions'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/rubygems_gem_installer.rb:28:in `install'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/source/rubygems.rb:205:in `install'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/installer/gem_installer.rb:54:in `install'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/installer/gem_installer.rb:16:in `install_from_spec'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/installer/parallel_installer.rb:132:in `do_install'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/installer/parallel_installer.rb:123:in `block in worker_pool'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/worker.rb:62:in `apply_func'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/worker.rb:57:in `block in process_queue'
<internal:kernel>:187:in `loop'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/worker.rb:54:in `process_queue'
/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/bundler/worker.rb:90:in `block (2 levels) in create_threads'
An error occurred while installing gobject-introspection (4.2.0), and Bundler cannot continue.
In Gemfile:
gobject-introspection
Failed to verify release candidate. See /var/folders/rr/t_15q7dx4_lf1nv0btypffcw0000gn/T/arrow-15.0.0.XXXXX.li0gqOMB3O for details.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1495010852
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
(I'm not sure who created the `MacOSX${MAJOR_VERSION}.sdk` symbolic links. But I haven't done it manually.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1498461425
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
Yes. Let's do it! (We remove `brew install libffi` in this PR, merge this PR and open a new issue for this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1495009488
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
Thanks. `MacOSX12.sdk -> MacOSX12.3.sdk` symbolic link doesn't exist. I think that it's a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #39960:
URL: https://github.com/apache/arrow/pull/39960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39960:
URL: https://github.com/apache/arrow/pull/39960#issuecomment-1960654630
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit f9995ac4c104c9df1577a8ac85bddff3c5eacd35.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/21891840100) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #39960:
URL: https://github.com/apache/arrow/pull/39960#issuecomment-1947059768
http://crossbow.voltrondata.com/pr_docs/39960/developers/release_verification.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1491536566
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,148 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu
+------
+
+You might have to install some packages on your system. The following
+utility script can be used to set your Ubuntu system. This wil install
+the required packages to perform a source verification on a clean
+Ubuntu:
+
+.. code-block::
+
+ # From the arrow clone
+ popd dev/release
+ sudo ./setup-ubuntu.sh
+ pushd
+
+macOS ARM
+---------
+
+.. code-block::
+
+ # From the arrow clone
+ brew install gpg
+ brew bundle --file=cpp/Brewfile
+ brew bundle --file=c_glib/Brewfile
+ brew uninstall node
+ # You might need to add node, ruby java and maven to the PATH, follow
+ # instructions from brew after installing.
+ brew install node@20
+ brew install ruby
+ brew install openjdk
+ brew install maven
+ # libffi required for gobject-introspection gem
+ brew install libffi
Review Comment:
without this my build was failing on a brand new M2. I can share the logs tomorrow if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1483693947
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,156 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu 22.04
+------------
+
+You might have to install some packages on your system. The following
+packages were required to perform a source verification on a clean
+Ubuntu 22.04 from an AWS instance:
+
+.. code-block::
+
+ sudo apt update
+
+ # Install miscellanious required packages
+ sudo apt install \
+ build-essential \
+ clang \
+ cmake \
+ libsqlite3-dev \
+ libssh-dev \
+ libyaml-dev \
+ llvm-dev \
+ python3-dev \
+ python3.10-venv
+
+ # Install ruby
Review Comment:
I think you need to install: https://packages.ubuntu.com/search?keywords=gobject-introspection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-31735: [Docs][Release] Move release verification guide to developers documentation [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #39960:
URL: https://github.com/apache/arrow/pull/39960#discussion_r1483401888
##########
docs/source/developers/release_verification.rst:
##########
@@ -0,0 +1,156 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _release_verification:
+
+============================
+Release Verification Process
+============================
+
+This page provides detailed information on the steps followed to perform
+a release verification on the major platforms.
+
+Principles
+==========
+
+The Apache Arrow Release Approval process follows the guidelines defined at the
+`Apache Software Foundation Release Approval <https://www.apache.org/legal/release-policy.html#release-approval>`_.
+
+For a release vote to pass, a minimum of three positive binding votes and more
+positive binding votes than negative binding votes MUST be cast.
+Releases may not be vetoed. Votes cast by PMC members are binding, however,
+non-binding votes are greatly encouraged and a sign of a healthy project.
+
+Running the release verification
+================================
+
+Linux and macOS
+---------------
+
+In order to run the verification script either for the source release or the
+binary artifacts see the following guidelines:
+
+.. code-block::
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the source verification
+ TEST_DEFAULT=0 TEST_SOURCE=1 verify-release-candidate.sh $VERSION $RC_NUM
+
+ # this will create and automatically clean up a temporary directory for the verification environment and will run the binary verification
+ TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh $VERSION $RC_NUM
+
+ # to verify only certain implementations use the TEST_DEFAULT=0 and TEST_* variables
+ # here are a couple of examples, but see the source code for the available options
+ TEST_DEFAULT=0 TEST_CPP=1 verify-release-candidate.sh $VERSION $RC_NUM # only C++ tests
+ TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Python tests
+ TEST_DEFAULT=0 TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 verify-release-candidate.sh $VERSION $RC_NUM # C++ and Java integration tests
+
+ # to verify certain binaries use the TEST_* variables as:
+ TEST_DEFAULT=0 TEST_WHEELS=1 verify-release-candidate.sh $VERSION $RC_NUM # only Wheels
+ TEST_DEFAULT=0 TEST_APT=1 verify-release-candidate.sh $VERSION $RC_NUM # only APT packages
+ TEST_DEFAULT=0 TEST_YUM=1 verify-release-candidate.sh $VERSION $RC_NUM # only YUM packages
+ TEST_DEFAULT=0 TEST_JARS=1 verify-release-candidate.sh $VERSION $RC_NUM # only JARS
+
+Windows
+-------
+
+In order to run the verification script on Windows you have to download
+the source tarball from the SVN dist system that you wish to verify:
+
+.. code-block::
+
+ dev\release\verify-release-candidate.bat %VERSION% %RC_NUM%
+
+System Configuration Instructions
+=================================
+
+You will need some tools installed like curl, git, etcetera.
+
+Ubuntu 22.04
+------------
+
+You might have to install some packages on your system. The following
+packages were required to perform a source verification on a clean
+Ubuntu 22.04 from an AWS instance:
+
+.. code-block::
+
+ sudo apt update
+
+ # Install miscellanious required packages
+ sudo apt install \
+ build-essential \
+ clang \
+ cmake \
+ libsqlite3-dev \
+ libssh-dev \
+ libyaml-dev \
+ llvm-dev \
+ python3-dev \
+ python3.10-venv
+
+ # Install ruby
Review Comment:
btw I am just testing the `15.0.0` release with this patch:
```diff
diff --git a/dev/release/verify-release-candidate.sh b/dev/release/verify-release-candidate.sh
index a61b5ba..50dad20 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -101,7 +101,7 @@ detect_cuda() {
return $((${n_gpus} < 1))
}
-ARROW_DIST_URL='https://dist.apache.org/repos/dist/dev/arrow'
+ARROW_DIST_URL='https://dist.apache.org/repos/dist/release/arrow'
download_dist_file() {
curl \
@@ -113,7 +113,7 @@ download_dist_file() {
}
download_rc_file() {
- download_dist_file apache-arrow-${VERSION}-rc${RC_NUMBER}/$1
+ download_dist_file arrow-${VERSION}/$1
}
import_gpg_keys() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org