You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chip Childers <ch...@apache.org> on 2013/04/12 14:58:50 UTC
Re: Review Request: Fix for CLOUDSTACK-1989
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10426/
-----------------------------------------------------------
(Updated April 12, 2013, 12:58 p.m.)
Review request for cloudstack, Chip Childers and Marcus Sorensen.
Summary (updated)
-----------------
Fix for CLOUDSTACK-1989
Description
-------
So, without this fix you can't query service offerings that don't have a domain id set (null).
This addresses bug CLOUDSTACK-1989.
Diffs
-----
server/src/com/cloud/api/query/QueryManagerImpl.java 951d09e
Diff: https://reviews.apache.org/r/10426/diff/
Testing
-------
Called "listServiceOfferings" using a simple perl script, once with an ID, and once without an ID specified.
Thanks,
Ryan Dietrich
Re: Review Request: Fix for CLOUDSTACK-1989
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10426/#review19070
-----------------------------------------------------------
Commit 38df62865d905aeac49fac7c32b66c7099036867 in branch refs/heads/master from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=38df628 ]
CLOUDSTACK-1989: Without this fix you can't query service offerings
that don't have a domain id set (null).
Tested via: Called "listServiceOfferings" using a simple perl script,
once with an ID, and once without an ID specified.
Signed-off-by: Chip Childers <ch...@gmail.com>
- ASF Subversion and Git Services
On April 12, 2013, 12:58 p.m., Ryan Dietrich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10426/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 12:58 p.m.)
>
>
> Review request for cloudstack, Chip Childers and Marcus Sorensen.
>
>
> Description
> -------
>
> So, without this fix you can't query service offerings that don't have a domain id set (null).
>
>
> This addresses bug CLOUDSTACK-1989.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/query/QueryManagerImpl.java 951d09e
>
> Diff: https://reviews.apache.org/r/10426/diff/
>
>
> Testing
> -------
>
> Called "listServiceOfferings" using a simple perl script, once with an ID, and once without an ID specified.
>
>
> Thanks,
>
> Ryan Dietrich
>
>
Re: Review Request: Fix for CLOUDSTACK-1989
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10426/#review19069
-----------------------------------------------------------
Commit b20e29cffcafb4cb781b360a55203e4ef3dee968 in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b20e29c ]
CLOUDSTACK-1989: Without this fix you can't query service offerings
that don't have a domain id set (null).
Tested via: Called "listServiceOfferings" using a simple perl script,
once with an ID, and once without an ID specified.
Signed-off-by: Chip Childers <ch...@gmail.com>
- ASF Subversion and Git Services
On April 12, 2013, 12:58 p.m., Ryan Dietrich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10426/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 12:58 p.m.)
>
>
> Review request for cloudstack, Chip Childers and Marcus Sorensen.
>
>
> Description
> -------
>
> So, without this fix you can't query service offerings that don't have a domain id set (null).
>
>
> This addresses bug CLOUDSTACK-1989.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/query/QueryManagerImpl.java 951d09e
>
> Diff: https://reviews.apache.org/r/10426/diff/
>
>
> Testing
> -------
>
> Called "listServiceOfferings" using a simple perl script, once with an ID, and once without an ID specified.
>
>
> Thanks,
>
> Ryan Dietrich
>
>