You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Aleksandar Bircakovic <a....@levi9.com> on 2015/09/01 10:03:20 UTC

Review Request 37994: SAMZA 368 AM UI should show failed container information

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37994/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

Failed containers (ID, exit code and message) are displayed on the AM UI under Containers section.


Diffs
-----

  samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml ce2145a 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala f667c83 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala 1743c86 

Diff: https://reviews.apache.org/r/37994/diff/


Testing
-------


Thanks,

Aleksandar Bircakovic


Re: Review Request 37994: SAMZA 368 AM UI should show failed container information

Posted by Navina Ramesh <nr...@linkedin.com>.

> On Oct. 19, 2015, 8:48 p.m., Navina Ramesh wrote:
> > Ship It!

Thanks for re-patching this after SAMZA-619!


- Navina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37994/#review103155
-----------------------------------------------------------


On Oct. 12, 2015, 11:59 a.m., Aleksandar Bircakovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37994/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2015, 11:59 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Failed containers (ID, exit code and message) are displayed on the AM UI under Containers section.
> 
> 
> Diffs
> -----
> 
>   samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaAppState.java d5be36e 
>   samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaTaskManager.java d17ffe0 
>   samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml 2d16fe0 
> 
> Diff: https://reviews.apache.org/r/37994/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build successful and failed containers displayed on AM UI
> 
> 
> Thanks,
> 
> Aleksandar Bircakovic
> 
>


Re: Review Request 37994: SAMZA 368 AM UI should show failed container information

Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37994/#review103155
-----------------------------------------------------------

Ship it!


Ship It!

- Navina Ramesh


On Oct. 12, 2015, 11:59 a.m., Aleksandar Bircakovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37994/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2015, 11:59 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Failed containers (ID, exit code and message) are displayed on the AM UI under Containers section.
> 
> 
> Diffs
> -----
> 
>   samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaAppState.java d5be36e 
>   samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaTaskManager.java d17ffe0 
>   samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml 2d16fe0 
> 
> Diff: https://reviews.apache.org/r/37994/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build successful and failed containers displayed on AM UI
> 
> 
> Thanks,
> 
> Aleksandar Bircakovic
> 
>


Re: Review Request 37994: SAMZA 368 AM UI should show failed container information

Posted by Aleksandar Bircakovic <a....@levi9.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37994/
-----------------------------------------------------------

(Updated Oct. 12, 2015, 11:59 a.m.)


Review request for samza.


Changes
-------

Patch refactored after SAMZA-619


Repository: samza


Description
-------

Failed containers (ID, exit code and message) are displayed on the AM UI under Containers section.


Diffs (updated)
-----

  samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaAppState.java d5be36e 
  samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaTaskManager.java d17ffe0 
  samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml 2d16fe0 

Diff: https://reviews.apache.org/r/37994/diff/


Testing (updated)
-------

./gradlew clean build successful and failed containers displayed on AM UI


Thanks,

Aleksandar Bircakovic