You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/10 09:30:29 UTC
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1703: Adjust the timing of configuring ElasticJob in Spring Boot startup process
TeslaCN opened a new pull request #1703:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1703
Fixes #1696
Changes proposed in this pull request:
- Implements BeanPostProcessor to configure ElasticJob in earlier phase.
- Refactor ElasticJobLiteAutoConfiguration.
- Rename ElasticJobStartupRunner to ScheduleJobBootstrapStartupRunner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- merged pull request #1703: Adjust the timing of configuring ElasticJob in Spring Boot startup process
Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1703:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1703: Adjust the timing of configuring ElasticJob in Spring Boot startup process
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1703:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1703#issuecomment-724585342
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1703?src=pr&el=h1) Report
> Merging [#1703](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1703?src=pr&el=desc) (bd72f7c) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/678e9f592d8c3ce8cadd1c14101b4618495569c9?el=desc) (678e9f5) will **increase** coverage by `0.07%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1703?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1703 +/- ##
============================================
+ Coverage 85.99% 86.06% +0.07%
- Complexity 105 106 +1
============================================
Files 251 252 +1
Lines 5682 5682
Branches 878 878
============================================
+ Hits 4886 4890 +4
+ Misses 482 477 -5
- Partials 314 315 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1703?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ing/boot/job/ElasticJobBootstrapConfiguration.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1703/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1ib290LXN0YXJ0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvYm9vdC9qb2IvRWxhc3RpY0pvYkJvb3RzdHJhcENvbmZpZ3VyYXRpb24uamF2YQ==) | `64.28% <64.28%> (ø)` | `1.00 <1.00> (?)` | |
| [...ring/boot/job/ElasticJobLiteAutoConfiguration.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1703/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1ib290LXN0YXJ0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvYm9vdC9qb2IvRWxhc3RpY0pvYkxpdGVBdXRvQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <100.00%> (+36.36%)` | `1.00 <1.00> (ø)` | |
| [...ng/boot/job/ScheduleJobBootstrapStartupRunner.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1703/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1ib290LXN0YXJ0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvYm9vdC9qb2IvU2NoZWR1bGVKb2JCb290c3RyYXBTdGFydHVwUnVubmVyLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1703/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (-1.59%)` | `1.00% <0.00%> (ø%)` | |
| [...ener/AbstractDistributeOnceElasticJobListener.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1703/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvYXBpL2xpc3RlbmVyL0Fic3RyYWN0RGlzdHJpYnV0ZU9uY2VFbGFzdGljSm9iTGlzdGVuZXIuamF2YQ==) | `82.75% <0.00%> (+6.89%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1703?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1703?src=pr&el=footer). Last update [678e9f5...bd72f7c](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org