You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/06 22:39:24 UTC
[GitHub] [airflow] kaxil opened a new pull request #12867: Change the format for sha512 sum for releases
kaxil opened a new pull request #12867:
URL: https://github.com/apache/airflow/pull/12867
closes https://github.com/apache/airflow/issues/12832
This format is popular and supported by tools like Ansible.
```
❯ sha512sum ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
953d3c04ee6fd2fa96e126750e642fc0872add96d180901440a91bd61c494a711b48836c634d93dcb181006935772556d5b4426671bf1a638f0a0698b51b119f ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
```
vs
```
❯ gpg --print-md SHA512 ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz:
953D3C04 EE6FD2FA 96E12675 0E642FC0 872ADD96 D1809014 40A91BD6 1C494A71 1B48836C
634D93DC B1810069 35772556 D5B44266 71BF1A63 8F0A0698 B51B119F
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #12867: Change the format for sha512 sum for releases
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #12867:
URL: https://github.com/apache/airflow/pull/12867
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #12867: Change the format for sha512 sum for releases
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #12867:
URL: https://github.com/apache/airflow/pull/12867#issuecomment-739737656
Hi @kaxil , what I meant was actually this part instead https://github.com/apache/airflow/blob/a4487a82cf7f399fa0cc20a1a09c1b1b329927d7/dev/README_RELEASE_PROVIDER_PACKAGES.md#sha512-check
May not be relevant necessarily, but you may help double-check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] noelmcloughlin commented on pull request #12867: Change the format for sha512 sum for releases
Posted by GitBox <gi...@apache.org>.
noelmcloughlin commented on pull request #12867:
URL: https://github.com/apache/airflow/pull/12867#issuecomment-739584797
Supported by Salt too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12867: Change the format for sha512 sum for releases
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12867:
URL: https://github.com/apache/airflow/pull/12867#issuecomment-739988327
> Hi @kaxil , what I meant was actually this part instead https://github.com/apache/airflow/blob/a4487a82cf7f399fa0cc20a1a09c1b1b329927d7/dev/README_RELEASE_PROVIDER_PACKAGES.md#sha512-check
>
> May not be relevant necessarily, but you may help double-check.
Oh yeah -- missed it -- Created https://github.com/apache/airflow/pull/12886 to update that too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12867: Change the format for sha512 sum for releases
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12867:
URL: https://github.com/apache/airflow/pull/12867#issuecomment-739586021
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12867: Change the format for sha512 sum for releases
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12867:
URL: https://github.com/apache/airflow/pull/12867#issuecomment-740205356
I've been meaning to do this for ages. :sparkles:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12867: Change the format for sha512 sum for releases
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12867:
URL: https://github.com/apache/airflow/pull/12867#issuecomment-739581775
> There is another usage of `gpg --print-md SHA512` in `dev/README_RELEASE_PROVIDER_PACKAGES.md`. Shall it be updated as well?
Looks like that was a separate issue, fixed it here: https://github.com/apache/airflow/pull/12869
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org