You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/02/09 12:01:50 UTC

[GitHub] [ozone] adoroszlai commented on pull request #3059: HDDS-6281. Update ratis version to 2.3.0-94db58b-SNAPSHOT version

adoroszlai commented on pull request #3059:
URL: https://github.com/apache/ozone/pull/3059#issuecomment-1033687170


   > https://github.com/apache/ozone/runs/5119767427?check_suite_focus=true
   > 
   > dependency fail, `src/main/license/update-jar-report.sh` has Regular expression error.
   > 
   > Change `perl -wpl -e 's/-[0-9]+(\[0-9]+)*(-([0-9a-z]+-)?SNAPSHOT)?+//g; s/\.v\d+\.jar/.jar/g;'` to
   > 
   > `perl -wpl -e 's/-[0-9]+(\.[0-9]+)*(-([0-9a-z]+-)?SNAPSHOT)?+//g; s/\.v\d+\.jar/.jar/g;'`
   
   Thanks for finding this.  In other words, the `.` needs to be escaped to make it a literal `.` instead of "any char".  (I think the "from" expression is not correct above, it has a `\` instead of `.`.)
   
   ```diff
   diff --git hadoop-ozone/dist/src/main/license/update-jar-report.sh hadoop-ozone/dist/src/main/license/update-jar-report.sh
   index dfd68a264..6cc6238f4 100755
   --- hadoop-ozone/dist/src/main/license/update-jar-report.sh
   +++ hadoop-ozone/dist/src/main/license/update-jar-report.sh
   @@ -30,4 +30,4 @@ cd "$OZONE_DIST_DIR"
   
    #sed expression removes the version. Usually license is not changed with version bumps
    #jacoco and test dependencies are excluded
   -find . -type f -name "*.jar" | cut -c3- | perl -wpl -e 's/-[0-9]+(.[0-9]+)*(-([0-9a-z]+-)?SNAPSHOT)?+//g; s/\.v\d+\.jar/.jar/g;' | grep -v -e jacoco -e hdds-test-utils | sort > "$SCRIPTDIR"/$REPORT_NAME
   +find . -type f -name "*.jar" | cut -c3- | perl -wpl -e 's/-[0-9]+(\.[0-9]+)*(-([0-9a-z]+-)?SNAPSHOT)?+//g; s/\.v\d+\.jar/.jar/g;' | grep -v -e jacoco -e hdds-test-utils | sort > "$SCRIPTDIR"/$REPORT_NAME
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org