You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Dapeng Sun <da...@intel.com> on 2014/11/19 13:11:26 UTC
Review Request 28227: SENTRY-530 Add thrift protocol version check
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28227/
-----------------------------------------------------------
Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
Bugs: SENTRY-530
https://issues.apache.org/jira/browse/SENTRY-530
Repository: sentry
Description
-------
As discussed in SENTRY-390, we should check thirft version between client and server. if the version mismatch, it should throw an exception.
Diffs
-----
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/thrift/sentry_common_serviceConstants.java 4fdeaeb
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryThriftAPIMismatchException.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java c3dbf78
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 03ed378
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Status.java c93dad5
sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 9456274
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyStoreProcessor.java ea4e967
Diff: https://reviews.apache.org/r/28227/diff/
Testing
-------
UnitTests passed in local.
Thanks,
Dapeng Sun
Re: Review Request 28227: SENTRY-530 Add thrift protocol version check
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28227/#review91967
-----------------------------------------------------------
Overall looks good to me. @Dapeng, shall we also update the default versions to V2 in our request thrift structs?
- Sravya Tirukkovalur
On Nov. 19, 2014, 12:11 p.m., Dapeng Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28227/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 12:11 p.m.)
>
>
> Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-530
> https://issues.apache.org/jira/browse/SENTRY-530
>
>
> Repository: sentry
>
>
> Description
> -------
>
> As discussed in SENTRY-390, we should check thirft version between client and server. if the version mismatch, it should throw an exception.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/thrift/sentry_common_serviceConstants.java 4fdeaeb
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryThriftAPIMismatchException.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java c3dbf78
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 03ed378
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Status.java c93dad5
> sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 9456274
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyStoreProcessor.java ea4e967
>
> Diff: https://reviews.apache.org/r/28227/diff/
>
>
> Testing
> -------
>
> UnitTests passed in local.
>
>
> Thanks,
>
> Dapeng Sun
>
>
Re: Review Request 28227: SENTRY-530 Add thrift protocol version check
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28227/#review92475
-----------------------------------------------------------
Ship it!
Ship It!
- Sravya Tirukkovalur
On July 21, 2015, 7 a.m., Dapeng Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28227/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 7 a.m.)
>
>
> Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-530
> https://issues.apache.org/jira/browse/SENTRY-530
>
>
> Repository: sentry
>
>
> Description
> -------
>
> As discussed in SENTRY-390, we should check thirft version between client and server. if the version mismatch, it should throw an exception.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsRequest.java a0c30fe
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java 156688c
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java 51e1017
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java 07b155f
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TCreateSentryRoleRequest.java 07f0eca
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropPrivilegesRequest.java 26b136a
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropSentryRoleRequest.java 6958542
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesForProviderRequest.java d1dd6a1
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesRequest.java 505c548
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryRolesRequest.java 078cb6b
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TRenamePrivilegesRequest.java 22d9b4c
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/thrift/sentry_common_serviceConstants.java 6c3d171
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryThriftAPIMismatchException.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 30792f3
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 0d775f1
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Status.java c93dad5
> sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 956dabe
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyStoreProcessor.java ea4e967
>
> Diff: https://reviews.apache.org/r/28227/diff/
>
>
> Testing
> -------
>
> UnitTests passed in local.
>
>
> Thanks,
>
> Dapeng Sun
>
>
Re: Review Request 28227: SENTRY-530 Add thrift protocol version check
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28227/#review92477
-----------------------------------------------------------
Ah, I realized lately that you have updated the default protocol versions in the thrift generated code instead of thrift definition. Nevermind, I can take care of that in a follow up.
- Sravya Tirukkovalur
On July 21, 2015, 7 a.m., Dapeng Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28227/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 7 a.m.)
>
>
> Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-530
> https://issues.apache.org/jira/browse/SENTRY-530
>
>
> Repository: sentry
>
>
> Description
> -------
>
> As discussed in SENTRY-390, we should check thirft version between client and server. if the version mismatch, it should throw an exception.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsRequest.java a0c30fe
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java 156688c
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java 51e1017
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java 07b155f
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TCreateSentryRoleRequest.java 07f0eca
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropPrivilegesRequest.java 26b136a
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropSentryRoleRequest.java 6958542
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesForProviderRequest.java d1dd6a1
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesRequest.java 505c548
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryRolesRequest.java 078cb6b
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TRenamePrivilegesRequest.java 22d9b4c
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/thrift/sentry_common_serviceConstants.java 6c3d171
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryThriftAPIMismatchException.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 30792f3
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 0d775f1
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Status.java c93dad5
> sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 956dabe
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyStoreProcessor.java ea4e967
>
> Diff: https://reviews.apache.org/r/28227/diff/
>
>
> Testing
> -------
>
> UnitTests passed in local.
>
>
> Thanks,
>
> Dapeng Sun
>
>
Re: Review Request 28227: SENTRY-530 Add thrift protocol version check
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28227/
-----------------------------------------------------------
(Updated 七月 21, 2015, 3 p.m.)
Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
Changes
-------
Updated patch accroding Sravya's comments, Jenkins passed at https://builds.apache.org/job/PreCommit-SENTRY-Build/705
Bugs: SENTRY-530
https://issues.apache.org/jira/browse/SENTRY-530
Repository: sentry
Description
-------
As discussed in SENTRY-390, we should check thirft version between client and server. if the version mismatch, it should throw an exception.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsRequest.java a0c30fe
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java 156688c
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java 51e1017
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java 07b155f
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TCreateSentryRoleRequest.java 07f0eca
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropPrivilegesRequest.java 26b136a
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropSentryRoleRequest.java 6958542
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesForProviderRequest.java d1dd6a1
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesRequest.java 505c548
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryRolesRequest.java 078cb6b
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TRenamePrivilegesRequest.java 22d9b4c
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/thrift/sentry_common_serviceConstants.java 6c3d171
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryThriftAPIMismatchException.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 30792f3
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 0d775f1
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Status.java c93dad5
sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 956dabe
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyStoreProcessor.java ea4e967
Diff: https://reviews.apache.org/r/28227/diff/
Testing
-------
UnitTests passed in local.
Thanks,
Dapeng Sun