You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "horizonzy (via GitHub)" <gi...@apache.org> on 2023/03/07 16:12:56 UTC
[GitHub] [bookkeeper] horizonzy opened a new pull request, #3847: Avoid unnecessary force write.
horizonzy opened a new pull request, #3847:
URL: https://github.com/apache/bookkeeper/pull/3847
Descriptions of the changes in this PR:
The batch requests logFile is the same one, and the last request happens to be rolloverFileRequest, it may force write logFile twice.
The first force write: https://github.com/apache/bookkeeper/blob/57031323166bd55004aaf50e3f46611dbb7eacf7/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java#L535
The second force write:
https://github.com/apache/bookkeeper/blob/57031323166bd55004aaf50e3f46611dbb7eacf7/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java#L390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat merged pull request #3847: Avoid unnecessary force write.
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #3847:
URL: https://github.com/apache/bookkeeper/pull/3847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3847: Avoid unnecessary force write.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3847:
URL: https://github.com/apache/bookkeeper/pull/3847#issuecomment-1458492641
# [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3847](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (877c8b6) into [master](https://codecov.io/gh/apache/bookkeeper/commit/1bd1745742ce920a6bc015e086b78cc1aaec6357?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1bd1745) will **decrease** coverage by `11.60%`.
> The diff coverage is `36.36%`.
```diff
@@ Coverage Diff @@
## master #3847 +/- ##
=============================================
- Coverage 32.58% 20.99% -11.60%
+ Complexity 3113 2024 -1089
=============================================
Files 473 473
Lines 40910 40965 +55
Branches 5232 5241 +9
=============================================
- Hits 13329 8599 -4730
- Misses 25919 31101 +5182
+ Partials 1662 1265 -397
```
| Flag | Coverage Δ | |
|---|---|---|
| remaining | `?` | |
| tls | `20.99% <36.36%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/bookkeeper/replication/ReplicationWorker.java](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcmVwbGljYXRpb24vUmVwbGljYXRpb25Xb3JrZXIuamF2YQ==) | `0.00% <0.00%> (-75.41%)` | :arrow_down: |
| [...ain/java/org/apache/bookkeeper/bookie/Journal.java](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL0pvdXJuYWwuamF2YQ==) | `66.48% <100.00%> (-1.78%)` | :arrow_down: |
| [.../java/org/apache/bookkeeper/util/SubTreeCache.java](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvdXRpbC9TdWJUcmVlQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/bookkeeper/meta/UnderreplicatedLedger.java](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YS9VbmRlcnJlcGxpY2F0ZWRMZWRnZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...bookkeeper/meta/LedgerUnderreplicationManager.java](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YS9MZWRnZXJVbmRlcnJlcGxpY2F0aW9uTWFuYWdlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...a/org/apache/bookkeeper/client/LedgerFragment.java](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0xlZGdlckZyYWdtZW50LmphdmE=) | `0.00% <0.00%> (-90.79%)` | :arrow_down: |
| [...org/apache/bookkeeper/replication/AuditorTask.java](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcmVwbGljYXRpb24vQXVkaXRvclRhc2suamF2YQ==) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [.../bookkeeper/client/ListenerBasedPendingReadOp.java](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0xpc3RlbmVyQmFzZWRQZW5kaW5nUmVhZE9wLmphdmE=) | `0.00% <0.00%> (-86.37%)` | :arrow_down: |
| [...rg/apache/bookkeeper/replication/AuditorStats.java](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcmVwbGljYXRpb24vQXVkaXRvclN0YXRzLmphdmE=) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...va/org/apache/bookkeeper/client/LedgerChecker.java](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0xlZGdlckNoZWNrZXIuamF2YQ==) | `0.00% <0.00%> (-77.67%)` | :arrow_down: |
| ... and [136 more](https://codecov.io/gh/apache/bookkeeper/pull/3847?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org