You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2026/01/27 15:22:37 UTC

[PR] Update Java, Gradle, and Groovy versions [grails-core]

jamesfredley opened a new pull request, #15355:
URL: https://github.com/apache/grails-core/pull/15355

   ## Summary
   
   - Update CI Java matrix to test with Java 17, 21, and 25
   - Sync Java version to 17.0.18 across .sdkmanrc, release.yml, and Dockerfile
   - Update Gradle wrapper and tooling API to 8.14.4
   - Update Groovy version to 3.0.25 in multiple modules
   - Add cross-reference comments to all 9 Gradle version locations for easier maintenance
   
   ## Test plan
   
   - [ ] CI builds pass for grails-core on Java 17, 21, 25
   - [ ] CI builds pass for grails-gradle on Java 17, 25
   - [ ] CI builds pass for grails-forge on Java 17, 21


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Java, Gradle, and Groovy versions [grails-core]

Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #15355:
URL: https://github.com/apache/grails-core/pull/15355


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Java, Gradle, and Groovy versions [grails-core]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #15355:
URL: https://github.com/apache/grails-core/pull/15355#discussion_r2732603067


##########
.github/workflows/gradle.yml:
##########
@@ -30,7 +30,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        java: [ 17, 21 ]
+        java: [ 17, 25 ]

Review Comment:
   The PR description states "Update CI Java matrix to test with Java 17, 21, and 25", but the actual changes show that Java 21 was removed from several test matrices (buildGradle, mongodbFunctional, and hibernate5Functional) and replaced with Java 25, rather than adding Java 25 alongside Java 21. The description should clarify that some matrices no longer test with Java 21, or if this was unintentional, Java 21 should be retained.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Java, Gradle, and Groovy versions [grails-core]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #15355:
URL: https://github.com/apache/grails-core/pull/15355#issuecomment-3805901877

   <!-- Bito Reply -->
   The PR changes in .github/workflows/gradle.yml replace Java 21 with Java 25 in the buildGradle, mongodbFunctional, and hibernate5Functional job matrices, rather than adding Java 25 alongside Java 21. This matches your observation that the description should be updated to clarify the removal of Java 21 testing in those matrices, or Java 21 should be retained if the change was unintentional.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org