[jira] [Resolved] (OODT-731) Fix File Manager Unit Tests - 'catalog' Package

["Ross Laidlaw (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OODT-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ross Laidlaw resolved OODT-731.
-------------------------------

    Resolution: Fixed

The Jenkins build showed a reduction of 34 test failures associated with the catalog package in File Manager.  Interestingly though, for the latest build (1430) one of the tests in the 'validation' package (TestXMLValidationLayer#testGetElements) started failing (a failure that we've seen recently in OODT-685) suggesting that there might be a hidden dependency or link between that test and other tests.

When I run the test class in isolation with the latest trunk, all tests pass:

{noformat}
mvn clean -Dtest=TestXMLValidationLayer -DfailIfNoTests=false test -pl filemgr -am


-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.2 sec

Results :

Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
{noformat}

Will investigate further under a separate JIRA issue.

> Fix File Manager Unit Tests - 'catalog' Package
> -----------------------------------------------
>
>                 Key: OODT-731
>                 URL: https://issues.apache.org/jira/browse/OODT-731
>             Project: OODT
>          Issue Type: Sub-task
>          Components: file manager
>    Affects Versions: 0.7
>            Reporter: Ross Laidlaw
>            Assignee: Ross Laidlaw
>              Labels: patch, test
>             Fix For: 0.7
>
>         Attachments: OODT-731.fix-catalog-tests.rlaidlaw.2014-08-05.patch.txt
>
>
> This step fixes unit tests for the file manager's 'catalog' package.  It makes similar changes to those made in OODT-722, OODT-723 and OODT-729.  Four test classes are affected: TestDataSourceCatalog, TestLuceneCatalog, TestMappedDataSourceCatalog and TestOrderedDataSourceCatalog.
> In each case, I've replaced hard-coded paths to test resources with paths from URLs via the 'getResource()' method.  I've also used java.util.Properties objects to set System properties and then restore initial settings after each test is run.
> Running the following command from the top-level (trunk) directory for each test class:
> {noformat}
> mvn clean -Dtest=<test class name> -DfailIfNoTests=false test -pl filemgr -am
> {noformat}
> The results obtained were as follows:
> Before applying the patch:
> {noformat}
> TestDataSourceCatalog Results :
>   Tests run: 7, Failures: 7, Errors: 0, Skipped: 0
> TestLuceneCatalog Results:
>   Tests run: 12, Failures: 12, Errors: 0, Skipped: 0
> TestMappedDataSourceCatalog Results :
>   Tests run: 7, Failures: 7, Errors: 0, Skipped: 0
> TestOrderedDataSourceCatalog Results :
>   Tests run: 8, Failures: 8, Errors: 0, Skipped: 0
> {noformat}
> After applying the patch:
> {noformat}
> TestDataSourceCatalog Results :
>   Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
> TestLuceneCatalog Results:
>   Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
> TestMappedDataSourceCatalog Results :
>   Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
> TestOrderedDataSourceCatalog Results :
>   Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)