You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@bookkeeper.apache.org by "liangyepianzhou (via GitHub)" <gi...@apache.org> on 2025/08/15 07:43:51 UTC

[PR] Handling outdated and misleading comments in maybeHandleDelayedWriteBookieFailure [bookkeeper]

liangyepianzhou opened a new pull request, #4653:
URL: https://github.com/apache/bookkeeper/pull/4653

   Main Issue: https://github.com/apache/bookkeeper/issues/281
   
   ### Motivation
   
   The issue https://github.com/apache/bookkeeper/issues/281 and https://github.com/apache/bookkeeper/issues/610 is completed. The notes should be updated after https://github.com/apache/bookkeeper/pull/1646.
   
   ### Changes
   
   update outdated notes.
   
   > ---
   > In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
   > checks for pull requests. A pull request can only be merged when it passes precommit checks.
   >
   > ---
   > Be sure to do all the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue #>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
   > - [ ] Replace `<Issue #>` in the title with the actual Issue number.
   > 
   > ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Handling outdated and misleading comments in maybeHandleDelayedWriteBookieFailure [bookkeeper]

Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.

liangyepianzhou commented on PR #4653:
URL: https://github.com/apache/bookkeeper/pull/4653#issuecomment-3484123276

   /bkbot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Handling outdated and misleading comments in maybeHandleDelayedWriteBookieFailure [bookkeeper]

Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.

liangyepianzhou closed pull request #4653: Handling outdated and misleading comments in maybeHandleDelayedWriteBookieFailure
URL: https://github.com/apache/bookkeeper/pull/4653


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Handling outdated and misleading comments in maybeHandleDelayedWriteBookieFailure [bookkeeper]

Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.

StevenLuMT closed pull request #4653: Handling outdated and misleading comments in maybeHandleDelayedWriteBookieFailure
URL: https://github.com/apache/bookkeeper/pull/4653


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Handling outdated and misleading comments in maybeHandleDelayedWriteBookieFailure [bookkeeper]

Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.

liangyepianzhou commented on PR #4653:
URL: https://github.com/apache/bookkeeper/pull/4653#issuecomment-3484126906

   reopen due to https://github.com/apache/bookkeeper/pull/4665


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Handling outdated and misleading comments in maybeHandleDelayedWriteBookieFailure [bookkeeper]

Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.

StevenLuMT commented on PR #4653:
URL: https://github.com/apache/bookkeeper/pull/4653#issuecomment-3405829738

   reopen to rerun ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org