You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Tim Williams <wi...@gmail.com> on 2005/07/05 22:57:30 UTC

Re: svn commit: r209314 - /forrest/branches/locationmap_branch/main/fresh-site/forrest.properties

Might also want to make a note in there that if views are enabled,
then locationmap resolution of resources won't immediately work
because viewsxhtml has it's own resource.xmap that takes precedence. 
This was at least the case the other day -- not sure if that
resource.xmap in the plugin has been updated with the latest
resource.xmap yet?

btw, is there a better/preferred way to respond to these commit messages?
--tim

On 7/5/05, thorsten@apache.org <th...@apache.org> wrote:
> Author: thorsten
> Date: Tue Jul  5 13:28:21 2005
> New Revision: 209314
> 
> URL: http://svn.apache.org/viewcvs?rev=209314&view=rev
> Log:
> deactivated views for fresh seed but left the code in comments to easily activate them again
> 
> Modified:
>     forrest/branches/locationmap_branch/main/fresh-site/forrest.properties
> 
> Modified: forrest/branches/locationmap_branch/main/fresh-site/forrest.properties
> URL: http://svn.apache.org/viewcvs/forrest/branches/locationmap_branch/main/fresh-site/forrest.properties?rev=209314&r1=209313&r2=209314&view=diff
> ==============================================================================
> --- forrest/branches/locationmap_branch/main/fresh-site/forrest.properties (original)
> +++ forrest/branches/locationmap_branch/main/fresh-site/forrest.properties Tue Jul  5 13:28:21 2005
> @@ -27,7 +27,8 @@
>  # Specifies name of Forrest skin to use
>  # See list at http://forrest.apache.org/docs/skins.html
>  #project.skin=pelt
> -project.skin=leather-dev
> +# uncomment the following skin if you are using views
> +#project.skin=leather-dev
> 
>  # Descriptors for plugins and skins
>  # comma separated list, file:// is supported
> @@ -116,7 +117,9 @@
>  # The names of plugins that are required to build the project
>  # comma separated list (no spaces)
>  # Run "forrest available-plugins" for a list of plug-ins currently available
> -project.required.plugins=org.apache.forrest.plugin.input.viewHelper.xhtml.ls,org.apache.forrest.plugin.output.viewHelper.xhtml,org.apache.forrest.plugin.internal.view,org.apache.forrest.plugin.output.pdf
> +project.required.plugins=org.apache.forrest.plugin.output.pdf
> +# Add the following plugins to project.required.plugins when using views:
> +#org.apache.forrest.plugin.input.viewHelper.xhtml.ls,org.apache.forrest.plugin.output.viewHelper.xhtml,org.apache.forrest.plugin.internal.view
> 
>  # Proxy configuration
>  # proxy.host=
> 
> 
>

Re: Why does viewhelper.xhtml duplicate resources.xmap

Posted by Thorsten Scherler <th...@apache.org>.
It is an relict from the first steps with views.

Feel free to refactor the code. ;-)

salu2

On Tue, 2005-07-05 at 22:50 +0100, Ross Gardler wrote:
> Tim Williams wrote:
> > Might also want to make a note in there that if views are enabled,
> > then locationmap resolution of resources won't immediately work
> > because viewsxhtml has it's own resource.xmap that takes precedence. 
> > This was at least the case the other day -- not sure if that
> > resource.xmap in the plugin has been updated with the latest
> > resource.xmap yet?
> 
> A plugin XMap file should not need to duplicate stuff in the existing 
> resources.xmap. It should only add matches that are not currently 
> handled by the default Forrest XMaps (or override ones that it needs to 
> overrisde).
> 
> Is there a reason why most (if not all) of the resources.xmap are 
> duplicated in this plugin? (I've not read the file detail, so I may have 
> missed important details)
> 
> Ross
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Why does viewhelper.xhtml duplicate resources.xmap

Posted by Ross Gardler <rg...@apache.org>.
Tim Williams wrote:
> Might also want to make a note in there that if views are enabled,
> then locationmap resolution of resources won't immediately work
> because viewsxhtml has it's own resource.xmap that takes precedence. 
> This was at least the case the other day -- not sure if that
> resource.xmap in the plugin has been updated with the latest
> resource.xmap yet?

A plugin XMap file should not need to duplicate stuff in the existing 
resources.xmap. It should only add matches that are not currently 
handled by the default Forrest XMaps (or override ones that it needs to 
overrisde).

Is there a reason why most (if not all) of the resources.xmap are 
duplicated in this plugin? (I've not read the file detail, so I may have 
missed important details)

Ross

responding to commit messages for further discussion

Posted by David Crossley <cr...@apache.org>.
Tim Williams wrote:
> 
> btw, is there a better/preferred way to respond to these commit messages?

No preferred way until we figure one out. Sometimes i change
the subject title, especially if there is a huge list of
filenames in it. Sometimes i leave the SVN revision number in the
title for reference. Often i clip the commit content to remove clutter.

-David