You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/30 05:39:57 UTC

[GitHub] [kafka] kamalcph commented on a diff in pull request #13059: MINOR: KafkaConfig should not expose internal config when queried for non-internal configs

kamalcph commented on code in PR #13059:
URL: https://github.com/apache/kafka/pull/13059#discussion_r1059249655


##########
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##########
@@ -580,7 +580,7 @@ object ConfigCommand extends Logging {
       .filter(entry => configSourceFilter match {
         case Some(configSource) => entry.source == configSource
         case None => true
-      }).toSeq
+      }).toSeq.sortBy(entry => entry.name())

Review Comment:
   side fix to display the configs in sorted order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org