[GitHub] [hudi] danny0405 commented on issue #8305: [SUPPORT] Potential FileSystem http connection leaking

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on issue #8305:
URL: https://github.com/apache/hudi/issues/8305#issuecomment-1492822936

   Thanks, I have checked the codes after your nice findings. The code snippet below should alreay release the connection resource:
   
   ```java
       Response response = ...;
       String content = response.returnContent().asString(Consts.UTF_8); -- the #returnContent() close the connection
   ```
   But I also noticed that the EXECUTOR is hard coded into max as 200 connections:
   
   ```java
           CONNMGR = new PoolingHttpClientConnectionManager(sfr);
           CONNMGR.setDefaultMaxPerRoute(100);
           CONNMGR.setMaxTotal(200);
           CLIENT = HttpClientBuilder.create().setConnectionManager(CONNMGR).build();
   ```
   
   That means one TM can at most has like 200 connections, which maybe a bottleneck if the parallelism is high. How many tasks there are on the TM then?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org