[jclouds/jclouds] Define the JDK version in a Maven property (#1152)

[Ignasi Barrera <no...@github.com>]

This changes how we reference the toolchain to use a Maven property. This will allow us to be more flexible and generic when configuring builds in Jenkins and we can avoid having a dedicated maven profile for each JDK version we want to support. A property can be overridden in the command-line, so it looks more convenient to configure it this way.

/cc @demobox
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1152

-- Commit Summary --

  * Define the JDK version in a Maven property

-- File Changes --

    M project/pom.xml (33)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1152.patch
https://github.com/jclouds/jclouds/pull/1152.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1152

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

[Ignasi Barrera <no...@github.com>]

If this works, the profile must also be defined in `jclouds-karaf` and `jclouds-cli`. I forgot those projects when merging the first PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1152#issuecomment-339230652

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

[Ignasi Barrera <no...@github.com>]

Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/6f7e4b92) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a03e047d).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1152#issuecomment-348139939

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

[Andrew Phillips <no...@github.com>]

demobox commented on this pull request.



> -          <plugin>
-            <artifactId>maven-toolchains-plugin</artifactId>
-            <version>1.1</version>
-            <executions>
-              <execution>
-                <goals>
-                  <goal>toolchain</goal>
-                </goals>
-              </execution>
-            </executions>
-            <configuration>
-              <toolchains>
-                <jdk>
-                  <version>1.8</version>
-                  <vendor>openjdk</vendor>
+                  <version>${jdk.version}</version>

@nacx Does removing the `oracle` vs. `openjdk` `<vendor>` attribute have any impact?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1152#pullrequestreview-80214278

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

[Ignasi Barrera <no...@github.com>]

nacx commented on this pull request.



> -          <plugin>
-            <artifactId>maven-toolchains-plugin</artifactId>
-            <version>1.1</version>
-            <executions>
-              <execution>
-                <goals>
-                  <goal>toolchain</goal>
-                </goals>
-              </execution>
-            </executions>
-            <configuration>
-              <toolchains>
-                <jdk>
-                  <version>1.8</version>
-                  <vendor>openjdk</vendor>
+                  <version>${jdk.version}</version>

No. We were not building against different JDK flavors, so it does not have an impact. If we want to do so, we can introduce the vendor again and revisit this. The property approach comes in handy for a clearer [jclouds-compat build](https://jclouds.ci.cloudbees.com/job/jclouds-compat/).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1152#discussion_r154105158

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

[Ignasi Barrera <no...@github.com>]

Closed #1152.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1152#event-1365282883

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

[Andrew Gaul <no...@github.com>]

gaul approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1152#pullrequestreview-71885965