[GitHub] [beam] lostluck commented on a change in pull request #16629: [BEAM-13757] adds pane observation in DoFn

[GitBox <gi...@apache.org>]

lostluck commented on a change in pull request #16629:
URL: https://github.com/apache/beam/pull/16629#discussion_r793879221



##########
File path: sdks/go/pkg/beam/core/funcx/fn.go
##########
@@ -17,9 +17,10 @@ package funcx
 
 import (
 	"fmt"
-	"github.com/apache/beam/sdks/v2/go/pkg/beam/core/sdf"
 	"reflect"
 
+	"github.com/apache/beam/sdks/v2/go/pkg/beam/core/sdf"
+

Review comment:
       rm spare space.

##########
File path: sdks/go/pkg/beam/core/funcx/fn.go
##########
@@ -386,7 +403,7 @@ func SubReturns(list []ReturnParam, indices ...int) []ReturnParam {
 }
 
 // The order of present parameters and return values must be as follows:
-// func(FnContext?, FnWindow?, FnEventTime?, FnType?, FnRTracker?, (FnValue, SideInput*)?, FnEmit*) (RetEventTime?, RetOutput?, RetError?)
+// func(FnContext?, FnPane? FnWindow?, FnEventTime?, FnType?, FnRTracker?, (FnValue, SideInput*)?, FnEmit*) (RetEventTime?, RetOutput?, RetError?)

Review comment:
       ```suggestion
   // func(FnContext?, FnPane?, FnWindow?, FnEventTime?, FnType?, FnRTracker?, (FnValue, SideInput*)?, FnEmit*) (RetEventTime?, RetOutput?, RetError?)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org