You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "wkleiminger (via GitHub)" <gi...@apache.org> on 2023/10/16 13:44:00 UTC
Re: [I] "Create Chart" ignores value of allow_limit_clause [superset]
wkleiminger commented on issue #25173:
URL: https://github.com/apache/superset/issues/25173#issuecomment-1764515545
Hi @Pazzeo
I found the issue. The problem isn't with superset (although its handling of the allow_limit_clause is not ideal). The problem is that SQLAlchemy for Sybase does not convert limit() to TOP. To fix this you have to fork sqlalchemy-sybase and implement the get_select_precolumns() as done for MSSQL here: https://github.com/zzzeek/sqlalchemy/blob/main/lib/sqlalchemy/dialects/mssql/base.py. I think it must have worked at some point as there still is a reference to get_select_precolumns() in the copyright header (although no implementation). I guess newer versions of Sybase ASE now support LIMIT and thus the code was changed.
Best,
Will
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org