[GitHub] [beam] damccorm opened a new issue, #19702: Make RowCoder @Internal

[GitBox <gi...@apache.org>]

damccorm opened a new issue, #19702:
URL: https://github.com/apache/beam/issues/19702

   RowCoder is currently public in sdk.coders, tempting people to use it directly. But the Schemas API is written such that everyone should be using SchemaCoder, and RowCoder should be an implementation detail.
   
   Unfortunately this isn't a trivial change, I tried to do it and resolve the few dependencies that cropped up, but running RowCoderTest yielded the following error:
   
   ```
   
   tried to access class org.apache.beam.sdk.schemas.RowCoderGenerator$EncodeInstruction from class org.apache.beam.sdk.coders.Coder$ByteBuddy$abBJo3R3
   java.lang.IllegalAccessError:
   tried to access class org.apache.beam.sdk.schemas.RowCoderGenerator$EncodeInstruction from class org.apache.beam.sdk.coders.Coder$ByteBuddy$abBJo3R3
   	at
   org.apache.beam.sdk.coders.Coder$ByteBuddy$abBJo3R3.encode(Unknown Source)
   	at org.apache.beam.sdk.coders.Coder$ByteBuddy$abBJo3R3.encode(Unknown
   Source)
   	at org.apache.beam.sdk.schemas.RowCoder.encode(RowCoder.java:159)
   	at org.apache.beam.sdk.schemas.RowCoder.encode(RowCoder.java:54)
   	at
   org.apache.beam.sdk.coders.Coder.encode(Coder.java:136)
   	at org.apache.beam.sdk.testing.CoderProperties.encode(CoderProperties.java:334)
   	at
   org.apache.beam.sdk.testing.CoderProperties.decodeEncode(CoderProperties.java:362)
   	at org.apache.beam.sdk.testing.CoderProperties.coderDecodeEncodeEqualInContext(CoderProperties.java:104)
   	at
   org.apache.beam.sdk.testing.CoderProperties.coderDecodeEncodeEqual(CoderProperties.java:94)
   
   ```
   
   
   My attempt is available at https://github.com/TheNeuralBit/beam/commit/869b8c6ba2f554bf56d8df70a754b76ef38dbc89
   
   
   Imported from Jira [BEAM-7974](https://issues.apache.org/jira/browse/BEAM-7974). Original Jira may contain additional context.
   Reported by: bhulette.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org