You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Serge P. Nekoval (JIRA)" <ji...@apache.org> on 2008/01/25 18:27:35 UTC

[jira] Created: (WICKET-1305) AbstractTextComponent requires itself to be rendered before conversion happens

AbstractTextComponent requires itself to be rendered before conversion happens
------------------------------------------------------------------------------

                 Key: WICKET-1305
                 URL: https://issues.apache.org/jira/browse/WICKET-1305
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.0-final
         Environment: wicket 1.3-final
            Reporter: Serge P. Nekoval


The bug is reproduced as follows:

1. Use StatelessForm.
2. Use compound model, eg CompoundPropertyModel. In this case, form components are not initially aware of their model types.
3. Use any text component inside, eg TextField

What happens:

1. In StatelessForm, form processing occurs BEFORE components were actually rendered.
2. BUT AbstractTextComponent guesses its model type ONLY in onBeforeRender().
3. onBeforeRender() never gets called, so text component doesn't know its actual type and cannot convert properly.
4. Everything crashes because of incorrect type (validators and form submission is working wrong).

Obviously, this processing sequence needs to be fixed (eg retrieve model type early or check for stateless forms explicitly).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WICKET-1305) AbstractTextComponent requires itself to be rendered before conversion happens

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner closed WICKET-1305.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.2

convertInput now checks if the type is already resolved or not

> AbstractTextComponent requires itself to be rendered before conversion happens
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-1305
>                 URL: https://issues.apache.org/jira/browse/WICKET-1305
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-final
>         Environment: wicket 1.3-final
>            Reporter: Serge P. Nekoval
>            Assignee: Johan Compagner
>             Fix For: 1.3.2
>
>
> The bug is reproduced as follows:
> 1. Use StatelessForm.
> 2. Use compound model, eg CompoundPropertyModel. In this case, form components are not initially aware of their model types.
> 3. Use any text component inside, eg TextField
> What happens:
> 1. In StatelessForm, form processing occurs BEFORE components were actually rendered.
> 2. BUT AbstractTextComponent guesses its model type ONLY in onBeforeRender().
> 3. onBeforeRender() never gets called, so text component doesn't know its actual type and cannot convert properly.
> 4. Everything crashes because of incorrect type (validators and form submission is working wrong).
> Obviously, this processing sequence needs to be fixed (eg retrieve model type early or check for stateless forms explicitly).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-1305) AbstractTextComponent requires itself to be rendered before conversion happens

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reassigned WICKET-1305:
-------------------------------------

    Assignee: Johan Compagner

> AbstractTextComponent requires itself to be rendered before conversion happens
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-1305
>                 URL: https://issues.apache.org/jira/browse/WICKET-1305
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-final
>         Environment: wicket 1.3-final
>            Reporter: Serge P. Nekoval
>            Assignee: Johan Compagner
>
> The bug is reproduced as follows:
> 1. Use StatelessForm.
> 2. Use compound model, eg CompoundPropertyModel. In this case, form components are not initially aware of their model types.
> 3. Use any text component inside, eg TextField
> What happens:
> 1. In StatelessForm, form processing occurs BEFORE components were actually rendered.
> 2. BUT AbstractTextComponent guesses its model type ONLY in onBeforeRender().
> 3. onBeforeRender() never gets called, so text component doesn't know its actual type and cannot convert properly.
> 4. Everything crashes because of incorrect type (validators and form submission is working wrong).
> Obviously, this processing sequence needs to be fixed (eg retrieve model type early or check for stateless forms explicitly).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.