You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/06/27 12:48:45 UTC

[commons-text] 01/02: Complete test

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-text.git

commit 1594ddd5bad69919bf7ea935999c17fe531b499d
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Tue Jun 27 08:43:22 2023 -0400

    Complete test
---
 .../commons/text/RandomStringGeneratorTest.java    | 23 ++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/src/test/java/org/apache/commons/text/RandomStringGeneratorTest.java b/src/test/java/org/apache/commons/text/RandomStringGeneratorTest.java
index 4228e6e6..14f91f52 100644
--- a/src/test/java/org/apache/commons/text/RandomStringGeneratorTest.java
+++ b/src/test/java/org/apache/commons/text/RandomStringGeneratorTest.java
@@ -23,6 +23,7 @@ import static org.assertj.core.api.Assertions.fail;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import org.apache.commons.text.RandomStringGenerator.Builder;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -220,6 +221,7 @@ public class RandomStringGeneratorTest {
         // @formatter:off
         final RandomStringGenerator generator = new RandomStringGenerator.Builder()
                 .selectFrom()
+                .selectFrom(null)
                 .selectFrom('a', 'b')
                 .selectFrom('a', 'b', 'c')
                 .selectFrom('a', 'b', 'c', 'd')
@@ -253,9 +255,26 @@ public class RandomStringGeneratorTest {
     @Test
     public void testSelectFromNullCharVarargs() {
         final int length = 5;
-        final RandomStringGenerator generator = new RandomStringGenerator.Builder().selectFrom(null).build();
-        final String randomText = generator.generate(length);
+        RandomStringGenerator generator = new RandomStringGenerator.Builder().selectFrom(null).build();
+        String randomText = generator.generate(length);
         assertThat(codePointLength(randomText)).isEqualTo(length);
+        for (final char c : randomText.toCharArray()) {
+            assertTrue(c >= Character.MIN_CODE_POINT && c <= Character.MAX_CODE_POINT);
+        }
+        //
+        final Builder builder = new RandomStringGenerator.Builder().selectFrom('a');
+        generator = builder.build();
+        randomText = generator.generate(length);
+        for (final char c : randomText.toCharArray()) {
+            assertEquals('a', c);
+        }
+        // null input resets
+        generator = builder.selectFrom(null).build();
+        randomText = generator.generate(length);
+        assertThat(codePointLength(randomText)).isEqualTo(length);
+        for (final char c : randomText.toCharArray()) {
+            assertTrue(c >= Character.MIN_CODE_POINT && c <= Character.MAX_CODE_POINT);
+        }
     }
 
     @Test