You are viewing a plain text version of this content. The canonical link for it is here.
Posted to robots@logging.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2023/07/21 10:51:33 UTC
[PR] Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5 (logging-log4j2)
dependabot[bot] opened a new pull request, #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586
Bumps [com.vlkan.log4j2:log4j2-logstash-layout](https://github.com/vy/log4j2-logstash-layout) from 0.18 to 1.0.5.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/vy/log4j2-logstash-layout/blob/master/CHANGELOG.md">com.vlkan.log4j2:log4j2-logstash-layout's changelog</a>.</em></p>
<blockquote>
<h3>(2020-10-30) v1.0.5</h3>
<ul>
<li>Fix Java 8 compatibility issues. (<a href="https://redirect.github.com/vy/log4j2-logstash-layout/issues/69">#69</a>)</li>
</ul>
<h3>(2020-10-29) v1.0.4</h3>
<ul>
<li>Try to dump the cause when stack trace serialization fails.</li>
</ul>
<h3>(2020-06-30) v1.0.3</h3>
<ul>
<li>Fix handling of non-<code>String</code> values in <code>map</code> directive. (<a href="https://redirect.github.com/vy/log4j2-logstash-layout/issues/61">#61</a>)</li>
</ul>
<h3>(2020-03-18) v1.0.2</h3>
<ul>
<li>
<p>Fix <code>ArrayIndexOutOfBoundsException</code> thrown when <code>stackTrace:text</code> produces
an output violating the truncation limit. (<a href="https://redirect.github.com/vy/log4j2-logstash-layout/issues/57">#57</a>)</p>
</li>
<li>
<p>Implement work around for <a href="https://redirect.github.com/FasterXML/jackson-core/issues/609">FasterXML/jackson-core#609</a> triggered when
<code>maxStringLength</code> is used in combination with
<code>emptyPropertyExclusionEnabled=true</code>. (<a href="https://redirect.github.com/vy/log4j2-logstash-layout/issues/55">#55</a>)</p>
</li>
</ul>
<h3>(2020-01-21) v1.0.1</h3>
<ul>
<li>Fix NPE in <code>StringTruncatingGeneratorDelegate</code>. (<a href="https://redirect.github.com/vy/log4j2-logstash-layout/issues/53">#53</a>)</li>
</ul>
<h3>(2020-01-08) v1.0.0</h3>
<ul>
<li>
<p>Switched to semantic versioning.</p>
</li>
<li>
<p>Add Java 9 module name: <code>com.vlkan.log4j2.logstash.layout</code>.</p>
</li>
<li>
<p>Set <code>maxByteCount</code> to 16 KiB by default.</p>
</li>
<li>
<p>Set <code>emptyPropertyExclusionEnabled</code> to <code>false</code> by default.</p>
</li>
<li>
<p>Remove <code>timestamp:nanos</code> and <code>timestamp:millis</code> directives in favor of
<code>timestamp:epoch[:divisor=<divisor>[,integral]]</code> directive.</p>
</li>
<li>
<p>Make formatted timestamp resolver GC-free.</p>
</li>
<li>
<p>Replace object pools with thread locals.</p>
</li>
<li>
<p>Add <code>locale</code> configuration.</p>
</li>
<li>
<p>Fix <code>JsonGenerator</code> state corruption in <code>ExceptionResolver</code> if
<code>LogEvent#getThrown()</code> is <code>null</code>.</p>
</li>
<li>
<p>Add <code>GelfLayout.json</code> template.</p>
</li>
<li>
<p>Add <code>level:severity</code> and <code>level:severity:code</code> resolvers. (<a href="https://redirect.github.com/vy/log4j2-logstash-layout/issues/48">#48</a>)</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/vy/log4j2-logstash-layout/commit/16d6c978b102c56b9559e98ace0fa3043a03c9bf"><code>16d6c97</code></a> [maven-release-plugin] prepare release v1.0.5</li>
<li><a href="https://github.com/vy/log4j2-logstash-layout/commit/bae279d9848405c5c0840810920e7b84869e0553"><code>bae279d</code></a> Fix Java 8 compatibility issues. (<a href="https://redirect.github.com/vy/log4j2-logstash-layout/issues/69">#69</a>)</li>
<li><a href="https://github.com/vy/log4j2-logstash-layout/commit/830191ecee5c1621fd33c236fe3d7ab7f86cf9b0"><code>830191e</code></a> [maven-release-plugin] prepare for next development iteration</li>
<li><a href="https://github.com/vy/log4j2-logstash-layout/commit/da9a7cd35ecea6b3ab770341ec3391915667f75e"><code>da9a7cd</code></a> [maven-release-plugin] prepare release v1.0.4</li>
<li><a href="https://github.com/vy/log4j2-logstash-layout/commit/5e7aee72363579368a49369dba7ceebd2c4cfe82"><code>5e7aee7</code></a> Add OSX to the OS matrix in CI.</li>
<li><a href="https://github.com/vy/log4j2-logstash-layout/commit/dc2c0fa022f65419e66a06c616db0cdebf3fe6ab"><code>dc2c0fa</code></a> Fix typo in GitHub Actions workflow file.</li>
<li><a href="https://github.com/vy/log4j2-logstash-layout/commit/ca9949174b49edb2ec2c7390179a1ab4fcb68617"><code>ca99491</code></a> Upgrade dependencies.</li>
<li><a href="https://github.com/vy/log4j2-logstash-layout/commit/6445d7a32bcdbe2493e2f381a0764d12b1ae3009"><code>6445d7a</code></a> Overhaul GitHub Actions workflow.</li>
<li><a href="https://github.com/vy/log4j2-logstash-layout/commit/97d51ede9b3727a212bcf8a73a2ae26fbd7149a9"><code>97d51ed</code></a> Add Maven Wrapper support.</li>
<li><a href="https://github.com/vy/log4j2-logstash-layout/commit/2b06527e8f8a909101228195a938b4e0b710585f"><code>2b06527</code></a> Try to dump the cause when stack trace serialization fails.</li>
<li>Additional commits viewable in <a href="https://github.com/vy/log4j2-logstash-layout/compare/v0.18...v1.0.5">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: robots-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5 (logging-log4j2)
Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1823210161
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: robots-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5 (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1823210104
I am converting this PR into an issue: #1990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5 (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1750755195
Yes, it is a bit funny: `3.x` is **not** a major release for `log4j-api`, we often argued that we don't want to break compatibility, but effectively we do.
So I'd propose to solve it using OSGi versioning of packages:
- we add an explicit OSGi version to all the packages in `log4j-api`. Since until now the version was inferred from the version of the bundle, the initial version must be `2.21.0` (@HannesWell am I right?),
- in version `3.x` we can bump the versions of those packages that contain changes.
However I am little pessimist we would be able to straighten the API, because the packages are all interconnected. For example, in the `Export-Package` header we see an entry:
```
org.apache.logging.log4j.message;uses:="org.apache.logging.log4j.util"
```
Unless I am mistaken the `uses` clause means: a `public` or `protected` member of a type in `org.apache.logging.log4j.message` has a type from `org.apache.logging.log4j.util` **in its signature** (`IndexedReadOnlyStringMap`).
And it gets worse:
```
org.apache.logging.log4j;uses:="org.apache.logging.log4j.message,org.apache.logging.log4j.spi,org.apache.logging.log4j.util"
```
As you can see `util` is all over the place and moreover it contains (obviously public) classes that we consider private. I have only a basic understanding of how OSGi semantic versioning works, but maybe we could get away with:
- removing from `org.apache.logging.log4j.util` every type that is not referenced by `org.apache.logging.log4j` or `org.apache.logging.log4j.message`,
- keep the version of these two packages at **2.21.0**,
- bumping the version of all other packages to **3.0.0** and use the occasion to clean those packages up.
My guess is that we are **not** allowed to make **any** changes to the types referenced from `org.apache.logging.log4j` or `org.apache.logging.log4j.message` or we'll need to bump the version of these packages too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5 (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1751200126
@vy,
It's a question of discipline. If we adhere to very strict rules on how our API can evolve and have tools to check and enforce those rules, all the users will profit from it.
A small example: I needed an additional method for `LogBuilder` to mark the first class in the stack that is part of the logging system, so I created [`BridgeAware`](https://github.com/apache/logging-log4j2/blob/2.x/log4j-api/src/main/java/org/apache/logging/log4j/BridgeAware.java). At the time it made sense to put it in the same package as `LogBuilder`, but now we can not remove it without potentially breaking the code of consumer's of the Log4j API.
It would be much wiser to put it in `spi`, since only implementations of the Log4j API use it and we can make breaking changes there in a minor release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5 (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1750343752
Binary backward compatibility of `Constants` is broken in `3.x`. [I have raised this issue](https://lists.apache.org/thread/fbkc24gp3sfzssqp6mvq62pb3qny1p1y), but no reactions so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5 (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1750765006
@ppkarwasz, how does this help to users that don't use OSGi?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5 (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1752544784
I have added versions to all our packages in #1843 and configured `bnd-baseline-maven-plugin` to check for breaking changes. This should warn us about breaking changes in packages we don't want to break.
Any further discussion regarding the Log4j API version 3.x should probably be on the `dev` mailing list. I have opened [a thread for this purpose](https://lists.apache.org/thread/qlqn4tpq1lco7yx3kn471ytvfhb7hd25).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5 (logging-log4j2)
Posted by "HannesWell (via GitHub)" <gi...@apache.org>.
HannesWell commented on PR #1586:
URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1751461830
> * we add an explicit OSGi version to all the packages in `log4j-api`. Since until now the version was inferred from the version of the bundle, the initial version must be `2.21.0` (@HannesWell am I right?),
Yes that would IMHO make sense. Backwards jumps in versions are quite bad for semantic-versioning.
> Unless I am mistaken the `uses` clause means: a `public` or `protected` member of a type in `org.apache.logging.log4j.message` has a type from `org.apache.logging.log4j.util` **in its signature** (`IndexedReadOnlyStringMap`).
I'm not sure how the list is assembled exactly, but since this is intended to ensure class-space consistency it could even be for internal classes. But since internal objects cannot be shared probably the rules you listed would make sense.
https://docs.osgi.org/specification/osgi.core/8.0.0/framework.module.html#i3127019
In order to manage the version per package there are `Version` annotations provided by OSGi that bnd can process:
https://docs.osgi.org/specification/osgi.core/8.0.0/framework.api.html#org.osgi.annotation.versioning.Version
Just in case you didn't know that already. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5 (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz closed pull request #1586: Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5
URL: https://github.com/apache/logging-log4j2/pull/1586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org