[jira] [Resolved] (HTRACE-32) Change span timeline annotations map to be a map

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HTRACE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Patrick McCabe resolved HTRACE-32.
----------------------------------------
       Resolution: Fixed
    Fix Version/s: 3.2.0

> Change span timeline annotations map to be a map<string, string>
> ----------------------------------------------------------------
>
>                 Key: HTRACE-32
>                 URL: https://issues.apache.org/jira/browse/HTRACE-32
>             Project: HTrace
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>             Fix For: 3.2.0
>
>         Attachments: HTRACE-32.001.patch
>
>
> We should consider changing the timeline annotations in Span.java to be a map<string, string> rather than a map<byte[], byte[]>.  It's very inconvenient to deal with byte arrays here, and every use-case we have currently puts string data into these fields.  One example is that you cannot look up fields in the map, since the map<byte[], byte[]> compares by byte array object equality (useless unless you have the original key array object you inserted).  It's also questionable if we could put non-string data in this map at all, since we are serializing them to JSON strings, which can't handle arbitrary byte strings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)