You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Nandann018-ux (via GitHub)" <gi...@apache.org> on 2026/02/25 07:06:07 UTC
[PR] Fix : Validate mapped task map_index bounds in task CLI [airflow]
Nandann018-ux opened a new pull request, #62454:
URL: https://github.com/apache/airflow/pull/62454
What changed
Added validation to reject out-of-range --map-index for mapped tasks in airflow tasks commands.
Added a unit test for tasks render to ensure out-of-range indexes raise TaskInstanceNotFound.
Added a newsfragment.
Why
Passing a map index beyond the mapped task count currently creates a TaskInstance that can never exist, leading to confusing behavior for CLI users. Validating bounds up front provides a clear, consistent error and avoids creating invalid rows.
Testing
Not run (should use breeze):
[test_task_command.py -xvs](app://-/index.html#)
Notes
Replace the 00000 in [00000.bugfix.rst](app://-/index.html#) with the actual PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix : Validate mapped task map_index bounds in task CLI [airflow]
Posted by "Nandann018-ux (via GitHub)" <gi...@apache.org>.
Nandann018-ux commented on PR #62454:
URL: https://github.com/apache/airflow/pull/62454#issuecomment-3982625579
@rozza Please review my pr , would like to contribute if any further changes are required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix : Validate mapped task map_index bounds in task CLI [airflow]
Posted by "Nandann018-ux (via GitHub)" <gi...@apache.org>.
Nandann018-ux commented on PR #62454:
URL: https://github.com/apache/airflow/pull/62454#issuecomment-4122937346
@potiuk Thanks for the note. I checked `main` and the map_index bounds validation + tests are already present there, so this PR is now redundant. I’m going to close #62454 to avoid duplication. The v3-1-test backport is tracked in #64133.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix : Validate mapped task map_index bounds in task CLI [airflow]
Posted by "Nandann018-ux (via GitHub)" <gi...@apache.org>.
Nandann018-ux commented on PR #62454:
URL: https://github.com/apache/airflow/pull/62454#issuecomment-4015766758
@uranusjr please check for changes made , kindly review and let me know if any changes are required.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix : Validate mapped task map_index bounds in task CLI [airflow]
Posted by "Nandann018-ux (via GitHub)" <gi...@apache.org>.
Nandann018-ux commented on PR #62454:
URL: https://github.com/apache/airflow/pull/62454#issuecomment-3983440504
Hi @uranusjr,
I’ve addressed the failed tests and re-ran them successfully.
Kindly review and let me know if there’s anything else I should modify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix : Validate mapped task map_index bounds in task CLI [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #62454:
URL: https://github.com/apache/airflow/pull/62454#issuecomment-3957269714
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix : Validate mapped task map_index bounds in task CLI [airflow]
Posted by "Nandann018-ux (via GitHub)" <gi...@apache.org>.
Nandann018-ux commented on PR #62454:
URL: https://github.com/apache/airflow/pull/62454#issuecomment-4034444017
@uranusjr kindly review and let me know if any changes are required.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix : Validate mapped task map_index bounds in task CLI [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #62454:
URL: https://github.com/apache/airflow/pull/62454#issuecomment-4039510558
@Nandann018-ux This PR has been converted to **draft** because it does not yet meet our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria).
**Issues found:**
- :x: **Merge conflicts**: This PR has merge conflicts with the `main` branch. Your branch is 357 commits behind `main`. Please rebase your branch (`git fetch origin && git rebase origin/main`), resolve the conflicts, and push again. See [contributing quick start](https://github.com/apache/airflow/blob/main/contributing-docs/03a_contributors_quick_start_beginners.rst).
> **Note:** Your branch is **357 commits behind `main`**. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.
**What to do next:**
- The comment informs you what you need to do.
- Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
- Maintainers will then proceed with a normal review.
Converting a PR to draft is **not** a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix : Validate mapped task map_index bounds in task CLI [airflow]
Posted by "Nandann018-ux (via GitHub)" <gi...@apache.org>.
Nandann018-ux closed pull request #62454: Fix : Validate mapped task map_index bounds in task CLI
URL: https://github.com/apache/airflow/pull/62454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org