You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "symious (via GitHub)" <gi...@apache.org> on 2024/05/08 09:49:10 UTC

[PR] RATIS-2081. Enable checkstyle for test source directory [ratis]

symious opened a new pull request, #1084:
URL: https://github.com/apache/ratis/pull/1084

   ## What changes were proposed in this pull request?
   
   Checkstyle is not checking test source directory. This ticket is to resolve this issue.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/RATIS-2081
   
   ## How was this patch tested?
   
   No need new tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2081. Enable checkstyle for test source directory [ratis]

Posted by "symious (via GitHub)" <gi...@apache.org>.
symious commented on PR #1084:
URL: https://github.com/apache/ratis/pull/1084#issuecomment-2116462321

   @szetszwo Updated the comment, PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2081. Comment that we skip checkstyle on test directory on purpose [ratis]

Posted by "symious (via GitHub)" <gi...@apache.org>.
symious commented on PR #1084:
URL: https://github.com/apache/ratis/pull/1084#issuecomment-2116466787

   @szetszwo Updated, thanks for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2081. Enable checkstyle for test source directory [ratis]

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1084:
URL: https://github.com/apache/ratis/pull/1084#issuecomment-2116464922

   @symious , could you also update the title?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2081. Comment that we skip checkstyle on test directory on purpose [ratis]

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo merged PR #1084:
URL: https://github.com/apache/ratis/pull/1084


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org