You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/02/09 01:51:17 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #19468: [build][io] Remove kafka-connect-avro-converter-shaded
tisonkun opened a new pull request, #19468:
URL: https://github.com/apache/pulsar/pull/19468
This can be a follow-up to #19010 and the original introduction PR is #6034.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [x] Dependencies (add or upgrade a dependency)
kafka-connect-avro-converter-shaded as a temporary hack is no longer needed.
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #19468: [improve][io] Remove kafka-connect-avro-converter-shaded
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19468:
URL: https://github.com/apache/pulsar/pull/19468#issuecomment-1423742183
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19468](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a89a2f) into [master](https://codecov.io/gh/apache/pulsar/commit/9ab9d0170a0a955875656d683839dd516c335bde?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ab9d01) will **increase** coverage by `0.43%`.
> The diff coverage is `65.03%`.
[](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19468 +/- ##
============================================
+ Coverage 63.20% 63.64% +0.43%
+ Complexity 3475 3474 -1
============================================
Files 1832 1832
Lines 134159 134144 -15
Branches 14763 14756 -7
============================================
+ Hits 84795 85370 +575
+ Misses 41642 40986 -656
- Partials 7722 7788 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.87% <51.79%> (+0.23%)` | :arrow_up: |
| systests | `25.46% <0.71%> (-0.12%)` | :arrow_down: |
| unittests | `61.05% <65.03%> (+0.63%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...r/io/kafka/connect/AbstractKafkaConnectSource.java](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWlvL2thZmthLWNvbm5lY3QtYWRhcHRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2lvL2thZmthL2Nvbm5lY3QvQWJzdHJhY3RLYWZrYUNvbm5lY3RTb3VyY2UuamF2YQ==) | `58.67% <ø> (ø)` | |
| [...he/pulsar/io/kafka/connect/KafkaConnectSource.java](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWlvL2thZmthLWNvbm5lY3QtYWRhcHRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2lvL2thZmthL2Nvbm5lY3QvS2Fma2FDb25uZWN0U291cmNlLmphdmE=) | `60.71% <ø> (ø)` | |
| [...nsaction/coordinator/TransactionMetadataStore.java](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLXRyYW5zYWN0aW9uL2Nvb3JkaW5hdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvdHJhbnNhY3Rpb24vY29vcmRpbmF0b3IvVHJhbnNhY3Rpb25NZXRhZGF0YVN0b3JlLmphdmE=) | `50.00% <ø> (ø)` | |
| [...oordinator/impl/InMemTransactionMetadataStore.java](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLXRyYW5zYWN0aW9uL2Nvb3JkaW5hdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvdHJhbnNhY3Rpb24vY29vcmRpbmF0b3IvaW1wbC9Jbk1lbVRyYW5zYWN0aW9uTWV0YWRhdGFTdG9yZS5qYXZh) | `72.88% <25.00%> (-3.91%)` | :arrow_down: |
| [...va/org/apache/pulsar/broker/service/ServerCnx.java](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1NlcnZlckNueC5qYXZh) | `55.45% <54.79%> (+0.47%)` | :arrow_up: |
| [...pulsar/broker/TransactionMetadataStoreService.java](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9UcmFuc2FjdGlvbk1ldGFkYXRhU3RvcmVTZXJ2aWNlLmphdmE=) | `60.75% <75.00%> (+2.06%)` | :arrow_up: |
| [...n/coordinator/impl/MLTransactionMetadataStore.java](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLXRyYW5zYWN0aW9uL2Nvb3JkaW5hdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvdHJhbnNhY3Rpb24vY29vcmRpbmF0b3IvaW1wbC9NTFRyYW5zYWN0aW9uTWV0YWRhdGFTdG9yZS5qYXZh) | `74.44% <75.00%> (-1.21%)` | :arrow_down: |
| [...che/pulsar/broker/admin/impl/TransactionsBase.java](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi9pbXBsL1RyYW5zYWN0aW9uc0Jhc2UuamF2YQ==) | `72.06% <100.00%> (+0.09%)` | :arrow_up: |
| [...lsar/common/policies/data/TransactionMetadata.java](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC1hZG1pbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9jb21tb24vcG9saWNpZXMvZGF0YS9UcmFuc2FjdGlvbk1ldGFkYXRhLmphdmE=) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
| [...g/apache/pulsar/common/protocol/PulsarHandler.java](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9wcm90b2NvbC9QdWxzYXJIYW5kbGVyLmphdmE=) | `60.34% <100.00%> (+3.44%)` | :arrow_up: |
| ... and [154 more](https://codecov.io/gh/apache/pulsar/pull/19468?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #19468: [improve][io] Remove kafka-connect-avro-converter-shaded
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #19468:
URL: https://github.com/apache/pulsar/pull/19468#issuecomment-1424183809
OWASP failed on stax2 which is unrelated to this patch I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #19468: [improve][io] Remove kafka-connect-avro-converter-shaded
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #19468:
URL: https://github.com/apache/pulsar/pull/19468#issuecomment-1423656098
OK. Found another shade class reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #19468: [improve][io] Remove kafka-connect-avro-converter-shaded
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #19468:
URL: https://github.com/apache/pulsar/pull/19468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #19468: [improve][io] Remove kafka-connect-avro-converter-shaded
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #19468:
URL: https://github.com/apache/pulsar/pull/19468#issuecomment-1423655342
Interesting. A steady unrelated test failure:
```
2023-02-09T05:21:31.9981562Z [ERROR] testDebeziumMySqlSourceAvro(org.apache.pulsar.tests.integration.io.sources.debezium.PulsarDebeziumSourcesTest) Time elapsed: 59.421 s <<< FAILURE!
2023-02-09T05:21:31.9982350Z java.lang.AssertionError: expected [1] but found [0]
2023-02-09T05:21:31.9983177Z at org.testng.Assert.fail(Assert.java:110)
2023-02-09T05:21:31.9983560Z at org.testng.Assert.failNotEquals(Assert.java:1413)
2023-02-09T05:21:31.9983926Z at org.testng.Assert.assertEqualsImpl(Assert.java:149)
2023-02-09T05:21:31.9984285Z at org.testng.Assert.assertEquals(Assert.java:131)
2023-02-09T05:21:31.9984627Z at org.testng.Assert.assertEquals(Assert.java:1240)
2023-02-09T05:21:31.9984973Z at org.testng.Assert.assertEquals(Assert.java:1274)
2023-02-09T05:21:31.9985580Z at org.apache.pulsar.tests.integration.io.sources.PulsarIOSourceRunner.getSourceStatus(PulsarIOSourceRunner.java:212)
2023-02-09T05:21:31.9987243Z at org.apache.pulsar.tests.integration.io.sources.debezium.PulsarIODebeziumSourceRunner.lambda$internalTestSource$0(PulsarIODebeziumSourceRunner.java:84)
2023-02-09T05:21:31.9988177Z at net.jodah.failsafe.Functions.lambda$toSupplier$10(Functions.java:262)
2023-02-09T05:21:31.9988574Z at net.jodah.failsafe.Functions.lambda$get$0(Functions.java:48)
2023-02-09T05:21:31.9989032Z at net.jodah.failsafe.RetryPolicyExecutor.lambda$supply$0(RetryPolicyExecutor.java:66)
2023-02-09T05:21:31.9989494Z at net.jodah.failsafe.Execution.executeSync(Execution.java:128)
2023-02-09T05:21:31.9989922Z at net.jodah.failsafe.FailsafeExecutor.call(FailsafeExecutor.java:379)
2023-02-09T05:21:31.9990391Z at net.jodah.failsafe.FailsafeExecutor.run(FailsafeExecutor.java:212)
2023-02-09T05:21:31.9991143Z at org.apache.pulsar.tests.integration.io.sources.debezium.PulsarIODebeziumSourceRunner.internalTestSource(PulsarIODebeziumSourceRunner.java:84)
2023-02-09T05:21:31.9992154Z at org.apache.pulsar.tests.integration.io.sources.debezium.PulsarIODebeziumSourceRunner.testSource(PulsarIODebeziumSourceRunner.java:66)
2023-02-09T05:21:31.9993162Z at org.apache.pulsar.tests.integration.io.sources.debezium.PulsarDebeziumSourcesTest.testDebeziumMySqlConnect(PulsarDebeziumSourcesTest.java:130)
2023-02-09T05:21:31.9994240Z at org.apache.pulsar.tests.integration.io.sources.debezium.PulsarDebeziumSourcesTest.testDebeziumMySqlSourceAvro(PulsarDebeziumSourcesTest.java:63)
2023-02-09T05:21:31.9995045Z at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2023-02-09T05:21:31.9995609Z at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
2023-02-09T05:21:31.9996233Z at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2023-02-09T05:21:31.9996744Z at java.base/java.lang.reflect.Method.invoke(Method.java:568)
2023-02-09T05:21:31.9997596Z at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:139)
2023-02-09T05:21:31.9998206Z at org.testng.internal.invokers.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:47)
2023-02-09T05:21:31.9998769Z at org.testng.internal.invokers.InvokeMethodRunnable.call(InvokeMethodRunnable.java:76)
2023-02-09T05:21:31.9999327Z at org.testng.internal.invokers.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
2023-02-09T05:21:31.9999810Z at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
2023-02-09T05:21:32.0000294Z at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
2023-02-09T05:21:32.0000827Z at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
2023-02-09T05:21:32.0001240Z at java.base/java.lang.Thread.run(Thread.java:833)
2023-02-09T05:21:32.0001426Z
```
May revisit or rerun later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org