You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:18:55 UTC
[GitHub] [arrow] tobim opened a new pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
tobim opened a new pull request #7842:
URL: https://github.com/apache/arrow/pull/7842
Continuation of #7813.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-669764587
Thanks for testing this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-671105008
Thanks @tobim!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667794158
Revision: d34763c65d5dd69f990f97d0a0a8787f4c8c425b
Submitted crossbow builds: [ursa-labs/crossbow @ actions-456](https://github.com/ursa-labs/crossbow/branches/all?query=actions-456)
|Task|Status|
|----|------|
|centos-6-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-456-github-centos-6-amd64)|
|centos-7-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-7-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-456-github-centos-7-amd64)|
|centos-8-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-8-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-456-github-centos-8-amd64)|
|debian-buster-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-456-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|debian-stretch-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-456-github-debian-stretch-amd64)|
|debian-stretch-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|example-cpp-minimal-build-static|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-456-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-456-github-example-cpp-minimal-build-static-system-dependency)|
|ubuntu-bionic-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-456-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-eoan-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-456-github-ubuntu-eoan-amd64)|
|ubuntu-eoan-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-456-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-xenial-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-456-github-ubuntu-xenial-amd64)|
|ubuntu-xenial-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667793688
@github-actions crossbow submit -g example -g linux
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667777693
@github-actions crossbow submit -g nightly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667836959
@github-actions crossbow submit centos-* wheel-win-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#discussion_r464009266
##########
File path: cpp/cmake_modules/Findzstd.cmake
##########
@@ -54,10 +54,11 @@ else()
if(ZSTD_PC_FOUND)
set(ZSTD_INCLUDE_DIR "${ZSTD_PC_INCLUDEDIR}")
- if(NOT ARROW_ZSTD_USE_SHARED)
+ if(ARROW_ZSTD_USE_SHARED)
+ list(APPEND ZSTD_PC_LIBRARY_DIRS "${ZSTD_PC_LIBDIR}")
+ else()
Review comment:
It seems that `XXX_STATIC_LIBDIR` is never defined: https://github.com/Kitware/CMake/blob/master/Modules/FindPkgConfig.cmake#L566
`_pkg_get_variable` doesn't set `XXX_STATIC_YYY`: https://github.com/Kitware/CMake/blob/master/Modules/FindPkgConfig.cmake#L566
(`XXX_LIBDIR` is only defined.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#discussion_r462613619
##########
File path: cpp/src/arrow/ArrowConfig.cmake.in
##########
@@ -38,45 +38,42 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowOptions.cmake")
include(CMakeFindDependencyMacro)
-if(ARROW_USE_STATIC)
- set(LIB_PATH_SUFFIXES
- "${CMAKE_LIBRARY_ARCHITECTURE}"
- "lib/${CMAKE_LIBRARY_ARCHITECTURE}"
- "lib64"
- "lib32"
- "lib"
- "bin"
- "Library"
- "Library/lib"
- "Library/bin")
- set(INCLUDE_PATH_SUFFIXES "include" "Library" "Library/include")
-
- set(CMAKE_THREAD_PREFER_PTHREAD TRUE)
- set(THREADS_PREFER_PTHREAD_FLAG TRUE)
- find_dependency(Threads)
-
- if(DEFINED CMAKE_MODULE_PATH)
- set(_CMAKE_MODULE_PATH_OLD ${CMAKE_MODULE_PATH})
- endif()
- set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}")
-
-@ARROW_FIND_DEPENDENCY_LIST@
-
- if(DEFINED _CMAKE_MODULE_PATH_OLD)
- set(CMAKE_MODULE_PATH ${_CMAKE_MODULE_PATH_OLD})
- unset(_CMAKE_MODULE_PATH_OLD)
- else()
- unset(CMAKE_MODULE_PATH)
- endif()
-endif()
-
-
# Load targets only once. If we load targets multiple times, CMake reports
# already existent target error.
if(NOT (TARGET arrow_shared OR TARGET arrow_static))
include("${CMAKE_CURRENT_LIST_DIR}/ArrowTargets.cmake")
if(TARGET arrow_static)
+ set(LIB_PATH_SUFFIXES
Review comment:
Yes. Is it strange?
Do you know a CMake convention when a CMake package provides both shard and static libraries?
Do users need to specify "we want to use static library" explicitly?
Should we use the `COMPONENTS` feature in `find_package`?
##########
File path: cpp/cmake_modules/FindLz4.cmake
##########
@@ -24,13 +24,14 @@ set(LZ4_STATIC_LIB_SUFFIX "${LZ4_MSVC_STATIC_LIB_SUFFIX}${CMAKE_STATIC_LIBRARY_S
set(LZ4_LIB_NAMES lz4 liblz4)
if(NOT ARROW_LZ4_USE_SHARED)
+ set(static_names_)
Review comment:
If someone defines `static_name_` before calling `FindLz4.cmake`, the `static_name_` value is used.
Is it wrong?
##########
File path: cpp/cmake_modules/Findzstd.cmake
##########
@@ -54,10 +54,11 @@ else()
if(ZSTD_PC_FOUND)
set(ZSTD_INCLUDE_DIR "${ZSTD_PC_INCLUDEDIR}")
- if(NOT ARROW_ZSTD_USE_SHARED)
+ if(ARROW_ZSTD_USE_SHARED)
+ list(APPEND ZSTD_PC_LIBRARY_DIRS "${ZSTD_PC_LIBDIR}")
+ else()
Review comment:
Oh...
Could you show one of the libzstd.pc versions environment? I want to try it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-665350733
Thanks.
I can push the branch.
I'm still working on this. Please wait for a while.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-664661594
https://issues.apache.org/jira/browse/ARROW-9412
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667778103
Revision: 1bc156e6e5a582f15d73a848153a578461c523dd
Submitted crossbow builds: [ursa-labs/crossbow @ actions-454](https://github.com/ursa-labs/crossbow/branches/all?query=actions-454)
|Task|Status|
|----|------|
|centos-6-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-centos-6-amd64)|
|centos-7-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-7-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-centos-7-amd64)|
|centos-8-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-8-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-centos-8-amd64)|
|conda-clean|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-conda-clean)|
|conda-linux-gcc-py36-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-conda-linux-gcc-py36-cpu)|
|conda-linux-gcc-py36-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-conda-linux-gcc-py36-cuda)|
|conda-linux-gcc-py37-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-conda-linux-gcc-py37-cpu)|
|conda-linux-gcc-py37-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-conda-linux-gcc-py37-cuda)|
|conda-linux-gcc-py38-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-conda-linux-gcc-py38-cpu)|
|conda-linux-gcc-py38-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-conda-linux-gcc-py38-cuda)|
|conda-osx-clang-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-conda-osx-clang-py36)|
|conda-osx-clang-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-conda-osx-clang-py37)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-conda-osx-clang-py38)|
|conda-win-vs2017-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-conda-win-vs2017-py36)|
|conda-win-vs2017-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-conda-win-vs2017-py37)|
|conda-win-vs2017-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-conda-win-vs2017-py38)|
|debian-buster-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|debian-stretch-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-debian-stretch-amd64)|
|debian-stretch-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|example-cpp-minimal-build-static|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-example-cpp-minimal-build-static-system-dependency)|
|gandiva-jar-osx|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|gandiva-jar-xenial|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|homebrew-cpp|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|homebrew-r-autobrew|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|nuget|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-nuget)|
|test-conda-cpp|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-cpp-valgrind)|
|test-conda-python-3.6|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.6)|
|test-conda-python-3.6-pandas-0.23|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.6-pandas-0.23)|
|test-conda-python-3.7|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.7)|
|test-conda-python-3.7-dask-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.7-dask-latest)|
|test-conda-python-3.7-hdfs-2.9.2|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.7-hdfs-2.9.2)|
|test-conda-python-3.7-kartothek-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.7-kartothek-latest)|
|test-conda-python-3.7-kartothek-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.7-kartothek-master)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.7-pandas-latest)|
|test-conda-python-3.7-pandas-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.7-pandas-master)|
|test-conda-python-3.7-spark-branch-3.0|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.7-spark-branch-3.0)|
|test-conda-python-3.7-turbodbc-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.7-turbodbc-latest)|
|test-conda-python-3.7-turbodbc-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.7-turbodbc-master)|
|test-conda-python-3.8|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.8)|
|test-conda-python-3.8-dask-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.8-dask-master)|
|test-conda-python-3.8-jpype|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.8-jpype)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.8-pandas-latest)|
|test-conda-python-3.8-spark-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-python-3.8-spark-master)|
|test-conda-r-4.0|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-conda-r-4.0)|
|test-debian-10-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-454-circle-test-debian-10-cpp)|
|test-debian-10-go-1.12|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-debian-10-go-1.12)|
|test-debian-10-python-3|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-debian-10-python-3)|
|test-debian-c-glib|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-454-circle-test-debian-c-glib)|
|test-debian-ruby|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-454-circle-test-debian-ruby)|
|test-fedora-32-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-454-circle-test-fedora-32-cpp)|
|test-fedora-32-python-3|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-fedora-32-python-3)|
|test-r-linux-as-cran|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-r-linux-as-cran)|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-ubuntu-16.04-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-454-circle-test-ubuntu-16.04-cpp)|
|test-ubuntu-18.04-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-454-circle-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-cmake32|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-454-circle-test-ubuntu-18.04-cpp-cmake32)|
|test-ubuntu-18.04-cpp-release|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-454-circle-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-454-circle-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-18.04-docs|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-ubuntu-18.04-docs)|
|test-ubuntu-18.04-python-3|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-ubuntu-18.04-python-3)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-ubuntu-18.04-r-sanitizer)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-c-glib|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-454-circle-test-ubuntu-c-glib)|
|test-ubuntu-ruby|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-test-ubuntu-ruby)|
|ubuntu-bionic-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-eoan-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-ubuntu-eoan-amd64)|
|ubuntu-eoan-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-xenial-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-454-github-ubuntu-xenial-amd64)|
|ubuntu-xenial-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-manylinux1-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-wheel-manylinux1-cp35m)|
|wheel-manylinux1-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-wheel-manylinux1-cp36m)|
|wheel-manylinux1-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-wheel-manylinux1-cp37m)|
|wheel-manylinux1-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-wheel-manylinux1-cp38)|
|wheel-manylinux2010-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-wheel-manylinux2010-cp35m)|
|wheel-manylinux2010-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-wheel-manylinux2010-cp36m)|
|wheel-manylinux2010-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-wheel-manylinux2010-cp37m)|
|wheel-manylinux2010-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-wheel-manylinux2010-cp38)|
|wheel-manylinux2014-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-wheel-manylinux2014-cp35m)|
|wheel-manylinux2014-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-wheel-manylinux2014-cp36m)|
|wheel-manylinux2014-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-wheel-manylinux2014-cp37m)|
|wheel-manylinux2014-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-454-azure-wheel-manylinux2014-cp38)|
|wheel-osx-cp35m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-win-cp35m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp36m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] tobim commented on a change in pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
tobim commented on a change in pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#discussion_r466201256
##########
File path: cpp/cmake_modules/FindSnappy.cmake
##########
@@ -15,25 +15,33 @@
# specific language governing permissions and limitations
# under the License.
+set(SNAPPY_STATIC_LIB_SUFFIX "${SNAPPY_MSVC_STATIC_LIB_SUFFIX}${CMAKE_STATIC_LIBRARY_SUFFIX}")
Review comment:
Thanks for double-checking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] tobim commented on a change in pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
tobim commented on a change in pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#discussion_r462285704
##########
File path: cpp/cmake_modules/FindLz4.cmake
##########
@@ -24,13 +24,14 @@ set(LZ4_STATIC_LIB_SUFFIX "${LZ4_MSVC_STATIC_LIB_SUFFIX}${CMAKE_STATIC_LIBRARY_S
set(LZ4_LIB_NAMES lz4 liblz4)
if(NOT ARROW_LZ4_USE_SHARED)
+ set(static_names_)
Review comment:
This is not necessary.
##########
File path: cpp/src/arrow/ArrowConfig.cmake.in
##########
@@ -38,45 +38,42 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowOptions.cmake")
include(CMakeFindDependencyMacro)
-if(ARROW_USE_STATIC)
- set(LIB_PATH_SUFFIXES
- "${CMAKE_LIBRARY_ARCHITECTURE}"
- "lib/${CMAKE_LIBRARY_ARCHITECTURE}"
- "lib64"
- "lib32"
- "lib"
- "bin"
- "Library"
- "Library/lib"
- "Library/bin")
- set(INCLUDE_PATH_SUFFIXES "include" "Library" "Library/include")
-
- set(CMAKE_THREAD_PREFER_PTHREAD TRUE)
- set(THREADS_PREFER_PTHREAD_FLAG TRUE)
- find_dependency(Threads)
-
- if(DEFINED CMAKE_MODULE_PATH)
- set(_CMAKE_MODULE_PATH_OLD ${CMAKE_MODULE_PATH})
- endif()
- set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}")
-
-@ARROW_FIND_DEPENDENCY_LIST@
-
- if(DEFINED _CMAKE_MODULE_PATH_OLD)
- set(CMAKE_MODULE_PATH ${_CMAKE_MODULE_PATH_OLD})
- unset(_CMAKE_MODULE_PATH_OLD)
- else()
- unset(CMAKE_MODULE_PATH)
- endif()
-endif()
-
-
# Load targets only once. If we load targets multiple times, CMake reports
# already existent target error.
if(NOT (TARGET arrow_shared OR TARGET arrow_static))
include("${CMAKE_CURRENT_LIST_DIR}/ArrowTargets.cmake")
if(TARGET arrow_static)
+ set(LIB_PATH_SUFFIXES
Review comment:
This change means that the static dependencies need to be resolved even if `arrow_static` is never used.
##########
File path: cpp/cmake_modules/Findzstd.cmake
##########
@@ -54,10 +54,11 @@ else()
if(ZSTD_PC_FOUND)
set(ZSTD_INCLUDE_DIR "${ZSTD_PC_INCLUDEDIR}")
- if(NOT ARROW_ZSTD_USE_SHARED)
+ if(ARROW_ZSTD_USE_SHARED)
+ list(APPEND ZSTD_PC_LIBRARY_DIRS "${ZSTD_PC_LIBDIR}")
+ else()
Review comment:
Some libzstd.pc versions are written in a way that only ${ZSTD_PC_STATIC_LIBDIR} contains a path. I started out with essentially this, but it didn't work during testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667805956
@github-actions crossbow submit -g linux wheel-win-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667806486
Revision: 0cb21e889c61253ebeafde46de9989c553c62c32
Submitted crossbow builds: [ursa-labs/crossbow @ actions-457](https://github.com/ursa-labs/crossbow/branches/all?query=actions-457)
|Task|Status|
|----|------|
|centos-6-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-457-github-centos-6-amd64)|
|centos-7-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-7-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-457-github-centos-7-amd64)|
|centos-8-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-8-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-457-github-centos-8-amd64)|
|debian-buster-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-457-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|debian-stretch-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-457-github-debian-stretch-amd64)|
|debian-stretch-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-bionic-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-457-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-eoan-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-457-github-ubuntu-eoan-amd64)|
|ubuntu-eoan-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-457-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-xenial-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-457-github-ubuntu-xenial-amd64)|
|ubuntu-xenial-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-win-cp35m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp36m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] tobim commented on a change in pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
tobim commented on a change in pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#discussion_r466202760
##########
File path: cpp/cmake_modules/FindSnappy.cmake
##########
@@ -15,25 +15,33 @@
# specific language governing permissions and limitations
# under the License.
+set(SNAPPY_STATIC_LIB_SUFFIX "${SNAPPY_MSVC_STATIC_LIB_SUFFIX}${CMAKE_STATIC_LIBRARY_SUFFIX}")
+
+if(ARROW_SNAPPY_USE_SHARED)
+ set(SNAPPY_LIB_NAMES snappy)
+else()
+ set(SNAPPY_LIB_NAMES "${CMAKE_STATIC_LIBRARY_PREFIX}snappy${SNAPPY_STATIC_LIB_SUFFIX}" snappy)
+endif()
+
if(Snappy_ROOT)
find_library(Snappy_LIB
- NAMES snappy
+ NAMES ${SNAPPY_LIB_NAMES}
PATHS ${Snappy_ROOT}
- PATH_SUFFIXES ${LIB_PATH_SUFFIXES}
+ PATH_SUFFIXES ${ARROW_LIBRARY_PATH_SUFFIXES}
NO_DEFAULT_PATH)
find_path(Snappy_INCLUDE_DIR
NAMES snappy.h
PATHS ${Snappy_ROOT}
NO_DEFAULT_PATH
- PATH_SUFFIXES ${INCLUDE_PATH_SUFFIXES})
+ PATH_SUFFIXES ${ARROW_INCLUDE_PATH_SUFFIXES})
else()
- find_library(Snappy_LIB NAMES snappy)
- find_path(Snappy_INCLUDE_DIR NAMES snappy.h PATH_SUFFIXES ${INCLUDE_PATH_SUFFIXES})
+ find_library(Snappy_LIB NAMES ${SNAPPY_LIB_NAMES} HINTS "${CMAKE_ROOT}/Modules/")
Review comment:
I don't remember why I added this. It was probably a conversion error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] tobim commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
tobim commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-669758390
@kou thank you for seeing this through!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] tobim commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
tobim commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-669758096
I just tested this overnight and luckily everything works for my needs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
kou closed pull request #7842:
URL: https://github.com/apache/arrow/pull/7842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667837678
Revision: 5617d5b27041a8c4beba8cd4e29d0f0c5929c17d
Submitted crossbow builds: [ursa-labs/crossbow @ actions-459](https://github.com/ursa-labs/crossbow/branches/all?query=actions-459)
|Task|Status|
|----|------|
|centos-6-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-459-github-centos-6-amd64)|
|centos-7-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-7-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-459-github-centos-7-amd64)|
|centos-8-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-8-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-459-github-centos-8-amd64)|
|wheel-win-cp35m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp36m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667789090
@tobim Most of changes are done. I'm working on the last check. Could you confirm the current code and the updated PR description? If the last check is done and addressed your feedback, I'll merge this.
Here are summary of my changes https://github.com/apache/arrow/compare/76b4b022179f94bdb5b77086acf253b6a7bcbbe9...3aed2131e18a7f9db00cd446fc887d78e777686a :
* Export `ARROW_LIBRARY_PATH_SUFFIXES` and `ARROW_INCLUDE_PATH_SUFFIXES` to `ArrowConfig.cmake` instead of copying definitions of `LIB_PATH_SUFFIXES` and `INCLUDE_PATH_SUFFIXES`.
* Rename `ARROW_USE_SHARED_SYSTEM_LIBS` to `ARROW_DEPENDENCY_USE_SHARED` because we already have `ARROW_DEPENDENCY_SOURCE` option that is the default value of `*_SOURCE`.
* Don't use `ARROW_DEPENDENCY_USE_SHARED` as the default value of `ARROW_THRIFT_USE_SHARED_DEFAULT` on Windows because it seems that Thrift's DLL support isn't well for now.
* Use more strict library names for LZ4, ZStandard, Snappy, Thrift and utf8proc. I confirmed library names of them on WIndows by provided binaries and build configuration files of them.
* Use only package names (`ARROW_SYSTEM_DEPENDENCIES`) instead of `find_dependency(...)` (`ARROW_FIND_DEPENDENCY_LIST`) to provide `find_dependency()` list to `ArrowConfig.cmake` because it'll be simpler.
* Use Docker Compose instead of raw Docker in `cpp/examples/minimal_build/` to manage multiple build configurations.
* I split one `Dockerfile` that contains `*-dev` packages to `Dockerfile` with/without `*-dev` packages to show our build system uses bundled libraries for nonexistent dependencies by default.
The AppVeyor failure is unrelated: https://issues.apache.org/jira/browse/ARROW-9621
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#discussion_r463288078
##########
File path: cpp/cmake_modules/FindSnappy.cmake
##########
@@ -15,25 +15,33 @@
# specific language governing permissions and limitations
# under the License.
+set(SNAPPY_STATIC_LIB_SUFFIX "${SNAPPY_MSVC_STATIC_LIB_SUFFIX}${CMAKE_STATIC_LIBRARY_SUFFIX}")
Review comment:
Is this needed?
It seems that Snappy doesn't add any suffix for MSVC: https://github.com/google/snappy/blob/master/CMakeLists.txt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#discussion_r463290240
##########
File path: cpp/cmake_modules/FindSnappy.cmake
##########
@@ -15,25 +15,33 @@
# specific language governing permissions and limitations
# under the License.
+set(SNAPPY_STATIC_LIB_SUFFIX "${SNAPPY_MSVC_STATIC_LIB_SUFFIX}${CMAKE_STATIC_LIBRARY_SUFFIX}")
+
+if(ARROW_SNAPPY_USE_SHARED)
+ set(SNAPPY_LIB_NAMES snappy)
+else()
+ set(SNAPPY_LIB_NAMES "${CMAKE_STATIC_LIBRARY_PREFIX}snappy${SNAPPY_STATIC_LIB_SUFFIX}" snappy)
+endif()
+
if(Snappy_ROOT)
find_library(Snappy_LIB
- NAMES snappy
+ NAMES ${SNAPPY_LIB_NAMES}
PATHS ${Snappy_ROOT}
- PATH_SUFFIXES ${LIB_PATH_SUFFIXES}
+ PATH_SUFFIXES ${ARROW_LIBRARY_PATH_SUFFIXES}
NO_DEFAULT_PATH)
find_path(Snappy_INCLUDE_DIR
NAMES snappy.h
PATHS ${Snappy_ROOT}
NO_DEFAULT_PATH
- PATH_SUFFIXES ${INCLUDE_PATH_SUFFIXES})
+ PATH_SUFFIXES ${ARROW_INCLUDE_PATH_SUFFIXES})
else()
- find_library(Snappy_LIB NAMES snappy)
- find_path(Snappy_INCLUDE_DIR NAMES snappy.h PATH_SUFFIXES ${INCLUDE_PATH_SUFFIXES})
+ find_library(Snappy_LIB NAMES ${SNAPPY_LIB_NAMES} HINTS "${CMAKE_ROOT}/Modules/")
Review comment:
Could you explain why the `HINTS` is needed?
I don't think that `libsnappy.so` exists in `${CMAKE_ROOT}/Modules/`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org