[jira] Commented: (HADOOP-6373) adding delegation token implementation

["Owen O'Malley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784659#action_12784659 ] 

Owen O'Malley commented on HADOOP-6373:
---------------------------------------

The generic parts of this should be done as MAPREDUCE-1250.

Comments on the patch:
1. The algorithm name should be protected not public.
2. The key generator should be a non-static field and the method should synchronize on the key generator.
3. In JobTokenSecretManager, the secret key should not be a static, but a non-static field.
4. Don't bother with the WritableFactory for DelegationTokenIdentifier.
5. The generic interface should be in common in org.apache.hadoop.security.token.
6. Delegation tokens should be in HDFS in org.apache.hadoop.hdfs.security.token.delegation.
7. Job tokens should in in MapReduce in org.apache.hadoop.mapreduce.security.token.job.
8. The thread should catch Throwable at the top level and stop the server.
9. The thread should catch InterruptedException at the top level and return immediately.
10. activate should be startThreads() and stopTokenReceiver should be stopThreads()
11. Keep the SecretKey details in the the various SecretManagers rather than spreading them out.

> adding delegation token implementation
> --------------------------------------
>
>                 Key: HADOOP-6373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6373
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: partial1.patch, token.patch, token2.patch
>
>
> The over-all design of delegation token is given in HADOOP-4343. This subtask is for detailed design and implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.