You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/28 16:08:36 UTC
[GitHub] [spark] cloud-fan opened a new pull request, #38039: [SPARK-40603][SQL] Throw the original error from catalog implementations
cloud-fan opened a new pull request, #38039:
URL: https://github.com/apache/spark/pull/38039
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Currently, Spark swallows the error thrown by catalog implementations, and re-throws a standard error. However, the original error from catalog implementations could be better and contain more internal information. It's better to still throw the original error.
This PR adds a new field `lookupError: Option[Throwable]` in `UnresolvedRelation` to hold the original error. We don't fail immediately as other rules (`ResolveSQLOnFile`) may be able to resolve it later. For all other cases, we can fail immediately with the original error.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
better error message
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #38039: [SPARK-40603][SQL] Throw the original error from catalog implementations
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #38039: [SPARK-40603][SQL] Throw the original error from catalog implementations
URL: https://github.com/apache/spark/pull/38039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #38039: [SPARK-40603][SQL] Throw the original error from catalog implementations
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #38039:
URL: https://github.com/apache/spark/pull/38039#issuecomment-1382601655
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38039: [SPARK-40603][SQL] Throw the original error from catalog implementations
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38039:
URL: https://github.com/apache/spark/pull/38039#discussion_r985129333
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -126,26 +126,11 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog {
throw new IllegalStateException(
"[BUG] logical plan should not have output of char/varchar type: " + leaf)
- case u: UnresolvedNamespace =>
- u.failAnalysis(s"Namespace not found: ${u.multipartIdentifier.quoted}")
-
- case u: UnresolvedTable =>
- u.failAnalysis(s"Table not found: ${u.multipartIdentifier.quoted}")
-
- case u: UnresolvedView =>
- u.failAnalysis(s"View not found: ${u.multipartIdentifier.quoted}")
-
- case u: UnresolvedTableOrView =>
- val viewStr = if (u.allowTempView) "view" else "permanent view"
- u.failAnalysis(
- s"Table or $viewStr not found: ${u.multipartIdentifier.quoted}")
Review Comment:
I am thinking this is because now we throw the exceptions from catalog implementation thus such unresolved namespace/table/view/function will be caught already in the earlier stage. So literally this PR moves to a fail-fast approach.
This makes sense to me as the giant `CheckAnalysis` sometime cannot give the error message I expect as there is an ordering of error check here. `Fail-fast` and `Fail-at-right-place` can improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on pull request #38039: [SPARK-40603][SQL] Throw the original error from catalog implementations
Posted by GitBox <gi...@apache.org>.
srielau commented on PR #38039:
URL: https://github.com/apache/spark/pull/38039#issuecomment-1264370831
This PR collides with:
https://github.com/apache/spark/pull/37887
@wenchen @MaxGekk Can we please get this one through first? Having that PR linger causes lots of duplicate and conflicting work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #38039: [SPARK-40603][SQL] Throw the original error from catalog implementations
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #38039:
URL: https://github.com/apache/spark/pull/38039#discussion_r985051937
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -126,26 +126,11 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog {
throw new IllegalStateException(
"[BUG] logical plan should not have output of char/varchar type: " + leaf)
- case u: UnresolvedNamespace =>
- u.failAnalysis(s"Namespace not found: ${u.multipartIdentifier.quoted}")
-
- case u: UnresolvedTable =>
- u.failAnalysis(s"Table not found: ${u.multipartIdentifier.quoted}")
-
- case u: UnresolvedView =>
- u.failAnalysis(s"View not found: ${u.multipartIdentifier.quoted}")
-
- case u: UnresolvedTableOrView =>
- val viewStr = if (u.allowTempView) "view" else "permanent view"
- u.failAnalysis(
- s"Table or $viewStr not found: ${u.multipartIdentifier.quoted}")
Review Comment:
Why removing these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #38039: [SPARK-40603][SQL] Throw the original error from catalog implementations
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #38039:
URL: https://github.com/apache/spark/pull/38039#issuecomment-1261135792
cc @MaxGekk @srielau @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #38039: [SPARK-40603][SQL] Throw the original error from catalog implementations
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #38039:
URL: https://github.com/apache/spark/pull/38039#discussion_r985053380
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1139,36 +1140,33 @@ class Analyzer(override val catalogManager: CatalogManager)
*/
private def lookupTableOrView(
identifier: Seq[String],
- viewOnly: Boolean = false): Option[LogicalPlan] = {
+ viewOnly: Boolean = false): LogicalPlan = {
Review Comment:
Hmm, so if `lookupTableOrView` cannot resolve the table/view, it directly throws an exception now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #38039: [SPARK-40603][SQL] Throw the original error from catalog implementations
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #38039:
URL: https://github.com/apache/spark/pull/38039#discussion_r982967471
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##########
@@ -167,9 +172,13 @@ default boolean tableExists(Identifier ident) {
* @param partitions transforms to use for partitioning data in the table
* @param properties a string map of table properties
* @return metadata for the new table
- * @throws TableAlreadyExistsException If a table or view already exists for the identifier
+ * @throws TableAlreadyExistsException If a table or view already exists for the identifier. The
+ * error message should contain the qualified table name,
Review Comment:
qq: maybe it should be "qualified table or view name" ?
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##########
@@ -167,9 +172,13 @@ default boolean tableExists(Identifier ident) {
* @param partitions transforms to use for partitioning data in the table
* @param properties a string map of table properties
* @return metadata for the new table
- * @throws TableAlreadyExistsException If a table or view already exists for the identifier
+ * @throws TableAlreadyExistsException If a table or view already exists for the identifier. The
+ * error message should contain the qualified table name,
+ * including the catalog name.
* @throws UnsupportedOperationException If a requested partition transform is not supported
- * @throws NoSuchNamespaceException If the identifier namespace does not exist (optional)
+ * @throws NoSuchNamespaceException If the identifier namespace does not exist (optional). The
+ * error message should contain the qualified table name,
Review Comment:
qq: Maybe "qualified namespace name" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38039: [SPARK-40603][SQL] Throw the original error from catalog implementations
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38039:
URL: https://github.com/apache/spark/pull/38039#discussion_r985129531
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala:
##########
@@ -45,7 +45,8 @@ class UnresolvedException(function: String)
case class UnresolvedRelation(
multipartIdentifier: Seq[String],
options: CaseInsensitiveStringMap = CaseInsensitiveStringMap.empty(),
- override val isStreaming: Boolean = false)
+ override val isStreaming: Boolean = false,
+ lookupError: Option[Throwable] = None)
Review Comment:
I might have missing context here: why we only add `lookupError` for relation but not on other function/namespace, etc.?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org