You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Ian Clelland <ic...@chromium.org> on 2013/07/17 15:20:41 UTC

Review Request 12668: Unified whitelist implementation for iOS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12668/
-----------------------------------------------------------

Review request for cordova.


Repository: cordova-ios


Description
-------

CB-4095: This implements the new unified whitelist for iOS. 


Diffs
-----

  CordovaLib/Classes/CDVConfigParser.m c06b7f7 
  CordovaLib/Classes/CDVWhitelist.m e6807bd 

Diff: https://reviews.apache.org/r/12668/diff/


Testing
-------

All mobilespec whitelist-related tests pass with this implementation


Thanks,

Ian Clelland

Re: Review Request 12668: Unified whitelist implementation for iOS

Posted by Ian Clelland <ic...@chromium.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12668/
-----------------------------------------------------------

(Updated July 17, 2013, 3:50 p.m.)


Review request for cordova.


Changes
-------

Updating diff based on review comments


Repository: cordova-ios


Description
-------

CB-4095: This implements the new unified whitelist for iOS. 


Diffs (updated)
-----

  CordovaLib/Classes/CDVConfigParser.m c06b7f7 
  CordovaLib/Classes/CDVWhitelist.m e6807bd 

Diff: https://reviews.apache.org/r/12668/diff/


Testing
-------

All mobilespec whitelist-related tests pass with this implementation


Thanks,

Ian Clelland

Re: Review Request 12668: Unified whitelist implementation for iOS

Posted by Ian Clelland <ic...@chromium.org>.

> On July 17, 2013, 3:05 p.m., Andrew Grieve wrote:
> > CordovaLib/Classes/CDVWhitelist.m, line 174
> > <https://reviews.apache.org/r/12668/diff/1/?file=322547#file322547line174>
> >
> >     why remove? maybe at least replace with a comment.

Removed because (whitelist==nil) is now the condition under which all urls are *allowed*.

The diff is matching similar-looking lines, but what used to be a runtime check that 'nil' wasn't passed in to the init method is now a shortcut return on addWhiteListEntry in case "*" has already been encountered.

I can still log that on initWithArray in the case that array is nil, but I don't think that this can happen in a real application now. (At the very least, the CDVConfigParser will add a three url patterns to any new config).


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12668/#review23280
-----------------------------------------------------------


On July 17, 2013, 1:20 p.m., Ian Clelland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12668/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 1:20 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Repository: cordova-ios
> 
> 
> Description
> -------
> 
> CB-4095: This implements the new unified whitelist for iOS. 
> 
> 
> Diffs
> -----
> 
>   CordovaLib/Classes/CDVConfigParser.m c06b7f7 
>   CordovaLib/Classes/CDVWhitelist.m e6807bd 
> 
> Diff: https://reviews.apache.org/r/12668/diff/
> 
> 
> Testing
> -------
> 
> All mobilespec whitelist-related tests pass with this implementation
> 
> 
> Thanks,
> 
> Ian Clelland
> 
>

Re: Review Request 12668: Unified whitelist implementation for iOS

Posted by Andrew Grieve <ag...@chromium.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12668/#review23280
-----------------------------------------------------------



CordovaLib/Classes/CDVWhitelist.m
<https://reviews.apache.org/r/12668/#comment47169>

    Instead of using properties, use fields:
    
    @interface CDVWhitelistPattern : NSObject {
     @private
      NSRegularExpression* scheme;
    }
    
    Don't forget to run this through uncrustify before committing (bin/uncrustify.sh)



CordovaLib/Classes/CDVWhitelist.m
<https://reviews.apache.org/r/12668/#comment47170>

    why remove? maybe at least replace with a comment.



CordovaLib/Classes/CDVWhitelist.m
<https://reviews.apache.org/r/12668/#comment47171>

    initialize these to nil.


- Andrew Grieve


On July 17, 2013, 1:20 p.m., Ian Clelland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12668/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 1:20 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Repository: cordova-ios
> 
> 
> Description
> -------
> 
> CB-4095: This implements the new unified whitelist for iOS. 
> 
> 
> Diffs
> -----
> 
>   CordovaLib/Classes/CDVConfigParser.m c06b7f7 
>   CordovaLib/Classes/CDVWhitelist.m e6807bd 
> 
> Diff: https://reviews.apache.org/r/12668/diff/
> 
> 
> Testing
> -------
> 
> All mobilespec whitelist-related tests pass with this implementation
> 
> 
> Thanks,
> 
> Ian Clelland
> 
>