You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2016/06/19 06:10:50 UTC

svn commit: r1749131 - in /poi/trunk/src/ooxml: java/org/apache/poi/xssf/usermodel/XSSFDataValidationConstraint.java testcases/org/apache/poi/xssf/usermodel/TestXSSFDataValidationConstraint.java

Author: onealj
Date: Sun Jun 19 06:10:50 2016
New Revision: 1749131

URL: http://svn.apache.org/viewvc?rev=1749131&view=rev
Log:
add unit test for bug 59719

Added:
    poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDataValidationConstraint.java   (with props)
Modified:
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationConstraint.java

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationConstraint.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationConstraint.java?rev=1749131&r1=1749130&r2=1749131&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationConstraint.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationConstraint.java Sun Jun 19 06:10:50 2016
@@ -90,7 +90,9 @@ public class XSSFDataValidationConstrain
 		}
 	}
 
-	/* (non-Javadoc)
+	/**
+	 * If validation type is {@link ValidationType#LIST}, returns list of literal values.
+	 * Otherwise returns <code>null</code>.
 	 * @see org.apache.poi.ss.usermodel.DataValidationConstraint#getExplicitListValues()
 	 */
 	public String[] getExplicitListValues() {

Added: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDataValidationConstraint.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDataValidationConstraint.java?rev=1749131&view=auto
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDataValidationConstraint.java (added)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDataValidationConstraint.java Sun Jun 19 06:10:50 2016
@@ -0,0 +1,48 @@
+/* ====================================================================
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+==================================================================== */
+package org.apache.poi.xssf.usermodel;
+
+import static org.junit.Assert.*;
+
+import org.apache.poi.ss.usermodel.DataValidationConstraint;
+import org.apache.poi.ss.usermodel.DataValidationConstraint.ValidationType;
+import org.apache.poi.ss.usermodel.DataValidationConstraint.OperatorType;
+import org.junit.Test;
+
+public class TestXSSFDataValidationConstraint {
+
+    // See bug 59719
+    @Test
+    public void listLiteralsQuotesAreStripped() {
+        int listType = ValidationType.LIST;
+        int ignoredType = OperatorType.IGNORED;
+        
+        String literal = "\"one, two, three\"";
+        String[] expected = new String[] { "one", "two", "three" };
+        DataValidationConstraint constraint = new XSSFDataValidationConstraint(listType, ignoredType, literal, null);
+        assertArrayEquals(expected, constraint.getExplicitListValues());
+        
+        String reference = "A1:A5";
+        constraint = new XSSFDataValidationConstraint(listType, ignoredType, reference, null);
+        assertNull(constraint.getExplicitListValues());
+        
+        String namedRange = "MyNamedRange";
+        constraint = new XSSFDataValidationConstraint(listType, ignoredType, namedRange, null);
+        assertNull(constraint.getExplicitListValues());
+    }
+
+}        

Propchange: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDataValidationConstraint.java
------------------------------------------------------------------------------
    svn:eol-style = native



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org